Skip to contentSkip to conversation

tags: put function prototypes back!

PATCH In review Alexey Dobriyan 3 participants 8 messages Feb 3, 2010 – Dec 2, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tags: put function prototypes back!

commit 7db86dc97fb0c47af63e6b965e8ff37126050d25
"ctags: usability fix" removed function prototypes from tags file claiming "It makes no real sense to include function prototypes". But it is useful for quickly determining which header file developer needs to include to fix compilation.

Now if someone wants to remove forward declatations (which I agree are baggage), write a postprocessing script.

Please apply.

Alexey, who is sick reverting this chunk locally.

---

 scripts/tags.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/tags.sh +1 -1
@@ -108,7 +108,7 @@ exuberant()
 	-I ____cacheline_internodealigned_in_smp                \
 	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
 	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
-	--extra=+f --c-kinds=-px                                \
+	--extra=+f --c-kinds=+px                                \
 	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
 	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'
 
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Alexey Dobriyan

commit 7db86dc97fb0c47af63e6b965e8ff37126050d25
"ctags: usability fix" removed function prototypes from tags file claiming "It makes no real sense to include function prototypes". But it is useful for quickly determining which header file developer needs to include to fix compilation.

Quoted 8 lines

Now if someone wants to remove forward declatations (which I agree are baggage), write a postprocessing script.

Please apply.

Alexey, who is sick reverting this chunk locally.

Thanks
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#2 lore raw
Quoted 10 lines · Uwe Kleine-König
Quoted 9 lines · Alexey Dobriyan

commit 7db86dc97fb0c47af63e6b965e8ff37126050d25
"ctags: usability fix" removed function prototypes from tags file claiming "It makes no real sense to include function prototypes". But it is useful for quickly determining which header file developer needs to include to fix compilation.

Now if someone wants to remove forward declatations (which I agree are baggage), write a postprocessing script.

Quoted 6 lines
Quoted 5 lines

Please apply.

Alexey, who is sick reverting this chunk locally.

Alexey, can you please resend the patch? I don't see it in the archives anywhere.

Thanks,
Michal

#3 lore raw
Quoted 13 lines · Michal Marek
Quoted 12 lines · Uwe Kleine-König
Quoted 11 lines · Alexey Dobriyan

commit 7db86dc97fb0c47af63e6b965e8ff37126050d25
"ctags: usability fix" removed function prototypes from tags file claiming "It makes no real sense to include function prototypes". But it is useful for quickly determining which header file developer needs to include to fix compilation.

Now if someone wants to remove forward declatations (which I agree are baggage), write a postprocessing script.

Please apply.

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

Alexey, who is sick reverting this chunk locally.

Alexey, can you please resend the patch? I don't see it in the archives anywhere.

Gmane supports getting mails by Message-Id:

	http://mid.gmane.org/20100203201816.GA5987@x200

redirects to http://article.gmane.org/gmane.linux.kernel/946067,
appending raw is nearly suitable for usage by mutt.

{ echo From lala Mon Sep 17 00:00:00 2001; wget -O - http://article.gmane.org/gmane.linux.kernel/946067/raw; } > patch

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#4 lore raw
Quoted 17 lines · Uwe Kleine-König
Quoted 16 lines · Michal Marek
Quoted 15 lines · Uwe Kleine-König
Quoted 14 lines · Alexey Dobriyan

commit 7db86dc97fb0c47af63e6b965e8ff37126050d25
"ctags: usability fix" removed function prototypes from tags file claiming "It makes no real sense to include function prototypes". But it is useful for quickly determining which header file developer needs to include to fix compilation.

Now if someone wants to remove forward declatations (which I agree are baggage), write a postprocessing script.

Please apply.

Alexey, who is sick reverting this chunk locally.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Alexey, can you please resend the patch? I don't see it in the archives anywhere.

Gmane supports getting mails by Message-Id:

	http://mid.gmane.org/20100203201816.GA5987@x200

Ah, thanks. I didn't notice that the original mail was from February.

Michal

#5 lore raw

PATCH RESEND 1/1 tags: put function prototypes back!

Commit 7db86dc (ctags: usability fix) removed function prototypes from tags file claiming "It makes no real sense to include function prototypes".
But it is useful for quickly determining which header file developer needs to include to fix compilation.

Now if someone wants to remove forward declatations (which I agree are baggage), write a postprocessing script.

---
 scripts/tags.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
scripts/tags.sh +1 -1
index 8509bb5..e091db3 100755
@@ -123,7 +123,7 @@ exuberant()
 	-I ____cacheline_internodealigned_in_smp                \
 	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
 	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
-	--extra=+f --c-kinds=-px                                \
+	--extra=+f --c-kinds=+px                                \
 	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
 	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'
 
Signature · 1 line
1.7.2.3
#6 lore raw

Hello Marek,

Quoted 8 lines · Uwe Kleine-König

Commit 7db86dc (ctags: usability fix) removed function prototypes from tags file claiming "It makes no real sense to include function prototypes".
But it is useful for quickly determining which header file developer needs to include to fix compilation.

Now if someone wants to remove forward declatations (which I agree are baggage), write a postprocessing script.

While sorting my pending patches I noticed that there's a typo, can you please do s/declatations/declarations/ when taking the patch. (Or tell me to resend an updated patch.) (I'd say the sentence before needs an "a" before developer, I'm not a native speaker though, so I kept Alexey's wording.)

Best regards and thanks
Uwe

Quoted 23 lines
---
 scripts/tags.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
scripts/tags.sh +1 -1
index 8509bb5..e091db3 100755
@@ -123,7 +123,7 @@ exuberant()
 	-I ____cacheline_internodealigned_in_smp                \
 	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
 	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
-	--extra=+f --c-kinds=-px                                \
+	--extra=+f --c-kinds=+px                                \
 	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
 	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'
 
Signature · 1 line
1.7.2.3
Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#7 lore raw
Quoted 11 lines · Uwe Kleine-König

Hello Marek,

Quoted 8 lines · Uwe Kleine-König

Commit 7db86dc (ctags: usability fix) removed function prototypes from tags file claiming "It makes no real sense to include function prototypes".
But it is useful for quickly determining which header file developer needs to include to fix compilation.

Now if someone wants to remove forward declatations (which I agree are baggage), write a postprocessing script.

OK, I applied your patch to kbuild-2.6.git#misc. I initially though it would be really nice to filter out forward declarations, but gave up on this.

Quoted 2 lines

While sorting my pending patches I noticed that there's a typo, can you please do s/declatations/declarations/ when taking the patch.

Done.

Michal