Skip to contentSkip to conversation

Net / pktgen: Fix freezing problem

PATCH Applied Rafael J. Wysocki 3 participants 9 messages Feb 4, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Net / pktgen: Fix freezing problem

From: Rafael J. Wysocki <[email protected]>
Subject: Net / pktgen: Fix freezing problem

Add missing try_to_freeze() to one of the pktgen_thread_worker() code paths so that it doesn't block suspend/hibernation.

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006

---
 net/core/pktgen.c |    1 +
 1 file changed, 1 insertion(+)
net/core/pktgen.c +1 -0
Index: linux-2.6/net/core/pktgen.c
===================================================================
@@ -3524,6 +3524,7 @@ static int pktgen_thread_worker(void *ar
 			wait_event_interruptible_timeout(t->queue,
 							 t->control != 0,
 							 HZ/10);
+			try_to_freeze();
 			continue;
 		}
 
maintainer Applied
#1 lore raw

From: "Rafael J. Wysocki" <[email protected]>
Date: Thu, 4 Feb 2010 22:50:58 +0100

Quoted 10 lines

From: Rafael J. Wysocki <[email protected]>
Subject: Net / pktgen: Fix freezing problem

Add missing try_to_freeze() to one of the pktgen_thread_worker() code paths so that it doesn't block suspend/hibernation.

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006

Applied, thanks a lot.

maintainer Applied
#2 lore raw
In reply to Rafael J. Wysocki

From: "Rafael J. Wysocki" <[email protected]>
Date: Thu, 4 Feb 2010 22:50:58 +0100

Quoted 10 lines

From: Rafael J. Wysocki <[email protected]>
Subject: Net / pktgen: Fix freezing problem

Add missing try_to_freeze() to one of the pktgen_thread_worker() code paths so that it doesn't block suspend/hibernation.

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006

Applied, thanks a lot.

#3 lore raw
In reply to Rafael J. Wysocki
Quoted 19 lines · On Thu, 4 Feb 2010 22:50:58 +0100 "Rafael J. Wysocki" <[email protected]> wrote:

From: Rafael J. Wysocki <[email protected]>
Subject: Net / pktgen: Fix freezing problem

Add missing try_to_freeze() to one of the pktgen_thread_worker() code paths so that it doesn't block suspend/hibernation.

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006

---
 net/core/pktgen.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/net/core/pktgen.c
===================================================================

net/core/pktgen.c static int pktgen_thread_worker(void *ar · line 3530

Quoted 7 lines
net/core/pktgen.c +1 -0
@@ -3524,6 +3524,7 @@ static int pktgen_thread_worker(void *ar
 			wait_event_interruptible_timeout(t->queue,
 							 t->control != 0,
 							 HZ/10);
+			try_to_freeze();
 			continue;
 		}
 

Also needed in -stable, IMO.

#4 lore raw
In reply to Rafael J. Wysocki
Quoted 19 lines · On Thu, 4 Feb 2010 22:50:58 +0100 "Rafael J. Wysocki" <[email protected]> wrote:

From: Rafael J. Wysocki <[email protected]>
Subject: Net / pktgen: Fix freezing problem

Add missing try_to_freeze() to one of the pktgen_thread_worker() code paths so that it doesn't block suspend/hibernation.

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006

---
 net/core/pktgen.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6/net/core/pktgen.c
===================================================================

net/core/pktgen.c static int pktgen_thread_worker(void *ar · line 3530

Quoted 7 lines
net/core/pktgen.c +1 -0
@@ -3524,6 +3524,7 @@ static int pktgen_thread_worker(void *ar
 			wait_event_interruptible_timeout(t->queue,
 							 t->control != 0,
 							 HZ/10);
+			try_to_freeze();
 			continue;
 		}
 

Also needed in -stable, IMO.

#5 lore raw
Quoted 16 lines · Andrew Morton
Quoted 14 lines · On Thu, 4 Feb 2010 22:50:58 +0100 "Rafael J. Wysocki" <[email protected]> wrote:

From: Rafael J. Wysocki <[email protected]>
Subject: Net / pktgen: Fix freezing problem

Add missing try_to_freeze() to one of the pktgen_thread_worker() code paths so that it doesn't block suspend/hibernation.

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006

---
 net/core/pktgen.c |    1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

net/core/pktgen.c static int pktgen_thread_worker(void *ar · line 3530

Quoted 12 lines

Index: linux-2.6/net/core/pktgen.c
===================================================================

net/core/pktgen.c +1 -0
@@ -3524,6 +3524,7 @@ static int pktgen_thread_worker(void *ar
 			wait_event_interruptible_timeout(t->queue,
 							 t->control != 0,
 							 HZ/10);
+			try_to_freeze();
 			continue;
 		}
 

Also needed in -stable, IMO.

Indeed.

#6 lore raw
In reply to Andrew Morton
Quoted 16 lines · Andrew Morton
Quoted 14 lines · On Thu, 4 Feb 2010 22:50:58 +0100 "Rafael J. Wysocki" <[email protected]> wrote:

From: Rafael J. Wysocki <[email protected]>
Subject: Net / pktgen: Fix freezing problem

Add missing try_to_freeze() to one of the pktgen_thread_worker() code paths so that it doesn't block suspend/hibernation.

Fixes http://bugzilla.kernel.org/show_bug.cgi?id=15006

---
 net/core/pktgen.c |    1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

net/core/pktgen.c static int pktgen_thread_worker(void *ar · line 3530

Quoted 12 lines

Index: linux-2.6/net/core/pktgen.c
===================================================================

net/core/pktgen.c +1 -0
@@ -3524,6 +3524,7 @@ static int pktgen_thread_worker(void *ar
 			wait_event_interruptible_timeout(t->queue,
 							 t->control != 0,
 							 HZ/10);
+			try_to_freeze();
 			continue;
 		}
 

Also needed in -stable, IMO.

Indeed.