Skip to contentSkip to conversation

powerpc: Quieten cede latency printk

PATCH In review Anton Blanchard 3 participants 3 messages Feb 7, 2010 – Feb 8, 2010 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: Quieten cede latency printk

The cede latency stuff is relatively new and we don't need to complain about it not working on older firmware.

---

arch/powerpc/platforms/pseries/hotplug-cpu.c +0 -8
Index: powerpc.git/arch/powerpc/platforms/pseries/hotplug-cpu.c
===================================================================
@@ -396,14 +396,6 @@ static int parse_cede_parameters(void)
 				__pa(cede_parameters),
 				CEDE_LATENCY_PARAM_MAX_LENGTH);
 
-	if (call_status != 0)
-		printk(KERN_INFO "CEDE_LATENCY: \
-			%s %s Error calling get-system-parameter(0x%x)\n",
-			__FILE__, __func__, call_status);
-	else
-		printk(KERN_INFO "CEDE_LATENCY: \
-			get-system-parameter successful.\n");
-
 	return call_status;
 }
 
#2 lore raw
Quoted 11 lines · Balbir Singh
Quoted 5 lines · Anton Blanchard

The cede latency stuff is relatively new and we don't need to complain about it not working on older firmware.

Seems like a reasonable change. CC'ing Vaidy and Gautham to look even more closely at the patch.

Hi Anton,

Removing the printk is reasonable. The failure case is noise in older firmware while the success case may not be very informative.

Thanks,
Vaidy