Skip to contentSkip to conversation

mtrr: kill over the top warn

PATCH In review Alan Cox 1 participant 2 messages Feb 8, 2010 – Feb 16, 2010 x86

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 mtrr: kill over the top warn

Fixes bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=12558
Fixes bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=12317

(and if this really needed to be a warn you'd be responding to the bugs left in bugzilla from it...)

---

 arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mtrr/generic.c +1 -1
index 4d75584..163e59e 100644
@@ -464,7 +464,7 @@ static void generic_get_mtrr(unsigned int reg, unsigned long *base,
 		tmp |= ~((1<<(hi - 1)) - 1);
 
 		if (tmp != mask_lo) {
-			WARN_ONCE(1, KERN_INFO "mtrr: your BIOS has set up an incorrect mask, fixing it up.\n");
+			printk(KERN_WARNING "mtrr: your BIOS has configured an incorrect mask, fixing it.\n");
 			mask_lo = tmp;
 		}
 	}
#1 lore raw

[tip:x86/mtrr] x86, mtrr: Kill over the top warn

Commit-ID:  942fa3b63eb525aa0512ba28c42e656d8efc6787
Gitweb:     http://git.kernel.org/tip/942fa3b63eb525aa0512ba28c42e656d8efc6787
Author:     Alan Cox <[email protected]>
AuthorDate: Mon, 8 Feb 2010 10:03:17 +0000
Committer:  H. Peter Anvin <[email protected]>
CommitDate: Mon, 15 Feb 2010 19:38:52 -0800

x86, mtrr: Kill over the top warn

Fixes bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=12558
Fixes bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=12317

(and if this really needed to be a warn you'd be responding to the bugs left in bugzilla from it...)

LKML-Reference: <[email protected]>

---
 arch/x86/kernel/cpu/mtrr/generic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/cpu/mtrr/generic.c +1 -1
index 4d75584..163e59e 100644
@@ -464,7 +464,7 @@ static void generic_get_mtrr(unsigned int reg, unsigned long *base,
 		tmp |= ~((1<<(hi - 1)) - 1);
 
 		if (tmp != mask_lo) {
-			WARN_ONCE(1, KERN_INFO "mtrr: your BIOS has set up an incorrect mask, fixing it up.\n");
+			printk(KERN_WARNING "mtrr: your BIOS has configured an incorrect mask, fixing it.\n");
 			mask_lo = tmp;
 		}
 	}