Skip to contentSkip to conversation

kgdb: drop duplicate debugger_exception_handler

U-Boot New Wolfgang Denk 2 participants 3 messages Feb 8, 2010

lore
Share & tools
lore
#0 lore raw

Dear Mike,

it seems your commit cbb0cab1d929839d1cf170b54b1fef05896433ea:

Author: Mike Frysinger <[email protected]>
Date:   Mon Dec 21 18:40:43 2009 -0500

kgdb: drop duplicate debugger_exception_handler

The debugger_exception_handler definition is the same for everyone, so use the common one now.

breaks building of MPC8xx based boards that have KGDB support enabled; for example:

$ ./MAKEALL RBC823
Configuring for RBC823 board...
traps.c: In function 'MachineCheckException':
traps.c:126: error: 'debugger_exception_handler' undeclared (first use in this function)
traps.c:126: error: (Each undeclared identifier is reported only once
traps.c:126: error: for each function it appears in.)
traps.c: In function 'AlignmentException':
traps.c:159: error: 'debugger_exception_handler' undeclared (first use in this function)
traps.c: In function 'ProgramCheckException':
traps.c:171: error: 'debugger_exception_handler' undeclared (first use in this function)
traps.c: In function 'SoftEmuException':
traps.c:183: error: 'debugger_exception_handler' undeclared (first use in this function)
traps.c: In function 'UnknownException':
traps.c:196: error: 'debugger_exception_handler' undeclared (first use in this function)

[Ditto for cogent_mpc8xx]

Could you please have a look?

Thanks in advance.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Parkinson's Law:  Work expands to fill the time alloted it.
#1 lore raw

PATCH 1/1 kgdb: cpu/mpc* cpu/74xx: include kgdb.h when needed

Commit cbb0cab1d929839d broke some platforms which used kgdb code but didn't actually include kgdb.h. So include kgdb.h in all the relevant traps code.

---
 cpu/74xx_7xx/traps.c |    1 +
 cpu/mpc512x/traps.c  |    1 +
 cpu/mpc5xx/traps.c   |    1 +
 cpu/mpc5xxx/traps.c  |    1 +
 cpu/mpc8220/traps.c  |    1 +
 cpu/mpc8260/traps.c  |    1 +
 cpu/mpc83xx/traps.c  |    1 +
 cpu/mpc85xx/traps.c  |    1 +
 cpu/mpc86xx/traps.c  |    1 +
 cpu/mpc8xx/traps.c   |    1 +
 10 files changed, 10 insertions(+), 0 deletions(-)
cpu/74xx_7xx/traps.c +1 -0
index 24e28e2..1d5dd01 100644
@@ -34,6 +34,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <kgdb.h>
 #include <asm/processor.h>
 
 #ifdef CONFIG_AMIGAONEG3SE
cpu/mpc512x/traps.c +1 -0
index 8000fab..786f4a5 100644
@@ -28,6 +28,7 @@
  */
 
 #include <common.h>
+#include <kgdb.h>
 #include <asm/processor.h>
 
 DECLARE_GLOBAL_DATA_PTR;
cpu/mpc5xx/traps.c +1 -0
index cc8e091..6882c21 100644
@@ -34,6 +34,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <kgdb.h>
 #include <asm/processor.h>
 
 #if defined(CONFIG_CMD_BEDBUG)
cpu/mpc5xxx/traps.c +1 -0
index 2a09153..934a2f2 100644
@@ -35,6 +35,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <kgdb.h>
 #include <asm/processor.h>
 
 /* Returns 0 if exception not found and fixup otherwise.  */
cpu/mpc8220/traps.c +1 -0
index f98d40f..4565780 100644
@@ -35,6 +35,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <kgdb.h>
 #include <asm/processor.h>
 
 /* Returns 0 if exception not found and fixup otherwise.  */
cpu/mpc8260/traps.c +1 -0
index f9f4dea..d216f71 100644
@@ -34,6 +34,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <kgdb.h>
 #include <asm/processor.h>
 #include <asm/m8260_pci.h>
 
cpu/mpc83xx/traps.c +1 -0
index 3b09a62..9d71b8b 100644
@@ -27,6 +27,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <kgdb.h>
 #include <asm/processor.h>
 #include <asm/mpc8349_pci.h>
 
cpu/mpc85xx/traps.c +1 -0
index 241ebd5..10108d8 100644
@@ -38,6 +38,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <kgdb.h>
 #include <asm/processor.h>
 
 DECLARE_GLOBAL_DATA_PTR;
cpu/mpc86xx/traps.c +1 -0
index ad005c3..406403e 100644
@@ -32,6 +32,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <kgdb.h>
 #include <asm/processor.h>
 
 DECLARE_GLOBAL_DATA_PTR;
cpu/mpc8xx/traps.c +1 -0
index f357c8d..6efe8e0 100644
@@ -34,6 +34,7 @@
 
 #include <common.h>
 #include <command.h>
+#include <kgdb.h>
 #include <asm/processor.h>
 
 #if defined(CONFIG_CMD_BEDBUG)
Signature · 1 line
1.6.6.1
author Applied
#2 lore raw

PATCH 1/1 kgdb: cpu/mpc* cpu/74xx: include kgdb.h when needed

Dear Mike Frysinger,

Quoted 5 lines · In message <[email protected]> you wrote:

Commit cbb0cab1d929839d broke some platforms which used kgdb code but didn't actually include kgdb.h. So include kgdb.h in all the relevant traps code.

Thanks, applied.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Ja, mach' nur einen Plan,    sei nur ein grosses Licht
und mach' dann noch 'nen zweiten Plan,    geh'n tun sie beide nicht."
                                     -- Bert Brecht, Dreigroschenoper