be2net: bug fix in be_change_mtu
Subsystems (2)
PATCH 3/7 be2net: bug fix in be_change_mtu
Current code allows the new mtu to cross the supported value. This patch fixes the boundary checks.
From: Suresh R <[email protected]>
Signed-off-by Ajit Khaparde <[email protected]>
--- drivers/net/benet/be_main.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
drivers/net/benet/be_main.c +4 -2
@@ -473,10 +473,12 @@ static int be_change_mtu(struct net_device *netdev, int new_mtu) {struct be_adapter *adapter =netdev_priv (netdev);if (new_mtu <BE_MIN_MTU || - new_mtu >BE_MAX_JUMBO_FRAME_SIZE ) { + new_mtu > (BE_MAX_JUMBO_FRAME_SIZE - + (ETH_HLEN +ETH_FCS_LEN ))) {dev_info (&adapter->pdev->dev,"MTU must be between %d and %d bytes\n" , -BE_MIN_MTU ,BE_MAX_JUMBO_FRAME_SIZE ); +BE_MIN_MTU , + (BE_MAX_JUMBO_FRAME_SIZE - (ETH_HLEN +ETH_FCS_LEN )));return -EINVAL ; } dev_info(&adapter->pdev->dev, "MTU changed from %d to %d bytes\n",
Signature · 1 line
1.6.3.3
From: Ajit Khaparde <[email protected]>
Date: Tue, 9 Feb 2010 17:02:43 +0530
Quoted 5 lines
Current code allows the new mtu to cross the supported value. This patch fixes the boundary checks.
From: Suresh R <[email protected]>
Signed-off-by Ajit Khaparde <[email protected]>
Applied to net-next-2.6