Skip to contentSkip to conversation

CEPH: fix manpages so they are only installed once

PATCH In review Josef Bacik 2 participants 2 messages Feb 9, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CEPH: fix manpages so they are only installed once

While creating a spec file for CEPH, rpmbuild was complaining because make install was copying the manpages in, and then copying them in again. This is because man_MANS and dist_man_MANS are supposed to be two seperate lists that do not overlap. So make install would install all the man pages in the man_MANS list and the dist_man_MANS list. This patch kills the dist_man_MANS thing to keep this from happening. This made rpmbuild happy, which makes me happy :). Thanks,

---
 man/Makefile.am |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
man/Makefile.am +0 -2
index 56bc6e1..c3e139f 100644
@@ -17,5 +17,3 @@ man_MANS = \
 	mount.ceph.8 \
 	radosgw.8 \
 	radosgw_admin.8
-
-dist_man_MANS = $(man_MANS)
\ No newline at end of file
Signature · 9 lines
1.6.2.5


------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
#1 lore raw

Aha, I was just trying to fix this (with the debian build). I had to use dist_man_MANS, though, since the *.8 files don't have to be built. Pushed.

Thanks!
sage

man/Makefile.am +1 -3
index 56bc6e1..c721023 100644
@@ -1,6 +1,6 @@
 AUTOMAKE_OPTIONS = gnu
 
-man_MANS = \
+dist_man_MANS = \
        cosd.8 \
        cmds.8 \
        cmon.8 \
@@ -17,5 +17,3 @@ man_MANS = \
        mount.ceph.8 \
        radosgw.8 \
        radosgw_admin.8
-
-dist_man_MANS = $(man_MANS)
Quoted 40 lines · Josef Bacik

While creating a spec file for CEPH, rpmbuild was complaining because make install was copying the manpages in, and then copying them in again. This is because man_MANS and dist_man_MANS are supposed to be two seperate lists that do not overlap. So make install would install all the man pages in the man_MANS list and the dist_man_MANS list. This patch kills the dist_man_MANS thing to keep this from happening. This made rpmbuild happy, which makes me happy :). Thanks,

---
 man/Makefile.am |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
man/Makefile.am +0 -2
index 56bc6e1..c3e139f 100644
@@ -17,5 +17,3 @@ man_MANS = \
 	mount.ceph.8 \
 	radosgw.8 \
 	radosgw_admin.8
-
-dist_man_MANS = $(man_MANS)
\ No newline at end of file
Signature · 13 lines
1.6.2.5


------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Ceph-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ceph-devel

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com