Skip to contentSkip to conversation

Add Phytec i.MX sound support for AC97

PATCH In review Sascha Hauer 3 participants 6 messages Feb 9, 2010 – Feb 10, 2010

Subsystems (3)
lore
Share & tools
lore

Sascha Hauer

author maintainer
#0 lore raw

PATCH 1/1 Add Phytec i.MX sound support for AC97

Hi Marc et all,

The following patch adds support for Phytec i.MX boards in AC97 mode. With this patch only some board glue code is missing to enable sound for the first i.MX boards. I'll push the board code through my i.MX tree. Please consider including this patch for -next.

Sascha

Quoted 1 line

From 264b0916b712d6cbbcbd2f7b208b1c84b40a3f54 Mon Sep 17 00:00:00 2001

From: Sascha Hauer <[email protected]>
Date: Wed, 25 Nov 2009 16:18:28 +0100
Subject: [PATCH 1/6] ASoC: add phycore-ac97 sound support

This patch adds sound support for Phytec PhyCORE / PhyCARD modules in AC97 mode.

---
 sound/soc/imx/Kconfig        |   11 +++++-
 sound/soc/imx/Makefile       |    2 +
 sound/soc/imx/phycore-ac97.c |   90 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 102 insertions(+), 1 deletions(-)
 create mode 100644 sound/soc/imx/phycore-ac97.c
sound/soc/imx/Kconfig +10 -1
index 5f006f0..e687d53 100644
@@ -1,6 +1,6 @@
 config SND_IMX_SOC
 	tristate "SoC Audio for Freecale i.MX CPUs"
-	depends on ARCH_MXC && BROKEN
+	depends on ARCH_MXC
 	select SND_PCM
 	select FIQ
 	select SND_SOC_AC97_BUS
@@ -11,3 +11,12 @@ config SND_IMX_SOC
 config SND_MXC_SOC_SSI
 	tristate
 
+config SND_SOC_PHYCORE_AC97
+	tristate "SoC Audio support for Phytec phyCORE (and phyCARD) boards"
+	depends on MACH_PCM043 || MACH_PCA100
+	select SND_IMX_SOC
+	select SND_SOC_WM9712
+	help
+	  Say Y if you want to add support for SoC audio on Phytec phyCORE
+	  and phyCARD boards in AC97 mode
+
sound/soc/imx/Makefile +2 -0
index d05cc95..9f8bb92 100644
@@ -8,3 +8,5 @@ endif
 obj-$(CONFIG_SND_IMX_SOC) += snd-soc-imx.o
 
 # i.MX Machine Support
+snd-soc-phycore-ac97-objs := phycore-ac97.o
+obj-$(CONFIG_SND_SOC_PHYCORE_AC97) += snd-soc-phycore-ac97.o
sound/soc/imx/phycore-ac97.c new file +90 -0

90 lines not on this page · raw message

Signature · 7 lines
1.6.6

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Sascha Hauer

Hi Marc et all,

The following patch adds support for Phytec i.MX boards in AC97 mode. With this patch only some board glue code is missing to enable sound for the first i.MX boards. I'll push the board code through my i.MX tree. Please consider including this patch for -next.

Sascha

Quoted 1 line

From 264b0916b712d6cbbcbd2f7b208b1c84b40a3f54 Mon Sep 17 00:00:00 2001

Quoted 8 lines

From: Sascha Hauer <[email protected]>
Date: Wed, 25 Nov 2009 16:18:28 +0100
Subject: [PATCH 1/6] ASoC: add phycore-ac97 sound support

This patch adds sound support for Phytec PhyCORE / PhyCARD modules in AC97 mode.

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
#2 lore raw
In reply to Sascha Hauer
Quoted 1 line · Sascha Hauer

Hi Marc et all,

Mar*k*.

Quoted 10 lines

The following patch adds support for Phytec i.MX boards in AC97 mode. With this patch only some board glue code is missing to enable sound for the first i.MX boards. I'll push the board code through my i.MX tree. Please consider including this patch for -next.

Sascha

From 264b0916b712d6cbbcbd2f7b208b1c84b40a3f54 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <[email protected]>

Applied but please in future send don't send patches with patch headers in the body and explanatory text before them like this since none of the tools understand this format, the entire body of the e-mail gets read as the commit messsage.

#3 lore raw
In reply to Sascha Hauer

sound/soc/imx/Kconfig line 3

Quoted 4 lines · Sascha Hauer

config SND_IMX_SOC

sound/soc/imx/Kconfig +1 -1
 	tristate "SoC Audio for Freecale i.MX CPUs"
-	depends on ARCH_MXC && BROKEN
+	depends on ARCH_MXC

BTW, this should not be here - we still need to wait for the arch/arm side of things to merge in before the drivers will work.

author maintainer
#4 lore raw
Quoted 9 lines · Mark Brown

sound/soc/imx/Kconfig line 3

Quoted 4 lines · Sascha Hauer

config SND_IMX_SOC

sound/soc/imx/Kconfig +1 -1
 	tristate "SoC Audio for Freecale i.MX CPUs"
-	depends on ARCH_MXC && BROKEN
+	depends on ARCH_MXC

BTW, this should not be here - we still need to wait for the arch/arm side of things to merge in before the drivers will work.

I added the corresponding files to my mxc-master branch and they should show up on -next tomorrow. I removed the BROKEN in this patch because I was sure that I add the files during this merge window and because it shouldn't cause compile breakage in the mean time since the driver is not selected in any config. But of course you are right, will do so next time.

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#5 lore raw
Quoted 6 lines · Sascha Hauer

I added the corresponding files to my mxc-master branch and they should show up on -next tomorrow. I removed the BROKEN in this patch because I was sure that I add the files during this merge window and because it shouldn't cause compile breakage in the mean time since the driver is not selected in any config. But of course you are right, will do so next time.

Given the interest in i.MX audio support even stuff that's not there by default is going to raise people's hopes needlessly.