Skip to contentSkip to conversation

: run-fcntltests.sh: Thaw and cleanup processes on error

PATCH In review Sukadev Bhattiprolu 2 participants 2 messages Feb 9, 2010 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : run-fcntltests.sh: Thaw and cleanup processes on error

From: Sukadev Bhattiprolu <[email protected]>
Date: Tue, 9 Feb 2010 11:08:22 -0800
Subject: [PATCH][cr-test]: run-fcntltests.sh: Thaw and cleanup processes on error

If the fcntl tests (filelock[12], filelease1 and fsetown1) fail during checkpoint, the processes end up frozen and appear hung. Thaw the processes and terminate them before exiting the script.

Bug reported by Serge Hallyn.

---
 fileio/run-fcntltests.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fileio/run-fcntltests.sh +2 -0
index f76c942..35be131 100755
@@ -54,6 +54,8 @@ checkpoint()
 	if [ $ret -ne 0 ]; then
 		$ECHO "***** FAIL: Checkpoint of $pid failed"
 		ps -efL |grep $TEST_CMD >> $SCRIPT_LOG
+		killall -9 `basename $TEST_CMD`
+		thaw
 		exit 1;
 	fi
 }
Signature · 1 line
1.6.6.1

A message that is not in the archive (sent off-list or not yet received): 20100209193155.GA30005-r/[email protected]

#2 lore raw
Quoted 9 lines · Sukadev Bhattiprolu

From: Sukadev Bhattiprolu <[email protected]>
Date: Tue, 9 Feb 2010 11:08:22 -0800
Subject: [PATCH][cr-test]: run-fcntltests.sh: Thaw and cleanup processes on error

If the fcntl tests (filelock[12], filelease1 and fsetown1) fail during checkpoint, the processes end up frozen and appear hung. Thaw the processes and terminate them before exiting the script.

Bug reported by Serge Hallyn.

Thanks, will push this and the eclone tests.

Quoted 20 lines
---
 fileio/run-fcntltests.sh |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fileio/run-fcntltests.sh +2 -0
index f76c942..35be131 100755
@@ -54,6 +54,8 @@ checkpoint()
 	if [ $ret -ne 0 ]; then
 		$ECHO "***** FAIL: Checkpoint of $pid failed"
 		ps -efL |grep $TEST_CMD >> $SCRIPT_LOG
+		killall -9 `basename $TEST_CMD`
+		thaw
 		exit 1;
 	fi
 }
Signature · 1 line
1.6.6.1