Skip to contentSkip to conversation

Allow server to reject maximum commit offsets

PATCH In review J. Bruce Fields 3 participants 9 messages Feb 9, 2010 – Feb 11, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Allow server to reject maximum commit offsets

From: J. Bruce Fields <[email protected]>

These two tests insist that a server must accept commits with offset 2^64-1 and 2^64-2. I can find no justification in the spec for this requirement.

The linux server was recently changed to reject (with INVAL) offsets over 2^63-1, which is the maximum that the vfs commit routine can accept. That behavior is consistent with the NFSv3 commit implementation and with the NFSv4 write implementation.

The maximum offset allowed may vary depending on filesystem or server, so I think it's simplest just to delete these tests. (Alternatively, we could replace the offset by whatever we consider a reasonable least common denominator, e.g. 2^31-1.)

---
 lib/nfs4/servertests/st_commit.py |   18 ------------------
 1 files changed, 0 insertions(+), 18 deletions(-)
lib/nfs4/servertests/st_commit.py +0 -18
index 2955d79..0005e54 100644
@@ -35,24 +35,6 @@ def testCommitOffset1(t, env):
     """
     _commit(t, env.c1, 1)
 
-def testCommitOffsetMax1(t, env):
-    """COMMIT
-
-    FLAGS: commit all
-    DEPEND: MKFILE
-    CODE: CMT1c
-    """
-    _commit(t, env.c1, 0xffffffffffffffffL)
-
-def testCommitOffsetMax2(t, env):
-    """COMMIT
-
-    FLAGS: commit all
-    DEPEND: MKFILE
-    CODE: CMT1d
-    """
-    _commit(t, env.c1, 0xfffffffffffffffeL)
-
 def testCommitCount1(t, env):
     """COMMIT
 
Signature · 1 line
1.6.3.3
#1 lore raw
Quoted 5 lines · bfields

From: J. Bruce Fields <[email protected]>

These two tests insist that a server must accept commits with offset 2^64-1 and 2^64-2. I can find no justification in the spec for this requirement.

You can also get this and another old patch by:

git pull git://linux-nfs.org/~bfields/pynfs.git master

--b.

#2 lore raw
In reply to J. Bruce Fields
Quoted 11 lines · J. Bruce Fields

From: J. Bruce Fields <[email protected]>

These two tests insist that a server must accept commits with offset 2^64-1 and 2^64-2. I can find no justification in the spec for this requirement.

The linux server was recently changed to reject (with INVAL) offsets over 2^63-1, which is the maximum that the vfs commit routine can accept. That behavior is consistent with the NFSv3 commit implementation and with the NFSv4 write implementation.

I guess that I am missing something. At least the NFSv3 COMMIT operation takes an unsigned 64 bit quantity. That would seem to make the test correct, would it not?

ps

Quoted 39 lines

The maximum offset allowed may vary depending on filesystem or server, so I think it's simplest just to delete these tests. (Alternatively, we could replace the offset by whatever we consider a reasonable least common denominator, e.g. 2^31-1.)

---
 lib/nfs4/servertests/st_commit.py |   18 ------------------
 1 files changed, 0 insertions(+), 18 deletions(-)
lib/nfs4/servertests/st_commit.py +0 -18
index 2955d79..0005e54 100644
@@ -35,24 +35,6 @@ def testCommitOffset1(t, env):
     """
     _commit(t, env.c1, 1)
 
-def testCommitOffsetMax1(t, env):
-    """COMMIT
-
-    FLAGS: commit all
-    DEPEND: MKFILE
-    CODE: CMT1c
-    """
-    _commit(t, env.c1, 0xffffffffffffffffL)
-
-def testCommitOffsetMax2(t, env):
-    """COMMIT
-
-    FLAGS: commit all
-    DEPEND: MKFILE
-    CODE: CMT1d
-    """
-    _commit(t, env.c1, 0xfffffffffffffffeL)
-
 def testCommitCount1(t, env):
     """COMMIT
 
#3 lore raw
Quoted 13 lines · Peter Staubach
Quoted 11 lines · J. Bruce Fields

From: J. Bruce Fields <[email protected]>

These two tests insist that a server must accept commits with offset 2^64-1 and 2^64-2. I can find no justification in the spec for this requirement.

The linux server was recently changed to reject (with INVAL) offsets over 2^63-1, which is the maximum that the vfs commit routine can accept. That behavior is consistent with the NFSv3 commit implementation and with the NFSv4 write implementation.

Quoted 3 lines

I guess that I am missing something. At least the NFSv3 COMMIT operation takes an unsigned 64 bit quantity. That would seem to make the test correct, would it not?

Yes, it's an unsigned 64 bit integer, but so what: there's no rule that says the server has to return NFS4ERR_OK to any operation for which all the arguments are valid xdr.

And just because the protocol allows 64-bit offsets doesn't mean every server and filesystem is going to support the full range.

--b.

Quoted 43 lines

ps

Quoted 39 lines

The maximum offset allowed may vary depending on filesystem or server, so I think it's simplest just to delete these tests. (Alternatively, we could replace the offset by whatever we consider a reasonable least common denominator, e.g. 2^31-1.)

---
 lib/nfs4/servertests/st_commit.py |   18 ------------------
 1 files changed, 0 insertions(+), 18 deletions(-)
lib/nfs4/servertests/st_commit.py +0 -18
index 2955d79..0005e54 100644
@@ -35,24 +35,6 @@ def testCommitOffset1(t, env):
     """
     _commit(t, env.c1, 1)
 
-def testCommitOffsetMax1(t, env):
-    """COMMIT
-
-    FLAGS: commit all
-    DEPEND: MKFILE
-    CODE: CMT1c
-    """
-    _commit(t, env.c1, 0xffffffffffffffffL)
-
-def testCommitOffsetMax2(t, env):
-    """COMMIT
-
-    FLAGS: commit all
-    DEPEND: MKFILE
-    CODE: CMT1d
-    """
-    _commit(t, env.c1, 0xfffffffffffffffeL)
-
 def testCommitCount1(t, env):
     """COMMIT
 
#4 lore raw
Quoted 17 lines · J. Bruce Fields
Quoted 7 lines · Peter Staubach
Quoted 6 lines · J. Bruce Fields

From: J. Bruce Fields <[email protected]>

These two tests insist that a server must accept commits with offset 2^64-1 and 2^64-2. I can find no justification in the spec for this requirement.

Quoted 8 lines
Quoted 5 lines

The linux server was recently changed to reject (with INVAL) offsets over 2^63-1, which is the maximum that the vfs commit routine can accept. That behavior is consistent with the NFSv3 commit implementation and with the NFSv4 write implementation.

I guess that I am missing something. At least the NFSv3 COMMIT operation takes an unsigned 64 bit quantity. That would seem to make the test correct, would it not?

Quoted 7 lines

Yes, it's an unsigned 64 bit integer, but so what: there's no rule that says the server has to return NFS4ERR_OK to any operation for which all the arguments are valid xdr.

And just because the protocol allows 64-bit offsets doesn't mean every server and filesystem is going to support the full range.

No, that's certainly true. However, you are tailoring the testsuite to a Linux specific implementation, which strikes me as vaguely not so good. What if you just commented out the tests, with a comment indicating that the Linux server can not handle the full 64 bits of range, instead of deleting them completely?

	Thanx...

		ps
Quoted 43 lines

--b.

Quoted 41 lines

ps

Quoted 39 lines

The maximum offset allowed may vary depending on filesystem or server, so I think it's simplest just to delete these tests. (Alternatively, we could replace the offset by whatever we consider a reasonable least common denominator, e.g. 2^31-1.)

---
 lib/nfs4/servertests/st_commit.py |   18 ------------------
 1 files changed, 0 insertions(+), 18 deletions(-)
lib/nfs4/servertests/st_commit.py +0 -18
index 2955d79..0005e54 100644
@@ -35,24 +35,6 @@ def testCommitOffset1(t, env):
     """
     _commit(t, env.c1, 1)
 
-def testCommitOffsetMax1(t, env):
-    """COMMIT
-
-    FLAGS: commit all
-    DEPEND: MKFILE
-    CODE: CMT1c
-    """
-    _commit(t, env.c1, 0xffffffffffffffffL)
-
-def testCommitOffsetMax2(t, env):
-    """COMMIT
-
-    FLAGS: commit all
-    DEPEND: MKFILE
-    CODE: CMT1d
-    """
-    _commit(t, env.c1, 0xfffffffffffffffeL)
-
 def testCommitCount1(t, env):
     """COMMIT
 
#5 lore raw
Quoted 26 lines · Peter Staubach
Quoted 17 lines · J. Bruce Fields
Quoted 7 lines · Peter Staubach
Quoted 6 lines · J. Bruce Fields

From: J. Bruce Fields <[email protected]>

These two tests insist that a server must accept commits with offset 2^64-1 and 2^64-2. I can find no justification in the spec for this requirement.

Quoted 8 lines
Quoted 5 lines

The linux server was recently changed to reject (with INVAL) offsets over 2^63-1, which is the maximum that the vfs commit routine can accept. That behavior is consistent with the NFSv3 commit implementation and with the NFSv4 write implementation.

I guess that I am missing something. At least the NFSv3 COMMIT operation takes an unsigned 64 bit quantity. That would seem to make the test correct, would it not?

Quoted 7 lines

Yes, it's an unsigned 64 bit integer, but so what: there's no rule that says the server has to return NFS4ERR_OK to any operation for which all the arguments are valid xdr.

And just because the protocol allows 64-bit offsets doesn't mean every server and filesystem is going to support the full range.

Quoted 6 lines

No, that's certainly true. However, you are tailoring the testsuite to a Linux specific implementation, which strikes me as vaguely not so good. What if you just commented out the tests, with a comment indicating that the Linux server can not handle the full 64 bits of range, instead of deleting them completely?

The tests are primarily meant to test protocol conformance. So they shouldn't be reporting failures on conforming behavior.

Perhaps it would also be interesting to run the tests in a mode which probes and summarizes server characteristics (maximum supported offset, supported features, etc.), but that's a job for another day.

--b.

#6 lore raw
Quoted 6 lines · J. Bruce Fields

The tests are primarily meant to test protocol conformance. So they shouldn't be reporting failures on conforming behavior.

Perhaps it would also be interesting to run the tests in a mode which probes and summarizes server characteristics (maximum supported offset, supported features, etc.), but that's a job for another day.

Hm, actually another alternative would be just to keep these tests, but to *always* allow them to succeed. Or to fail only if the server returns an error that really is totally wrong.

Even if we don't much care about the results, sending operations with extreme values for the arguments may still help make sure server's don't skimp on the range-checking and crash in some lower-level code.

--b.

#7 lore raw
Quoted 8 lines · J. Bruce Fields
Quoted 6 lines · J. Bruce Fields

The tests are primarily meant to test protocol conformance. So they shouldn't be reporting failures on conforming behavior.

Perhaps it would also be interesting to run the tests in a mode which probes and summarizes server characteristics (maximum supported offset, supported features, etc.), but that's a job for another day.

Quoted 8 lines

Hm, actually another alternative would be just to keep these tests, but to *always* allow them to succeed. Or to fail only if the server returns an error that really is totally wrong.

Even if we don't much care about the results, sending operations with extreme values for the arguments may still help make sure server's don't skimp on the range-checking and crash in some lower-level code.

This sounds reasonable to me.

ps

#8 lore raw
In reply to Peter Staubach
Quoted 13 lines · Peter Staubach
Quoted 11 lines · J. Bruce Fields

From: J. Bruce Fields <[email protected]>

These two tests insist that a server must accept commits with offset 2^64-1 and 2^64-2. I can find no justification in the spec for this requirement.

The linux server was recently changed to reject (with INVAL) offsets over 2^63-1, which is the maximum that the vfs commit routine can accept. That behavior is consistent with the NFSv3 commit implementation and with the NFSv4 write implementation.

Quoted 3 lines

I guess that I am missing something. At least the NFSv3 COMMIT operation takes an unsigned 64 bit quantity. That would seem to make the test correct, would it not?

The server will not allow you to write to an offset > 2^63-1 (it will return NFS3ERR_INVAL), so it makes zero sense for the client to try to issue a COMMIT for an offset starting in that range.

Cheers
Trond