ixgbe: Fix - Do not allow Rx FC on 82598 at 1G due to errata
Subsystems (2)
PATCH 1/2 ixgbe: Fix - Do not allow Rx FC on 82598 at 1G due to errata
From: Don Skidmore <[email protected]>
The 82598 has an erratum that receipt of pause frames at 1G could lead to a Tx Hang. To avoid this this patch disables Rx FC while at 1G speed for all 82598 parts.
---
drivers/net/ixgbe/ixgbe_82598.c | 22 ++++++++++++++++++++++ 1 files changed, 22 insertions(+), 0 deletions(-)
drivers/net/ixgbe/ixgbe_82598.c +22 -0
@@ -357,12 +357,34 @@ static s32 ixgbe_fc_enable_82598(struct ixgbe_hw *hw, s32 packetbuf_num)u32 fctrl_reg;u32 rmcs_reg;u32 reg; +u32 link_speed =0 ; +bool link_up;#ifdef CONFIG_DCB if (hw->fc.requested_mode == ixgbe_fc_pfc) goto out;#endif /* CONFIG_DCB */ +/* +* On 82598 having Rx FC on causes resets while doing 1G +* so if it's on turn it off once we know link_speed. For +* more details see 82598 Specification update. +*/ + hw->mac.ops.check_link (hw, &link_speed, &link_up, false); +if (link_up && link_speed ==IXGBE_LINK_SPEED_1GB_FULL ) { +switch (hw->fc.requested_mode) { +case ixgbe_fc_full: + hw->fc.requested_mode = ixgbe_fc_tx_pause; +break ; +case ixgbe_fc_rx_pause: + hw->fc.requested_mode = ixgbe_fc_none; +break ; +default : +/* no change */ +break ; + } + } +/* Negotiate the fc mode to use */ ret_val =ixgbe_fc_autoneg (hw);if (ret_val)
PATCH 2/2 ixgbe: fix WOL register setup for 82599
From: Don Skidmore <[email protected]>
We need to have the WUS register set to all 1's in order for the hardware to be capable of ever waking up. Set it here in the ixgbe_probe().
---
drivers/net/ixgbe/ixgbe_main.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
drivers/net/ixgbe/ixgbe_main.c +4 -0
@@ -5763,6 +5763,10 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev,if (err) goto err_sw_init; +/* Make it possible the adapter to be woken up via WOL */ +if (adapter->hw.mac.type == ixgbe_mac_82599EB) +IXGBE_WRITE_REG (&adapter->hw,IXGBE_WUS , ~0 ); +/* * If there is a fan on this device and it has failed log the * failure.
Re: [net-2.6 PATCH 2/2] ixgbe: fix WOL register setup for 82599
From: Jeff Kirsher <[email protected]>
Date: Thu, 11 Feb 2010 06:14:08 -0800
Quoted 7 lines
From: Don Skidmore <[email protected]>
We need to have the WUS register set to all 1's in order for the hardware to be capable of ever waking up. Set it here in the
ixgbe_probe().Signed-off-by Don Skidmore <[email protected]>Signed-off-by Jeff Kirsher <[email protected]>
Applied.
From: Jeff Kirsher <[email protected]>
Date: Thu, 11 Feb 2010 06:13:49 -0800
Quoted 8 lines
From: Don Skidmore <[email protected]>
The 82598 has an erratum that receipt of pause frames at 1G could lead to a Tx Hang. To avoid this this patch disables Rx FC while at 1G speed for all 82598 parts.
Signed-off-by Don Skidmore <[email protected]>Signed-off-by Jeff Kirsher <[email protected]>
Applied.