perf annotate SEGVs
A message that is not in the archive (sent off-list or not yet received): 20100212052427.GK3399@kryten
Hi,
I think I understand a problem in perf annotate where I see random corruption (rb tree issues, glibc malloc failures etc).
The issue happens with zero length symbols, in this particular case they are kernel functions written entirely in assembly, eg .copy_4K_page, .__copy_tofrom_user and .memcpy:
Num: Value Size Type Bind Vis Ndx Name 63516: c00000000004a774 212 FUNC GLOBAL DEFAULT 1 .devm_ioremap_prot 69095: c00000000004a848 0 FUNC GLOBAL DEFAULT 1 .copy_4K_page 62002: c00000000004aa00 0 FUNC GLOBAL DEFAULT 1 .__copy_tofrom_user 50576: c00000000004b000 0 FUNC GLOBAL DEFAULT 1 .memcpy 69557: c00000000004b278 176 FUNC GLOBAL DEFAULT 1 .copy_in_user 51841: c00000000004b328 144 FUNC GLOBAL DEFAULT 1 .copy_to_user
In symbol_filter we look at the length of each symbol:
static int symbol_filter(struct map *map __used, struct symb
...
const int size = (sizeof(*priv->hist) +
(sym->end - sym->start) * sizeof(u64));And since start == end we create 0 bytes of space for the ip[] array.
Later on in hist_hit we then start indexing off this array:
h->ip[offset]++;
Which then corrupts whatever is next in memory. With large assembly functions we corrupt a lot :)
How should we fix this? Do we need to do a first pass through our symbols to fixup ->end before allocating the ->ip[] arrays?
Anton
Em Fri, Feb 12, 2010 at 07:17:24PM +1100, Anton Blanchard escreveu:
Quoted 26 lines
I think I understand a problem in perf annotate where I see random corruption (rb tree issues, glibc malloc failures etc).
The issue happens with zero length symbols, in this particular case they are kernel functions written entirely in assembly, eg .copy_4K_page, .__copy_tofrom_user and .memcpy:
Num: Value Size Type Bind Vis Ndx Name 63516: c00000000004a774 212 FUNC GLOBAL DEFAULT 1 .devm_ioremap_prot 69095: c00000000004a848 0 FUNC GLOBAL DEFAULT 1 .copy_4K_page 62002: c00000000004aa00 0 FUNC GLOBAL DEFAULT 1 .__copy_tofrom_user 50576: c00000000004b000 0 FUNC GLOBAL DEFAULT 1 .memcpy 69557: c00000000004b278 176 FUNC GLOBAL DEFAULT 1 .copy_in_user 51841: c00000000004b328 144 FUNC GLOBAL DEFAULT 1 .copy_to_userIn
symbol_filterwe look at the length of each symbol:static int symbol_filter(struct map *map
__used, struct symb
...const int size = (sizeof(*priv->hist) + (sym->end - sym->start) * sizeof(u64));And since start == end we create 0 bytes of space for the ip[] array.
Later on in
hist_hitwe then start indexing off this array:
Quoted 7 lines
h->ip[offset]++;Which then corrupts whatever is next in memory. With large assembly functions we corrupt a lot :)
How should we fix this? Do we need to do a first pass through our symbols to fixup ->end before allocating the ->ip[] arrays?
We have already symbols__fixup_end() for doing that:
/*
* For misannotated, zeroed, ASM function sizes.
*/
if (nr > 0) {
symbols__fixup_end(&self->symbols[map->type]);
if (kmap) {
/*
* We need to fixup this here too because we create new
* maps here, for things like vsyscall sections.
*/
__map_groups__fixup_end(kmap->kmaps, map->type);
}
}but, as you show, there are code paths that don't reach this part...
Investigating.
- Arnaldo