Add an Apple iMac9,1 DMI entry to reboot.c so the machine reboot's properly.
PATCH 1/1 Add an Apple iMac9,1 DMI entry to reboot.c so the machine reboot's properly.
On the iMac9,1 sudo /sbin/reboot results in
a black screen. Adding this DMI entry gets the
machine to reboot cleanly as it should.
--- arch/x86/kernel/reboot.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
arch/x86/kernel/reboot.c +8 -0
@@ -461,6 +461,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Macmini3,1"), }, }, + { /* Handle problems with rebooting on Apple iMac9,1 */ + .callback = set_pci_reboot, + .ident = "Apple iMac9,1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"), + }, + }, { } };
Signature · 1 line
1.6.5.GIT
Whats the status if this patch?
Quoted 29 lines
On the iMac9,1 sudo
/sbin/rebootresults in
a black screen. Adding this DMI entry gets the
machine to reboot cleanly as it should.Signed-off-by Justin P. Mattock<[email protected]>--- arch/x86/kernel/reboot.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)arch/x86/kernel/reboot.c +8
-0@@ -461,6 +461,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Macmini3,1"), }, }, + { /* Handle problems with rebooting on Apple iMac9,1 */ + .callback = set_pci_reboot, + .ident = "Apple iMac9,1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"), + }, + }, { } };
Quoted 24 lines · Justin P. Mattock
Whats the status if this patch?
Quoted 22 lines
On the iMac9,1 sudo
/sbin/rebootresults in a black screen. Adding this DMI entry gets the machine to reboot cleanly as it should.Signed-off-by Justin P. Mattock<[email protected]>---
arch/x86/kernel/reboot.c| 8 ++++++++1 files changed, 8 insertions(+), 0 deletions(-)arch/x86/kernel/reboot.c +3
-0@@ -461,6 +461,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Macmini3,1"), }, }, + { /* Handle problems with rebooting on Apple iMac9,1 */ + .callback = set_pci_reboot, + .ident = "Apple iMac9,1",
Quoted 9 lines
arch/x86/kernel/reboot.c static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { · line 473
Quoted 8 lines
arch/x86/kernel/reboot.c +5
-0+ .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"), + }, + }, { } };
so what do I have todo file a bugreport against this to get a response from you people?
Justin P. Mattock
Quoted 27 lines · On Friday 12 February 2010 11:15:06 Justin P. Mattock wrote:
Quoted 26 lines · Justin P. Mattock
Whats the status if this patch?
Quoted 24 lines
On the iMac9,1 sudo
/sbin/rebootresults in a black screen. Adding this DMI entry gets the machine to reboot cleanly as it should.Signed-off-by Justin P. Mattock<[email protected]>---
arch/x86/kernel/reboot.c| 8 ++++++++1 files changed, 8 insertions(+), 0 deletions(-)arch/x86/kernel/reboot.c +5
-0@@ -461,6 +461,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Macmini3,1"), }, }, + { /* Handle problems with rebooting on Apple iMac9,1 */ + .callback = set_pci_reboot, + .ident = "Apple iMac9,1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
Quoted 8 lines
Quoted 5 lines
arch/x86/kernel/reboot.c static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { · line 473
Quoted 5 lines
arch/x86/kernel/reboot.c +3
-0+ DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"), + }, + }, { } };so what do I have todo file a bugreport against this to get a response from you people?
Looking at Linus' git tree, it would seem that Ingo Molnar is the "entry point" for the patches in arch/x86/kernel/reboot.c. Maybe you should try CC- ing him?
Signature · 1 line
Mihai Donțu
Quoted 37 lines · Mihai Donțu
Quoted 27 lines · On Friday 12 February 2010 11:15:06 Justin P. Mattock wrote:
Quoted 26 lines · Justin P. Mattock
Whats the status if this patch?
Quoted 24 lines
On the iMac9,1 sudo
/sbin/rebootresults in a black screen. Adding this DMI entry gets the machine to reboot cleanly as it should.Signed-off-by Justin P. Mattock<[email protected]>---
arch/x86/kernel/reboot.c| 8 ++++++++1 files changed, 8 insertions(+), 0 deletions(-)arch/x86/kernel/reboot.c +5
-0@@ -461,6 +461,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Macmini3,1"), }, }, + { /* Handle problems with rebooting on Apple iMac9,1 */ + .callback = set_pci_reboot, + .ident = "Apple iMac9,1", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),Quoted 8 lines
Quoted 5 lines
arch/x86/kernel/reboot.c static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { · line 473
Quoted 5 lines
arch/x86/kernel/reboot.c +3
-0+ DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"), + }, + }, { } };so what do I have todo file a bugreport against this to get a response from you people?
Quoted 4 lines
Looking at Linus' git tree, it would seem that Ingo Molnar is the "entry point" for the patches in
arch/x86/kernel/reboot.c. Maybe you should try CC- ing him?
Thank you.. I'm not familiar with whom to send to. (even though I've been developing to lkml for a while I'm still a newbie).
In any case I will send to ingo(as you had mentioned) and see what he says
Justin P. Mattock
Quoted 24 lines · Justin P. Mattock
Whats the status if this patch?
Quoted 22 lines
On the iMac9,1 sudo
/sbin/rebootresults in a black screen. Adding this DMI entry gets the machine to reboot cleanly as it should.Signed-off-by Justin P. Mattock<[email protected]>---
arch/x86/kernel/reboot.c| 8 ++++++++1 files changed, 8 insertions(+), 0 deletions(-)arch/x86/kernel/reboot.c +3
-0@@ -461,6 +461,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Macmini3,1"), }, }, + { /* Handle problems with rebooting on Apple iMac9,1 */ + .callback = set_pci_reboot, + .ident = "Apple iMac9,1",
Quoted 9 lines
arch/x86/kernel/reboot.c static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { · line 473
Quoted 8 lines
arch/x86/kernel/reboot.c +5
-0+ .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "iMac9,1"), + }, + }, { } };
Hello Ingo.. this fixes a reboot issue
with the apple iMac9,1 machines.
Justin P. Mattock