tracing/kprobes: make Kconfig dependencies generic
PATCH 1/2 tracing/kprobes: make Kconfig dependencies generic
From: Heiko Carstens <[email protected]>
KPROBES_EVENT actually depends on the regs and stack access API (b1cf540f) and not on x86.
So introduce a new config option which architectures can select if they have the API implemented and switch x86.
--- arch/Kconfig | 3 +++ arch/x86/Kconfig | 1 + kernel/trace/Kconfig | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-)
arch/Kconfig +3 -0
@@ -121,6 +121,9 @@ config HAVE_DMA_ATTRS config USE_GENERIC_SMP_HELPERS bool +config HAVE_REGS_AND_STACK_ACCESS_API + bool + config HAVE_CLK bool help
arch/x86/Kconfig +1 -0
@@ -45,6 +45,7 @@ config X86 select HAVE_GENERIC_DMA_COHERENT if X86_32 select HAVE_EFFICIENT_UNALIGNED_ACCESS select USER_STACKTRACE_SUPPORT + select HAVE_REGS_AND_STACK_ACCESS_API select HAVE_DMA_API_DEBUG select HAVE_KERNEL_GZIP select HAVE_KERNEL_BZIP2
kernel/trace/Kconfig +1 -1
@@ -449,7 +449,7 @@ config BLK_DEV_IO_TRACE config KPROBE_EVENT depends on KPROBES - depends on X86 + depends on HAVE_REGS_AND_STACK_ACCESS_API bool "Enable kprobes-based dynamic events" select TRACING default y
Quoted 6 lines · Heiko Carstens
From: Heiko Carstens <[email protected]>
KPROBES_EVENTactually depends on the regs and stack access API (b1cf540f) and not on x86.
So introduce a new config option which architectures can select if they have the API implemented and switch x86.
Looks good to me:) Thanks!
Quoted 46 lines
Signed-off-by Heiko Carstens <[email protected]>--- arch/Kconfig | 3 +++ arch/x86/Kconfig | 1 + kernel/trace/Kconfig | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-)arch/Kconfig +3
-0@@ -121,6 +121,9 @@ config HAVE_DMA_ATTRS config USE_GENERIC_SMP_HELPERS bool +config HAVE_REGS_AND_STACK_ACCESS_API + bool + config HAVE_CLK bool helparch/x86/Kconfig +1
-0@@ -45,6 +45,7 @@ config X86 select HAVE_GENERIC_DMA_COHERENT if X86_32 select HAVE_EFFICIENT_UNALIGNED_ACCESS select USER_STACKTRACE_SUPPORT + select HAVE_REGS_AND_STACK_ACCESS_API select HAVE_DMA_API_DEBUG select HAVE_KERNEL_GZIP select HAVE_KERNEL_BZIP2kernel/trace/Kconfig +1
-2@@ -449,7 +449,7 @@ config BLK_DEV_IO_TRACE config KPROBE_EVENT depends on KPROBES - depends on X86 + depends on HAVE_REGS_AND_STACK_ACCESS_API bool "Enable kprobes-based dynamic events" select TRACING default y --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 7 lines
Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: [email protected]
Frederic Weisbecker
AppliedQuoted 11 lines · Masami Hiramatsu
Quoted 6 lines · Heiko Carstens
From: Heiko Carstens <[email protected]>
KPROBES_EVENTactually depends on the regs and stack access API (b1cf540f) and not on x86.
So introduce a new config option which architectures can select if they have the API implemented and switch x86.Looks good to me:) Thanks!
Acked-by Masami Hiramatsu <[email protected]>
Queued both, thanks!
[tip:tracing/core] tracing/kprobes: Make Kconfig dependencies generic
In reply to Heiko CarstensCommit-ID: f850c30c8b426ba1688cb63b1a3e534eed03a138 Gitweb: http://git.kernel.org/tip/f850c30c8b426ba1688cb63b1a3e534eed03a138 Author: Heiko Carstens <[email protected]> AuthorDate: Wed, 10 Feb 2010 17:25:17 +0100 Committer: Frederic Weisbecker <[email protected]> CommitDate: Wed, 17 Feb 2010 13:13:08 +0100
tracing/kprobes: Make Kconfig dependencies generic
KPROBES_EVENT actually depends on the regs and stack access API (b1cf540f) and not on x86.
So introduce a new config option which architectures can select if they have the API implemented and switch x86.
LKML-Reference: <[email protected]>
--- arch/Kconfig | 3 +++ arch/x86/Kconfig | 1 + kernel/trace/Kconfig | 2 +- 3 files changed, 5 insertions(+), 1 deletions(-)
arch/Kconfig +3 -0
@@ -121,6 +121,9 @@ config HAVE_DMA_ATTRS config USE_GENERIC_SMP_HELPERS bool +config HAVE_REGS_AND_STACK_ACCESS_API + bool + config HAVE_CLK bool help
arch/x86/Kconfig +1 -0
@@ -45,6 +45,7 @@ config X86 select HAVE_GENERIC_DMA_COHERENT if X86_32 select HAVE_EFFICIENT_UNALIGNED_ACCESS select USER_STACKTRACE_SUPPORT + select HAVE_REGS_AND_STACK_ACCESS_API select HAVE_DMA_API_DEBUG select HAVE_KERNEL_GZIP select HAVE_KERNEL_BZIP2
kernel/trace/Kconfig +1 -1
@@ -451,7 +451,7 @@ config BLK_DEV_IO_TRACE config KPROBE_EVENT depends on KPROBES - depends on X86 + depends on HAVE_REGS_AND_STACK_ACCESS_API bool "Enable kprobes-based dynamic events" select TRACING default y