imx-serial-excessive-status-clearing-on-break.patch
PATCH 1/1 imx-serial-excessive-status-clearing-on-break.patch
From: Andy Green <[email protected]>
We noticed that we were only able to communicate once with a GSM module per session, if we powered down the module then the serial driver was broken until reset, no traffic or /proc/interrupts activity could be seen any more.
Volker noticed it was provoked by a long "break" seen on the wire when the RX was not driven during powerdown, we discovered we could kill the serial driver just by forcing RX low extenally for a little while.
I saw that the processing for BREAK in the driver gets too excited and clears down all set bits in USR2, including that a character is pending. This stops all further characters getting processed.
The attached one-liner makes the serial driver immortal against BREAK.
---
drivers/serial/imx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/imx.c +1 -1
@@ -440,7 +440,7 @@ static irqreturn_t imx_rxint(int irq, void *dev_id) temp =readl (sport->port.membase +USR2 );if (temp &USR2_BRCD ) { -writel (temp |USR2_BRCD , sport->port.membase +USR2 ); +writel (USR2_BRCD , sport->port.membase +USR2 );if (uart_handle_break (&sport->port))continue ; }
PATCH 1/1 imx-serial-excessive-status-clearing-on-break.patch
drivers/serial/imx.c static irqreturn_t imx_rxint(int irq, void *dev_id) · line 443
Quoted 2 lines · Somebody in the thread at some point
drivers/serial/imx.c +1
-1-writel (temp |USR2_BRCD , sport->port.membase +USR2 ); +writel (USR2_BRCD , sport->port.membase +USR2 );
Hi Sascha -
What is the disposition of this patch? It solves a real problem in the imx serial but it is just sitting there for two weeks.
-Andy
Sascha Hauer
maintainerPATCH 1/1 imx-serial-excessive-status-clearing-on-break.patch
Hi Andy,
Quoted 9 lines · Andy Green
drivers/serial/imx.c static irqreturn_t imx_rxint(int irq, void *dev_id) · line 443
Quoted 2 lines · Somebody in the thread at some point
drivers/serial/imx.c +1
-1-writel (temp |USR2_BRCD , sport->port.membase +USR2 ); +writel (USR2_BRCD , sport->port.membase +USR2 );Hi Sascha -
What is the disposition of this patch? It solves a real problem in the imx serial but it is just sitting there for two weeks.
Sorry, I missed it. Applied now.
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |