Skip to contentSkip to conversation

Key for tablet rotation?

DISCUSSION Matthew Garrett 3 participants 5 messages Feb 16, 2010 – Feb 23, 2010 HID

lore
Share & tools
lore
#0 lore raw

Many tablet PCs have a button to indicate that the screen should be rotated from landscape to portrait mode. There's currently no standardisation here - a couple of drivers seem to be using KEY_DIRECTION, and others are just being mapped to arbitrary F keys. So:

1) What is KEY_DIRECTION supposed to be for?
2) If it's not suitable, do we still have space for a KEY_ROTATE?

Signature · 1 line
Matthew Garrett | [email protected]
#1 lore raw
Quoted 6 lines · Matthew Garrett

Many tablet PCs have a button to indicate that the screen should be rotated from landscape to portrait mode. There's currently no standardisation here - a couple of drivers seem to be using KEY_DIRECTION, and others are just being mapped to arbitrary F keys. So:

1) What is KEY_DIRECTION supposed to be for?

Hmm, that is the good question. It looks like it's been introduced with the first patch for input events that Vojtech brought in 2.3 kernels and I do not see any users for it in mainline.

Vojtech, do you remember by any chance what you intended it to be used for?

Quoted 2 lines

2) If it's not suitable, do we still have space for a KEY_ROTATE?

We still have a few slots available but I'd lean towards KEY_DIRECTION (with better name maybe).

Signature · 1 line
Dmitry
#2 lore raw

Now if I only did not forget to CC Vojtech first time around...

Quoted 23 lines · Dmitry Torokhov
Quoted 6 lines · Matthew Garrett

Many tablet PCs have a button to indicate that the screen should be rotated from landscape to portrait mode. There's currently no standardisation here - a couple of drivers seem to be using KEY_DIRECTION, and others are just being mapped to arbitrary F keys. So:

1) What is KEY_DIRECTION supposed to be for?

Hmm, that is the good question. It looks like it's been introduced with the first patch for input events that Vojtech brought in 2.3 kernels and I do not see any users for it in mainline.

Vojtech, do you remember by any chance what you intended it to be used for?

Quoted 2 lines

2) If it's not suitable, do we still have space for a KEY_ROTATE?

We still have a few slots available but I'd lean towards KEY_DIRECTION (with better name maybe).

Signature · 1 line
Dmitry
Signature · 1 line
Dmitry
#3 lore raw
Quoted 23 lines · Dmitry Torokhov

Now if I only did not forget to CC Vojtech first time around...

Quoted 20 lines · Dmitry Torokhov
Quoted 6 lines · Matthew Garrett

Many tablet PCs have a button to indicate that the screen should be rotated from landscape to portrait mode. There's currently no standardisation here - a couple of drivers seem to be using KEY_DIRECTION, and others are just being mapped to arbitrary F keys. So:

1) What is KEY_DIRECTION supposed to be for?

Hmm, that is the good question. It looks like it's been introduced with the first patch for input events that Vojtech brought in 2.3 kernels and I do not see any users for it in mainline.

Vojtech, do you remember by any chance what you intended it to be used for?

Quoted 2 lines

2) If it's not suitable, do we still have space for a KEY_ROTATE?

We still have a few slots available but I'd lean towards KEY_DIRECTION (with better name maybe).

This is way too long ago, sorry. I suppose it was a key on one of the early extended AT keyboards, not really related to tablet computing. Now, if it's not used anywhere, it makes good sense to reuse it.

Signature · 2 lines
Vojtech Pavlik
Director SuSE Labs
#4 lore raw
Quoted 19 lines · Vojtech Pavlik
Quoted 18 lines · Dmitry Torokhov

Now if I only did not forget to CC Vojtech first time around...

Quoted 15 lines · Dmitry Torokhov
Quoted 6 lines · Matthew Garrett

Many tablet PCs have a button to indicate that the screen should be rotated from landscape to portrait mode. There's currently no standardisation here - a couple of drivers seem to be using KEY_DIRECTION, and others are just being mapped to arbitrary F keys. So:

1) What is KEY_DIRECTION supposed to be for?

Hmm, that is the good question. It looks like it's been introduced with the first patch for input events that Vojtech brought in 2.3 kernels and I do not see any users for it in mainline.

Vojtech, do you remember by any chance what you intended it to be used for?

Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

2) If it's not suitable, do we still have space for a KEY_ROTATE?

We still have a few slots available but I'd lean towards KEY_DIRECTION (with better name maybe).

This is way too long ago, sorry. I suppose it was a key on one of the early extended AT keyboards, not really related to tablet computing.

Indeed, it was the case - it got in together with KEY_CYCLEWINDOWS, KEY_MSDOS, KEY_WWW, and the (in)famous KEY_COFFEE.

Quoted 1 line

Now, if it's not used anywhere, it makes good sense to reuse it.

Signature · 2 lines
Vojtech Pavlik
Director SuSE Labs