be2net: a mini optimization in rx_compl_process() code
Subsystems (2)
PATCH 1/4 be2net: a mini optimization in rx_compl_process() code
Introduce unlikely() for skb alloc failure and vlanf checks...
Signed-off-by Sathya Perla <[email protected]>
--- drivers/net/benet/be_main.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-)
drivers/net/benet/be_main.c +10 -10
@@ -768,16 +768,8 @@ static void be_rx_compl_process(struct be_adapter *adapter,u32 vlanf, vid;u8 vtm; - vlanf = AMAP_GET_BITS(struct amap_eth_rx_compl, vtp, rxcp); - vtm = AMAP_GET_BITS(struct amap_eth_rx_compl, vtm, rxcp); - -/* vlanf could be wrongly set in some cards. -* ignore if vtm is not set */ -if ((adapter->cap &0x400 ) && !vtm) - vlanf =0 ; - skb =netdev_alloc_skb_ip_align (adapter->netdev,BE_HDR_LEN ); -if (!skb) { +if (unlikely (!skb)) {if (net_ratelimit ())dev_warn (&adapter->pdev->dev,"skb alloc failed\n" );be_rx_compl_discard (adapter, rxcp);
@@ -795,7 +787,15 @@ static void be_rx_compl_process(struct be_adapter *adapter, skb->protocol =eth_type_trans (skb, adapter->netdev); skb->dev = adapter->netdev; -if (vlanf) { + vlanf = AMAP_GET_BITS(struct amap_eth_rx_compl, vtp, rxcp); + vtm = AMAP_GET_BITS(struct amap_eth_rx_compl, vtm, rxcp); + +/* vlanf could be wrongly set in some cards. +* ignore if vtm is not set */ +if ((adapter->cap &0x400 ) && !vtm) + vlanf =0 ; + +if (unlikely (vlanf)) {if (!adapter->vlan_grp || adapter->vlans_added ==0 ) {kfree_skb (skb);return ;
Signature · 1 line
1.6.3.3
From: Sathya Perla <[email protected]>
Date: Wed, 17 Feb 2010 17:04:22 +0530
Quoted 3 lines
Introduce
unlikely()for skb alloc failure and vlanf checks...Signed-off-by Sathya Perla <[email protected]>
Applied.