Skip to contentSkip to conversation

VFS: clarify that nonseekable_open() will never fail

PATCH New Dmitry Torokhov 1 participant 1 message Feb 17, 2010 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 VFS: clarify that nonseekable_open() will never fail

Al, Andrew,

Could you please pick this one up (unless you disagree with it)?

Thanks!

Signature · 11 lines
Dmitry

VFS: clarify that nonseekable_open() will never fail

Acked-by: Arnd Bergmann <[email protected]>
Acked-by: John Kacur <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
---

 fs/open.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
fs/open.c +3 -1
index 040cef7..02ceb73 100644
@@ -1200,7 +1200,9 @@ EXPORT_SYMBOL(generic_file_open);
 
 /*
  * This is used by subsystems that don't want seekable
- * file descriptors
+ * file descriptors. The function is not supposed to ever fail, the only
+ * reason it returns an 'int' and not 'void' is so that it can be plugged
+ * directly into file_operations structure.
  */
 int nonseekable_open(struct inode *inode, struct file *filp)
 {