Skip to contentSkip to conversation

btrfs, a new tool to manage a btrfs filesystem; source code

PATCH In review Goffredo Baroncelli 2 participants 2 messages Feb 17, 2010 – Feb 18, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 btrfs, a new tool to manage a btrfs filesystem; source code

This is the source code of btrfs.c.
The main changes from my previous patch are:
- Rearranged the short command in order to avoid conflicts
- Renamed the 'create' verb is 'subvolume'
- Rearranged the parsing code, which now is integrated in the help in order to avoid mismatch

BR
G.Baroncelli

Makefile +4 -1
index 02f881e..888ef8d 100644
@@ -17,7 +17,7 @@ bindir = $(prefix)/bin
 LIBS=-luuid
 
 progs = btrfsctl mkfs.btrfs btrfs-debug-tree btrfs-show btrfs-vol btrfsck \
-	btrfs-map-logical
+	btrfs-map-logical btrfs
 
 # make C=1 to enable sparse
 ifdef C
@@ -36,6 +36,9 @@ all: version $(progs) manpages
 version:
 	bash version.sh
 
+btrfs: $(objects) btrfs.o
+	gcc $(CFLAGS) -o btrfs btrfs.o $(objects) $(LDFLAGS) $(LIBS)
+
 btrfsctl: $(objects) btrfsctl.o
 	gcc $(CFLAGS) -o btrfsctl btrfsctl.o $(objects) $(LDFLAGS) $(LIBS)
 
btrfs.c new file +775 -0

775 lines not on this page · raw message

Signature · 2 lines
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijackATinwind.it>
Key fingerprint = 4769 7E51 5293 D36C 814E  C054 BF04 F161 3DC5 0512
#1 lore raw

Hi,
It's a cool utility with tidy source code.
At my first glance, there's typo, a question and an impression.

- There's no "<source>" in usage of utility.
- will occupe -> will occupy
(usage of utility : "btrfs resize")
- Is specifying a target device of resizing isn't public even in your utility?
- I felt somehow confusing with the short commands. It's not easy to associate it from its command.

Regards,
taruisi

Quoted 9 lines · Goffredo Baroncelli

This is the source code of btrfs.c.
The main changes from my previous patch are:
- Rearranged the short command in order to avoid conflicts
- Renamed the 'create' verb is 'subvolume'
- Rearranged the parsing code, which now is integrated in the help in order to avoid mismatch

BR
G.Baroncelli

- snip -