Skip to contentSkip to conversation

qemu-kvm Set kvm_features name for kvm_cr3_cache

PATCH In review Jes Sorensen 2 participants 4 messages Feb 17, 2010 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu-kvm Set kvm_features name for kvm_cr3_cache

Hi,

Comparing the features tested for in get_para_features() with the kvm_feature_names in target-i386/helper.c, I noticed that we didn't list the cr3_cache feature in the real name table.

I presume this is unintentional so here's a patch to correct it.

Cheers,
Jes

commit 39cb576d15a6ffbbcade3c4f282c2f3e76e3098a

Author: Jes Sorensen <[email protected]>
Date:   Wed Feb 17 18:03:37 2010 +0100

Add kvm_cr3_cache to the list of KVM features.

This is to match the features automatically added by target-i386/kvm.c:get_para_features()

target-i386/helper.c +2 -1
index f9d63f6..2cd3dca 100644
@@ -61,7 +61,8 @@ static const char *ext3_feature_name[] = {
 };
 
 static const char *kvm_feature_name[] = {
-    "kvmclock", "kvm_nopiodelay", "kvm_mmu", NULL, NULL, NULL, NULL, NULL,
+    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvm_cr3_cache",
+    NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
#1 lore raw
Quoted 11 lines · Jes Sorensen

Hi,

Comparing the features tested for in get_para_features() with the kvm_feature_names in target-i386/helper.c, I noticed that we didn't list the cr3_cache feature in the real name table.

I presume this is unintentional so here's a patch to correct it.

Cheers,
Jes

The KVM_CAP_CR3_CACHE reference can be removed since the feature was never implemented/included.

#2 lore raw
Quoted 2 lines · Marcelo Tosatti

The KVM_CAP_CR3_CACHE reference can be removed since the feature was never implemented/included.

Ok that works too, would you rather a patch to remove all references to it, or leave it in in case someone decides to pick it up later?

Cheers,
Jes

#3 lore raw
Quoted 6 lines · Jes Sorensen
Quoted 2 lines · Marcelo Tosatti

The KVM_CAP_CR3_CACHE reference can be removed since the feature was never implemented/included.

Ok that works too, would you rather a patch to remove all references to it, or leave it in in case someone decides to pick it up later?

I'd say remove all references, its obsolete due to EPT/NPT.

Quoted 4 lines

Cheers,
Jes