arm: Allow mounting root on omaps with CPU_V6 and CPU_V7
PATCH 1/1 arm: Allow mounting root on omaps with CPU_V6 and CPU_V7
Hi all,
Here's one more patch for booting CPU_V6 and CPU_V7 omaps with the same kernel binary. This is needed to boot to user space, earlier I was just checking for "Mounted root".
Now I'm wondering if some of these should be done as
default y if CPU_V7 && !CPU_32v6K
or
default y if CPU_V7 && !CPU_V6
instead to make them more generic? This is, after the earlier patch selecting CPU_32v6K if !ARCH_OMAP2.
Regards,
Tony
From: Tony Lindgren <[email protected]>
Date: Thu, 18 Feb 2010 13:22:58 -0800
Subject: [PATCH] arm: Allow mounting root on omaps with CPU_V6 and CPU_V7
To mount root, we need to disable VFPv3, HAS_TLS_REG, and set ARM_L1_CACHE_SHIFT=5.
Otherwise we'll get something like this for CPUv3:
Freeing init memory: 184K
Internal error: Oops - undefined instruction: 0 [#1] last sysfs file: Modules linked in: CPU: 0 Not tainted (2.6.33-rc8-07824-gf2e1d91-dirty #36) PC is at no_old_VFP_process+0x8/0x3c LR is at __und_usr_unknown+0x0/0x14
...
Or the system just hangs if HAS_TLS_REG is set.
The ARM_L1_CACHE_SHIFT most likely will cause issues too if not set to 5.
arch/arm/Kconfig +1 -1
@@ -1498,7 +1498,7 @@ config VFP config VFPv3 bool depends on VFP - default y if CPU_V7 + default y if CPU_V7 && !ARCH_OMAP2 config NEON bool "Advanced SIMD (NEON) Extension support"
arch/arm/mm/Kconfig +2 -2
@@ -718,7 +718,7 @@ config TLS_REG_EMUL config HAS_TLS_REG bool depends on !TLS_REG_EMUL - default y if SMP || CPU_32v7 + default y if (SMP || CPU_32v7) && !ARCH_OMAP2 help This selects support for the CP15 thread register. It is defined to be available on some ARMv6 processors (including
@@ -779,5 +779,5 @@ config CACHE_XSC3L2 config ARM_L1_CACHE_SHIFT int - default 6 if ARCH_OMAP3 || ARCH_S5PC1XX + default 6 if (ARCH_OMAP3 || ARCH_S5PC1XX) && !ARCH_OMAP2 default 5
PATCH 1/1 arm: Allow mounting root on omaps with CPU_V6 and CPU_V7
arch/arm/mm/Kconfig config CACHE_XSC3L2 · line 783
Quoted 7 lines · Tony Lindgren
arch/arm/mm/Kconfig +1
-1@@ -779,5 +779,5 @@ config CACHE_XSC3L2 config ARM_L1_CACHE_SHIFT int - default 6 if ARCH_OMAP3 || ARCH_S5PC1XX + default 6 if (ARCH_OMAP3 || ARCH_S5PC1XX) && !ARCH_OMAP2 default 5
This one is definitely wrong. Setting the L1 cache line size larger than it actually is should be safe; setting it smaller is definitely unsafe.
PATCH 1/1 arm: Allow mounting root on omaps with CPU_V6 and CPU_V7
Quoted 12 lines · Russell King - ARM Linux
arch/arm/mm/Kconfig config CACHE_XSC3L2 · line 783
Quoted 7 lines · Tony Lindgren
arch/arm/mm/Kconfig +1
-1@@ -779,5 +779,5 @@ config CACHE_XSC3L2 config ARM_L1_CACHE_SHIFT int - default 6 if ARCH_OMAP3 || ARCH_S5PC1XX + default 6 if (ARCH_OMAP3 || ARCH_S5PC1XX) && !ARCH_OMAP2 default 5This one is definitely wrong. Setting the L1 cache line size larger than it actually is should be safe; setting it smaller is definitely unsafe.
OK dropped that part, updated patch below. Maybe the VFPv3 code can be fixed to boot on earlier hardware too.
So I guess ARM_L1_CACHE_SHIFT should be only used for alignment, and not for for cache operations?
If so, then what have in arch/arm/plat-omap/iommu.c seems buggy:
static void flush_iopgd_range(u32 *first, u32 *last)
{
/* FIXME: L2 cache should be taken care of if it exists */
do {
asm("mcr p15, 0, %0, c7, c10, 1 @ flush_pgd"
: : "r" (first));
first += L1_CACHE_BYTES / sizeof(*first);
} while (first <= last);
}It seems that this code should use the real cache line size instead to avoid every other line not to flush if ARM_L1_CACHE_SHIFT is set larger than it is.
Regards,
Tony
From: Tony Lindgren <[email protected]>
Date: Thu, 18 Feb 2010 16:28:26 -0800
Subject: [PATCH] arm: Allow mounting root on omaps with CPU_V6 and CPU_V7
To mount root, we need to disable VFPv3 and HAS_TLS_REG.
Otherwise we'll get something like this for CPUv3:
Freeing init memory: 184K
Internal error: Oops - undefined instruction: 0 [#1] last sysfs file: Modules linked in: CPU: 0 Not tainted (2.6.33-rc8-07824-gf2e1d91-dirty #36) PC is at no_old_VFP_process+0x8/0x3c LR is at __und_usr_unknown+0x0/0x14
...
Or the system just hangs if HAS_TLS_REG is set.
arch/arm/Kconfig +1 -1
@@ -1498,7 +1498,7 @@ config VFP config VFPv3 bool depends on VFP - default y if CPU_V7 + default y if CPU_V7 && !ARCH_OMAP2 config NEON bool "Advanced SIMD (NEON) Extension support"
arch/arm/mm/Kconfig +1 -1
@@ -718,7 +718,7 @@ config TLS_REG_EMUL config HAS_TLS_REG bool depends on !TLS_REG_EMUL - default y if SMP || CPU_32v7 + default y if (SMP || CPU_32v7) && !ARCH_OMAP2 help This selects support for the CP15 thread register. It is defined to be available on some ARMv6 processors (including
PATCH 1/1 arm: Allow mounting root on omaps with CPU_V6 and CPU_V7
Quoted 12 lines · Tony Lindgren
If so, then what have in
arch/arm/plat-omap/iommu.cseems buggy:static void
flush_iopgd_range(u32 *first, u32 *last){ /* FIXME: L2 cache should be taken care of if it exists */ do { asm("mcr p15, 0, %0, c7, c10, 1 @ flush_pgd" : : "r" (first)); first += L1_CACHE_BYTES / sizeof(*first); } while (first <= last); }
Quoted 3 lines
It seems that this code should use the real cache line size instead to avoid every other line not to flush if
ARM_L1_CACHE_SHIFTis set larger than it is.
Yes.