Skip to contentSkip to conversation

ixgbe: prevent speculative processing of descriptors before ready

PATCH Applied Jeff Kirsher 2 participants 2 messages Feb 20, 2010 – Feb 22, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: prevent speculative processing of descriptors before ready

From: Milton Miller <[email protected]>

The PowerPC architecture does not require loads to independent bytes to be ordered without adding an explicit barrier.

In ixgbe_clean_rx_irq we load the status bit then load the packet data. With packet split disabled if these loads go out of order we get a stale packet, but we will notice the bad sequence numbers and drop it.

The problem occurs with packet split enabled where the TCP/IP header and data are in different descriptors. If the reads go out of order we may have data that doesn't match the TCP/IP header. Since we use hardware checksumming this bad data is never verified and it makes it all the way to the application.

This bug was found during stress testing and adding this barrier has been shown to fix it.

---

 drivers/net/ixgbe/ixgbe_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ixgbe/ixgbe_main.c +1 -0
index 43a8de3..3308790 100644
@@ -849,6 +849,7 @@ static bool ixgbe_clean_rx_irq(struct ixgbe_q_vector *q_vector,
 			break;
 		(*work_done)++;
 
+		rmb(); /* read descriptor and rx_buffer_info after status DD */
 		if (rx_ring->flags & IXGBE_RING_RX_PS_ENABLED) {
 			hdr_info = le16_to_cpu(ixgbe_get_hdr_info(rx_desc));
 			len = (hdr_info & IXGBE_RXDADV_HDRBUFLEN_MASK) >>
maintainer Applied
#1 lore raw

From: Jeff Kirsher <[email protected]>
Date: Fri, 19 Feb 2010 19:44:42 -0800

Quoted 14 lines

From: Milton Miller <[email protected]>

The PowerPC architecture does not require loads to independent bytes to be ordered without adding an explicit barrier.

In ixgbe_clean_rx_irq we load the status bit then load the packet data. With packet split disabled if these loads go out of order we get a stale packet, but we will notice the bad sequence numbers and drop it.

The problem occurs with packet split enabled where the TCP/IP header and data are in different descriptors. If the reads go out of order we may have data that doesn't match the TCP/IP header. Since we use hardware checksumming this bad data is never verified and it makes it all the way to the application.

Quoted 7 lines

This bug was found during stress testing and adding this barrier has been shown to fix it.

Applied.