Transparent Hugepage support #11
Subsystems (28)
cover Transparent Hugepage support #11
This is a port of the latest version of transparent hugepage togit://zen-kernel.org/kernel/mmotm.git
The relevant changes are the addition of the page_anon_vma patch, the patch to adapt the rss accounting to -mm, and a one liner fix in the clear_copy_huge_page cleanup patch (that was crashing hugetlbfs).
http://www.kernel.org/pub/linux/kernel/people/andrea/patches/v2.6/2.6.33-rc7-mm1+/transparent_hugepage-11/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 1/36 define MADV_HUGEPAGE
From: Andrea Arcangeli <[email protected]>
Define MADV_HUGEPAGE.
---
arch/alpha/include/asm/mman.h +2 -0
@@ -53,6 +53,8 @@#define MADV_MERGEABLE 12/* KSM may merge identical pages */ #define MADV_UNMERGEABLE 13/* KSM may not merge identical pages */ +#define MADV_HUGEPAGE 14/* Worth backing with hugepages */ +/* compatibility flags */ #define MAP_FILE 0
arch/mips/include/asm/mman.h +2 -0
@@ -77,6 +77,8 @@#define MADV_UNMERGEABLE 13/* KSM may not merge identical pages */ #define MADV_HWPOISON 100/* poison a page for testing */ +#define MADV_HUGEPAGE 14/* Worth backing with hugepages */ +/* compatibility flags */ #define MAP_FILE 0
arch/parisc/include/asm/mman.h +2 -0
@@ -59,6 +59,8 @@#define MADV_MERGEABLE 65/* KSM may merge identical pages */ #define MADV_UNMERGEABLE 66/* KSM may not merge identical pages */ +#define MADV_HUGEPAGE 67/* Worth backing with hugepages */ +/* compatibility flags */ #define MAP_FILE 0#define MAP_VARIABLE 0
arch/xtensa/include/asm/mman.h +2 -0
@@ -83,6 +83,8 @@#define MADV_MERGEABLE 12/* KSM may merge identical pages */ #define MADV_UNMERGEABLE 13/* KSM may not merge identical pages */ +#define MADV_HUGEPAGE 14/* Worth backing with hugepages */ +/* compatibility flags */ #define MAP_FILE 0
include/asm-generic/mman-common.h +1 -1
@@ -45,7 +45,7 @@#define MADV_MERGEABLE 12/* KSM may merge identical pages */ #define MADV_UNMERGEABLE 13/* KSM may not merge identical pages */ -#define MADV_HUGEPAGE 15/* Worth backing with hugepages */ +#define MADV_HUGEPAGE 14/* Worth backing with hugepages */ /* compatibility flags */ #define MAP_FILE 0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 2/36 compound_lock
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Add a new compound_lock() needed to serialize put_page against __split_huge_page_refcount().
---
include/linux/mm.h +15 -0
@@ -12,6 +12,7 @@#include <linux/prio_tree.h> #include <linux/debug_locks.h> #include <linux/mm_types.h> +#include <linux/bit_spinlock.h> struct mempolicy ;struct anon_vma ;
@@ -294,6 +295,20 @@ static inline int is_vmalloc_or_module_a }#endif +static inline void compound_lock (struct page *page) +{ +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +bit_spin_lock (PG_compound_lock, &page->flags); +#endif +} + +static inline void compound_unlock (struct page *page) +{ +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +bit_spin_unlock (PG_compound_lock, &page->flags); +#endif +} +static inline struct page *compound_head (struct page *page) {if (unlikely (PageTail (page)))
include/linux/page-flags.h +11 -1
@@ -108,6 +108,9 @@ enum pageflags {#ifdef CONFIG_MEMORY_FAILURE PG_hwpoison, /* hardware poisoned page. Don't touch */#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + PG_compound_lock, +#endif __NR_PAGEFLAGS,/* Filesystems */
@@ -399,6 +402,12 @@ static inline void __ClearPageTail(struc#define __PG_MLOCKED 0#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define __PG_COMPOUND_LOCK (1 << PG_compound_lock) +#else +#define __PG_COMPOUND_LOCK 0 +#endif +/* * Flags checked when a page is freed. Pages being freed should not have * these flags set. It they are, there is a problem.
@@ -408,7 +417,8 @@ static inline void __ClearPageTail(struc1 << PG_private |1 << PG_private_2 | \1 << PG_buddy |1 << PG_writeback |1 << PG_reserved | \1 << PG_slab |1 << PG_swapcache |1 << PG_active | \ - 1 << PG_unevictable | __PG_MLOCKED | __PG_HWPOISON) +1 << PG_unevictable | __PG_MLOCKED | __PG_HWPOISON | \ + __PG_COMPOUND_LOCK)/* * Flags checked when a page is prepped for return by the page allocator.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 3/36 alter compound get_page/put_page
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Alter compound get_page/put_page to keep references on subpages too, in order to allow __split_huge_page_refcount to split an hugepage even while subpages have been pinned by one of the get_user_pages() variants.
---
arch/powerpc/mm/gup.c +12 -0
@@ -16,6 +16,16 @@#ifdef __HAVE_ARCH_PTE_SPECIAL +static inline void pin_huge_page_tail (struct page *page) +{ +/* +* __split_huge_page_refcount() cannot run +* from under us. +*/ +VM_BUG_ON (atomic_read (&page->_count) <0 ); +atomic_inc (&page->_count); +} +/* * The performance critical leaf functions are made noinline otherwise gcc * inlines everything into a single function which results in too much
@@ -47,6 +57,8 @@ static noinline int gup_pte_range(pmd_tput_page (page);return 0 ; } +if (PageTail (page)) +pin_huge_page_tail (page); pages[*nr] = page; (*nr)++;
arch/x86/mm/gup.c +12 -0
@@ -105,6 +105,16 @@ static inline void get_head_page_multiplatomic_add (nr, &page->_count); } +static inline void pin_huge_page_tail (struct page *page) +{ +/* +* __split_huge_page_refcount() cannot run +* from under us. +*/ +VM_BUG_ON (atomic_read (&page->_count) <0 ); +atomic_inc (&page->_count); +} + static noinline int gup_huge_pmd(pmd_t pmd, unsigned long addr,unsigned long end,int write,struct page **pages,int *nr) {
@@ -128,6 +138,8 @@ static noinline int gup_huge_pmd(pmd_t p do { VM_BUG_ON(compound_head(page) != head); pages[*nr] = page; + if (PageTail(page)) + pin_huge_page_tail(page); (*nr)++; page++; refs++;
include/linux/mm.h +10 -2
@@ -325,9 +325,17 @@ static inline int page_count(struct pagestatic inline void get_page (struct page *page) { - page =compound_head (page); -VM_BUG_ON (atomic_read (&page->_count) ==0 ); +VM_BUG_ON (atomic_read (&page->_count) < !PageTail (page));atomic_inc (&page->_count); +if (unlikely (PageTail (page))) { +/* +* This is safe only because +* __split_huge_page_refcount can't run under +* get_page(). +*/ +VM_BUG_ON (atomic_read (&page->first_page->_count) <=0 ); +atomic_inc (&page->first_page->_count); + } }static inline struct page *virt_to_head_page (const void *x)
mm/swap.c +72 -7
96 lines not on this page · raw message
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 4/36 update futex compound knowledge
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Futex code is smarter than most other gup_fast O_DIRECT code and knows about the compound internals. However now doing a put_page(head_page) will not release the pin on the tail page taken by gup-fast, leading to all sort of refcounting bugchecks. Getting a stable head_page is a little tricky.
page_head = page is there because if this is not a tail page it's also the page_head. Only in case this is a tail page, compound_head is called, otherwise it's guaranteed unnecessary. And if it's a tail page compound_head has to run atomically inside irq disabled section __get_user_pages_fast before returning. Otherwise ->first_page won't be a stable pointer.
Disableing irq before __get_user_page_fast and releasing irq after running compound_head is needed because if __get_user_page_fast returns == 1, it means the huge pmd is established and cannot go away from under us. pmdp_splitting_flush_notify in __split_huge_page_splitting will have to wait for local_irq_enable before the IPI delivery can return. This means __split_huge_page_refcount can't be running from under us, and in turn when we run compound_head(page) we're not reading a dangling pointer from tailpage->first_page. Then after we get to stable head page, we are always safe to call compound_lock and after taking the compound lock on head page we can finally re-check if the page returned by gup-fast is still a tail page. in which case we're set and we didn't need to split the hugepage in order to take a futex on it.
---
kernel/futex.c +58 -9
@@ -218,7 +218,7 @@ get_futex_key(u32 __user *uaddr, int fsh {unsigned long address = (unsigned long )uaddr;struct mm_struct *mm = current->mm; -struct page *page; +struct page *page, *page_head;int err;/*
@@ -250,10 +250,53 @@ again:if (err <0 )return err; - page =compound_head (page); -lock_page (page); -if (!page->mapping) { -unlock_page (page); +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + page_head = page; +if (unlikely (PageTail (page))) { +put_page (page); +/* serialize against __split_huge_page_splitting() */ +local_irq_disable (); +if (likely (__get_user_pages_fast (address,1 ,1 , &page) ==1 )) { + page_head =compound_head (page); +/* +* page_head is valid pointer but we must pin +* it before taking the PG_lock and/or +* PG_compound_lock. The moment we re-enable +* irqs __split_huge_page_splitting() can +* return and the head page can be freed from +* under us. We can't take the PG_lock and/or +* PG_compound_lock on a page that could be +* freed from under us. +*/ +if (page != page_head) +get_page (page_head); +local_irq_enable (); + }else { +local_irq_enable (); + goto again; + } + } +#else + page_head =compound_head (page); +if (page != page_head) +get_page (page_head); +#endif + +lock_page (page_head); +if (unlikely (page_head != page)) { +compound_lock (page_head); +if (unlikely (!PageTail (page))) { +compound_unlock (page_head); +unlock_page (page_head); +put_page (page_head); +put_page (page); + goto again; + } + } +if (!page_head->mapping) { +unlock_page (page_head); +if (page_head != page) +put_page (page_head);put_page (page); goto again; }
@@ -265,19 +308,25 @@ again:* it's a read-only handle, it's expected that futexes attach to * the object not the particular process. */ -if (PageAnon (page)) { +if (PageAnon (page_head)) { key->both.offset |=FUT_OFF_MMSHARED ;/* ref taken on mm */ key->private.mm = mm; key->private.address = address; }else { key->both.offset |=FUT_OFF_INODE ;/* inode-based key */ - key->shared.inode = page->mapping->host; - key->shared.pgoff = page->index; + key->shared.inode = page_head->mapping->host; + key->shared.pgoff = page_head->index; }get_futex_key_refs (key); -unlock_page (page); +unlock_page (page_head); +if (page != page_head) { +VM_BUG_ON (!PageTail (page)); +/* releasing compound_lock after page_lock won't matter */ +compound_unlock (page_head); +put_page (page_head); + }put_page (page);return 0 ; }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 5/36 fix bad_page to show the real reason the page is bad
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
page_count shows the count of the head page, but the actual check is done on the tail page, so show what is really being checked.
---
mm/page_alloc.c +1 -1
@@ -5218,7 +5218,7 @@ void dump_page(struct page *page) {printk (KERN_ALERT "page:%p count:%d mapcount:%d mapping:%p index:%#lx\n" , - page,page_count (page),page_mapcount (page), + page,atomic_read (&page->_count),page_mapcount (page), page->mapping, page->index);dump_page_flags (page->flags); }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 6/36 clear compound mapping
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Clear compound mapping for anonymous compound pages like it already happens for regular anonymous pages.
---
mm/page_alloc.c +2 -0
@@ -584,6 +584,8 @@ static void __free_pages_ok(struct pagekmemcheck_free_shadow (page, order); +if (PageAnon (page)) + page->mapping =NULL ;for (i =0 ; i < (1 << order) ; ++i) bad +=free_pages_check (page + i);if (bad)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 7/36 add native_set_pmd_at
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Used by paravirt and not paravirt set_pmd_at.
---
arch/x86/include/asm/pgtable.h +6 -0
@@ -528,6 +528,12 @@ static inline void native_set_pte_at(strnative_set_pte (ptep, pte); } +static inline void native_set_pmd_at (struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp ,pmd_t pmd) +{ +native_set_pmd (pmdp, pmd); +} +#ifndef CONFIG_PARAVIRT /* * Rules for using pte_update - it must be called after any PTE update which
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 8/36 add pmd paravirt ops
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Paravirt ops pmd_update/pmd_update_defer/pmd_set_at. Not all might be necessary (vmware needs pmd_update, Xen needs set_pmd_at, nobody needs pmd_update_defer), but this is to keep full simmetry with pte paravirt ops, which looks cleaner and simpler from a common code POV.
---
arch/x86/include/asm/paravirt.h +23 -0
@@ -449,6 +449,11 @@ static inline void pte_update(struct mm_ {PVOP_VCALL3 (pv_mmu_ops.pte_update, mm, addr, ptep); } +static inline void pmd_update (struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp) +{ +PVOP_VCALL3 (pv_mmu_ops.pmd_update, mm, addr, pmdp); +}static inline void pte_update_defer (struct mm_struct *mm,unsigned long addr,pte_t *ptep)
@@ -456,6 +461,12 @@ static inline void pte_update_defer(struPVOP_VCALL3 (pv_mmu_ops.pte_update_defer, mm, addr, ptep); } +static inline void pmd_update_defer (struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp) +{ +PVOP_VCALL3 (pv_mmu_ops.pmd_update_defer, mm, addr, pmdp); +} +static inline pte_t __pte (pteval_t val) {pteval_t ret;
@@ -557,6 +568,18 @@ static inline void set_pte_at(struct mm_PVOP_VCALL4 (pv_mmu_ops.set_pte_at, mm, addr, ptep, pte.pte); } +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static inline void set_pmd_at (struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp,pmd_t pmd) +{ +if (sizeof (pmdval_t) >sizeof (long )) +/* 5 arg words */ + pv_mmu_ops.set_pmd_at (mm, addr, pmdp, pmd); +else +PVOP_VCALL4 (pv_mmu_ops.set_pmd_at, mm, addr, pmdp, pmd.pmd); +} +#endif +static inline void set_pmd (pmd_t *pmdp,pmd_t pmd) {pmdval_t val =native_pmd_val (pmd);
arch/x86/include/asm/paravirt_types.h +6 -0
@@ -266,10 +266,16 @@ struct pv_mmu_ops {void (*set_pte_at)(struct mm_struct *mm,unsigned long addr,pte_t *ptep,pte_t pteval);void (*set_pmd)(pmd_t *pmdp,pmd_t pmdval); +void (*set_pmd_at)(struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp,pmd_t pmdval);void (*pte_update)(struct mm_struct *mm,unsigned long addr,pte_t *ptep);void (*pte_update_defer)(struct mm_struct *mm,unsigned long addr,pte_t *ptep); +void (*pmd_update)(struct mm_struct *mm,unsigned long addr, +pmd_t *pmdp); +void (*pmd_update_defer)(struct mm_struct *mm, +unsigned long addr,pmd_t *pmdp);pte_t (*ptep_modify_prot_start)(struct mm_struct *mm,unsigned long addr,pte_t *ptep);
arch/x86/kernel/paravirt.c +3 -0
@@ -422,8 +422,11 @@ struct pv_mmu_ops pv_mmu_ops = { .set_pte = native_set_pte, .set_pte_at = native_set_pte_at, .set_pmd = native_set_pmd, + .set_pmd_at = native_set_pmd_at, .pte_update = paravirt_nop, .pte_update_defer = paravirt_nop, + .pmd_update = paravirt_nop, + .pmd_update_defer = paravirt_nop, .ptep_modify_prot_start = __ptep_modify_prot_start, .ptep_modify_prot_commit = __ptep_modify_prot_commit,
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 9/36 no paravirt version of pmd ops
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
No paravirt version of set_pmd_at/pmd_update/pmd_update_defer.
---
arch/x86/include/asm/pgtable.h +3 -0
@@ -33,6 +33,7 @@ extern struct list_head pgd_list;#else /* !CONFIG_PARAVIRT */ #define set_pte (ptep, pte) native_set_pte(ptep, pte)#define set_pte_at (mm, addr, ptep, pte) native_set_pte_at(mm, addr, ptep, pte) +#define set_pmd_at (mm, addr, pmdp, pmd) native_set_pmd_at(mm, addr, pmdp, pmd)#define set_pte_atomic (ptep, pte) \ native_set_pte_atomic(ptep, pte)
@@ -57,6 +58,8 @@ extern struct list_head pgd_list;#define pte_update (mm, addr, ptep) do { } while (0)#define pte_update_defer (mm, addr, ptep) do { } while (0) +#define pmd_update (mm, addr, ptep) do { } while (0) +#define pmd_update_defer (mm, addr, ptep) do { } while (0)#define pgd_val (x) native_pgd_val(x)#define __pgd (x) native_make_pgd(x)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 10/36 export maybe_mkwrite
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
huge_memory.c needs it too when it fallbacks in copying hugepages into regular fragmented pages if hugepage allocation fails during COW.
---
include/linux/mm.h +13 -0
@@ -387,6 +387,19 @@ static inline void set_compound_order(st }/* +* Do pte_mkwrite, but only if the vma says VM_WRITE. We do this when +* servicing faults for write access. In the normal case, do always want +* pte_mkwrite. But get_user_pages can cause write faults for mappings +* that do not have writing enabled, when used by access_process_vm. +*/ +static inline pte_t maybe_mkwrite (pte_t pte,struct vm_area_struct *vma) +{ +if (likely (vma->vm_flags &VM_WRITE )) + pte =pte_mkwrite (pte); +return pte; +} + +/* * Multiple processes may "see" the same page. E.g. for untouched * mappings of /dev/null, all processes see the same page full of * zeroes, and text pages of executables and shared libraries have
mm/memory.c +0 -13
@@ -1943,19 +1943,6 @@ static inline int pte_unmap_same(structreturn same; } -/* -* Do pte_mkwrite, but only if the vma says VM_WRITE. We do this when -* servicing faults for write access. In the normal case, do always want -* pte_mkwrite. But get_user_pages can cause write faults for mappings -* that do not have writing enabled, when used by access_process_vm. -*/ -static inline pte_t maybe_mkwrite (pte_t pte,struct vm_area_struct *vma) -{ -if (likely (vma->vm_flags &VM_WRITE )) - pte =pte_mkwrite (pte); -return pte; -} -static inline void cow_user_page (struct page *dst,struct page *src,unsigned long va,struct vm_area_struct *vma) {/*
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 11/36 comment reminder in destroy_compound_page
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Warn destroy_compound_page that __split_huge_page_refcount is heavily dependent on its internal behavior.
---
mm/page_alloc.c +1 -0
@@ -311,6 +311,7 @@ void prep_compound_page(struct page *pag } } +/* update __split_huge_page_refcount if you change this function */ static int destroy_compound_page (struct page *page,unsigned long order) {int i;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 12/36 config_transparent_hugepage
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Add config option.
---
mm/Kconfig +14 -0
@@ -283,3 +283,17 @@ config NOMMU_INITIAL_TRIM_EXCESS of 1 says that all excess pages should be trimmed. See Documentation/nommu-mmap.txt for more information. + +config TRANSPARENT_HUGEPAGE + bool "Transparent Hugepage support" if EMBEDDED + depends on X86_64 + default y + help + Transparent Hugepages allows the kernel to use huge pages and + huge tlb transparently to the applications whenever possible. + This feature can improve computing performance to certain + applications by speeding up page faults during memory + allocation, by reducing the number of tlb misses and by speeding + up the pagetable walking. + + If memory constrained on embedded, you may want to say N.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 13/36 special pmd_trans_* functions
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
These returns 0 at compile time when the config option is disabled, to allow gcc to eliminate the transparent hugepage function calls at compile time without additional #ifdefs (only the export of those functions have to be visible to gcc but they won't be required at link time and huge_memory.o can be not built at all).
_PAGE_BIT_UNUSED1 is never used for pmd, only on pte.
---
arch/x86/include/asm/pgtable_64.h +13 -0
@@ -168,6 +168,19 @@ extern void cleanup_highmap(void);#define kc_offset_to_vaddr (o) ((o) | ~__VIRTUAL_MASK)#define __HAVE_ARCH_PTE_SAME + +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static inline int pmd_trans_splitting (pmd_t pmd) +{ +return pmd_val (pmd) & _PAGE_SPLITTING; +} + +static inline int pmd_trans_huge (pmd_t pmd) +{ +return pmd_val (pmd) & _PAGE_PSE; +} +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif /* !__ASSEMBLY__ */ #endif /* _ASM_X86_PGTABLE_64_H */
arch/x86/include/asm/pgtable_types.h +2 -0
@@ -22,6 +22,7 @@#define _PAGE_BIT_PAT_LARGE 12/* On 2MB or 1GB pages */ #define _PAGE_BIT_SPECIAL _PAGE_BIT_UNUSED1#define _PAGE_BIT_CPA_TEST _PAGE_BIT_UNUSED1 +#define _PAGE_BIT_SPLITTING _PAGE_BIT_UNUSED1/* only valid on a PSE pmd */ #define _PAGE_BIT_NX 63/* No execute: only valid after cpuid check */ /* If _PAGE_BIT_PRESENT is clear, we use these: */
@@ -45,6 +46,7 @@#define _PAGE_PAT_LARGE (_AT(pteval_t, 1) << _PAGE_BIT_PAT_LARGE)#define _PAGE_SPECIAL (_AT(pteval_t, 1) << _PAGE_BIT_SPECIAL)#define _PAGE_CPA_TEST (_AT(pteval_t, 1) << _PAGE_BIT_CPA_TEST) +#define _PAGE_SPLITTING (_AT(pteval_t, 1) << _PAGE_BIT_SPLITTING)#define __HAVE_ARCH_PTE_SPECIAL#ifdef CONFIG_KMEMCHECK
include/asm-generic/pgtable.h +5 -0
@@ -344,6 +344,11 @@ extern void untrack_pfn_vma(struct vm_ar unsigned long size);#endif +#ifndef CONFIG_TRANSPARENT_HUGEPAGE +#define pmd_trans_huge (pmd) 0 +#define pmd_trans_splitting (pmd) 0 +#endif +#endif /* !__ASSEMBLY__ */ #endif /* _ASM_GENERIC_PGTABLE_H */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 14/36 add pmd mangling generic functions
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Some are needed to build but not actually used on archs not supporting transparent hugepages. Others like pmdp_clear_flush are used by x86 too.
---
include/asm-generic/pgtable.h +125 -0
@@ -25,6 +25,26 @@ })#endif +#ifndef __HAVE_ARCH_PMDP_SET_ACCESS_FLAGS +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_set_access_flags (__vma, __address, __pmdp, __entry, __dirty) \ + ({ \ + int __changed = !pmd_same(*(__pmdp), __entry); \ + VM_BUG_ON((__address) & ~HPAGE_PMD_MASK); \ + if (__changed) { \ + set_pmd_at((__vma)->vm_mm, __address, __pmdp, \ + __entry); \ + flush_tlb_range(__vma, __address, \ + (__address) + HPAGE_PMD_SIZE); \ + } \ + __changed; \ + }) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_set_access_flags (__vma, __address, __pmdp, __entry, __dirty) \ + ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG#define ptep_test_and_clear_young (__vma, __address, __ptep) \ ({ \
@@ -39,6 +59,25 @@ })#endif +#ifndef __HAVE_ARCH_PMDP_TEST_AND_CLEAR_YOUNG +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_test_and_clear_young (__vma, __address, __pmdp) \ +({ \ + pmd_t __pmd = *(__pmdp); \ + int r = 1; \ + if (!pmd_young(__pmd)) \ + r = 0; \ + else \ + set_pmd_at((__vma)->vm_mm, (__address), \ + (__pmdp), pmd_mkold(__pmd)); \ + r; \ +}) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_test_and_clear_young (__vma, __address, __pmdp) \ + ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTEP_CLEAR_YOUNG_FLUSH#define ptep_clear_flush_young (__vma, __address, __ptep) \ ({ \
@@ -50,6 +89,24 @@ })#endif +#ifndef __HAVE_ARCH_PMDP_CLEAR_YOUNG_FLUSH +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_clear_flush_young (__vma, __address, __pmdp) \ +({ \ + int __young; \ + VM_BUG_ON((__address) & ~HPAGE_PMD_MASK); \ + __young = pmdp_test_and_clear_young(__vma, __address, __pmdp); \ + if (__young) \ + flush_tlb_range(__vma, __address, \ + (__address) + HPAGE_PMD_SIZE); \ + __young; \ +}) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_clear_flush_young (__vma, __address, __pmdp) \ + ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTEP_GET_AND_CLEAR#define ptep_get_and_clear (__mm, __address, __ptep) \ ({ \
@@ -59,6 +116,20 @@ })#endif +#ifndef __HAVE_ARCH_PMDP_GET_AND_CLEAR +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_get_and_clear (__mm, __address, __pmdp) \ +({ \ + pmd_t __pmd = *(__pmdp); \ + pmd_clear((__mm), (__address), (__pmdp)); \ + __pmd; \ +}) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_get_and_clear (__mm, __address, __pmdp) \ + ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTEP_GET_AND_CLEAR_FULL#define ptep_get_and_clear_full (__mm, __address, __ptep, __full) \ ({ \
@@ -90,6 +161,22 @@ do { \ })#endif +#ifndef __HAVE_ARCH_PMDP_CLEAR_FLUSH +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_clear_flush (__vma, __address, __pmdp) \ +({ \ + pmd_t __pmd; \ + VM_BUG_ON((__address) & ~HPAGE_PMD_MASK); \ + __pmd = pmdp_get_and_clear((__vma)->vm_mm, __address, __pmdp); \ + flush_tlb_range(__vma, __address, (__address) + HPAGE_PMD_SIZE);\ + __pmd; \ +}) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_clear_flush (__vma, __address, __pmdp) \ + ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTEP_SET_WRPROTECTstruct mm_struct ;static inline void ptep_set_wrprotect (struct mm_struct *mm,unsigned long address,pte_t *ptep)
@@ -99,10 +186,45 @@ static inline void ptep_set_wrprotect(st }#endif +#ifndef __HAVE_ARCH_PMDP_SET_WRPROTECT +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static inline void pmdp_set_wrprotect (struct mm_struct *mm,unsigned long address,pmd_t *pmdp) +{ +pmd_t old_pmd = *pmdp; +set_pmd_at (mm, address, pmdp,pmd_wrprotect (old_pmd)); +} +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_set_wrprotect (mm, address, pmdp) BUG() +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif + +#ifndef __HAVE_ARCH_PMDP_SPLITTING_FLUSH +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmdp_splitting_flush (__vma, __address, __pmdp) \ +({ \ + pmd_t __pmd = pmd_mksplitting(*(__pmdp)); \ + VM_BUG_ON((__address) & ~HPAGE_PMD_MASK); \ + set_pmd_at((__vma)->vm_mm, __address, __pmdp, __pmd); \ +/* tlb flush only to serialize against gup-fast */ \ +flush_tlb_range (__vma, __address, (__address) +HPAGE_PMD_SIZE );\ +}) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmdp_splitting_flush (__vma, __address, __pmdp) BUG() +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PTE_SAME#define pte_same (A ,B ) (pte_val(A) == pte_val(B))#endif +#ifndef __HAVE_ARCH_PMD_SAME +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +#define pmd_same (A ,B ) (pmd_val(A) == pmd_val(B)) +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +#define pmd_same (A ,B ) ({ BUG(); 0; }) +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ +#endif +#ifndef __HAVE_ARCH_PAGE_TEST_DIRTY#define page_test_dirty (page) (0)#endif
@@ -347,6 +469,9 @@ extern void untrack_pfn_vma(struct vm_ar#ifndef CONFIG_TRANSPARENT_HUGEPAGE #define pmd_trans_huge (pmd) 0#define pmd_trans_splitting (pmd) 0 +#ifndef __HAVE_ARCH_PMD_WRITE +#define pmd_write (pmd) ({ BUG(); 0; }) +#endif /* __HAVE_ARCH_PMD_WRITE */ #endif #endif /* !__ASSEMBLY__ */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 15/36 add pmd mangling functions to x86
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Add needed pmd mangling functions with simmetry with their pte counterparts. pmdp_freeze_flush is the only exception only present on the pmd side and it's needed to serialize the VM against split_huge_page, it simply atomically clears the present bit in the same way pmdp_clear_flush_young atomically clears the accessed bit (and both need to flush the tlb to make it effective, which is mandatory to happen synchronously for pmdp_freeze_flush).
---
arch/x86/include/asm/pgtable.h +4 -4
@@ -300,15 +300,15 @@ pmd_t *populate_extra_pmd(unsigned longpte_t *populate_extra_pte (unsigned long vaddr);#endif /* __ASSEMBLY__ */ +#ifndef __ASSEMBLY__ +#include <linux/mm_types.h> +#ifdef CONFIG_X86_32 # include "pgtable_32.h" #else # include "pgtable_64.h" #endif -#ifndef __ASSEMBLY__ -#include <linux/mm_types.h> -static inline int pte_none (pte_t pte) {return !pte.pte;
@@ -351,7 +351,7 @@ static inline unsigned long pmd_page_vad* Currently stuck as a macro due to indirect forward reference to * linux/mmzone.h's __section_mem_map_addr() definition: */ -#define pmd_page (pmd) pfn_to_page(pmd_val(pmd) >> PAGE_SHIFT) +#define pmd_page (pmd) pfn_to_page((pmd_val(pmd) & PTE_PFN_MASK) >> PAGE_SHIFT)/* * the pmd page can be thought of an array like this: pmd_t[PTRS_PER_PMD]
arch/x86/include/asm/pgtable_64.h +105 -0
117 lines not on this page · raw message
arch/x86/mm/pgtable.c +66 -0
84 lines not on this page · raw message
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 16/36 bail out gup_fast on splitting pmd
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Force gup_fast to take the slow path and block if the pmd is splitting, not only if it's none.
---
arch/x86/mm/gup.c +12 -1
@@ -160,7 +160,18 @@ static int gup_pmd_range(pud_t pud, unsipmd_t pmd = *pmdp; next =pmd_addr_end (addr, end); -if (pmd_none (pmd)) +/* +* The pmd_trans_splitting() check below explains why +* pmdp_splitting_flush has to flush the tlb, to stop +* this gup-fast code from running while we set the +* splitting bit in the pmd. Returning zero will take +* the slow path that will call wait_split_huge_page() +* if the pmd is still in splitting state. gup-fast +* can't because it has irq disabled and +* wait_split_huge_page() would never return as the +* tlb flush IPI wouldn't run. +*/ +if (pmd_none (pmd) ||pmd_trans_splitting (pmd))return 0 ;if (unlikely (pmd_large (pmd))) {if (!gup_huge_pmd (pmd, addr, next, write, pages, nr))
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 17/36 pte alloc trans splitting
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
pte alloc routines must wait for split_huge_page if the pmd is not present and not null (i.e. pmd_trans_splitting). The additional branches are optimized away at compile time by pmd_trans_splitting if the config option is off. However we must pass the vma down in order to know the anon_vma lock to wait for.
---
include/linux/mm.h +8 -5
@@ -955,7 +955,8 @@ static inline int __pmd_alloc(struct mm_int __pmd_alloc (struct mm_struct *mm,pud_t *pud,unsigned long address);#endif -int __pte_alloc (struct mm_struct *mm,pmd_t *pmd,unsigned long address); +int __pte_alloc (struct mm_struct *mm,struct vm_area_struct *vma, +pmd_t *pmd,unsigned long address);int __pte_alloc_kernel (pmd_t *pmd,unsigned long address);/*
@@ -1024,12 +1025,14 @@ static inline void pgtable_page_dtor(strpte_unmap (pte); \ } while (0) -#define pte_alloc_map (mm, pmd, address) \ - ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, pmd, address))? \ - NULL: pte_offset_map(pmd, address)) +#define pte_alloc_map (mm, vma, pmd, address) \ + ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, vma, \ + pmd, address))? \ + NULL: pte_offset_map(pmd, address))#define pte_alloc_map_lock (mm, pmd, address, ptlp) \ - ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, pmd, address))? \ + ((unlikely(!pmd_present(*(pmd))) && __pte_alloc(mm, NULL, \ + pmd, address))? \ NULL: pte_offset_map_lock(mm, pmd, address, ptlp))#define pte_alloc_kernel (pmd, address) \
mm/memory.c +13 -6
@@ -324,9 +324,11 @@ void free_pgtables(struct mmu_gather *tl } } -int __pte_alloc (struct mm_struct *mm,pmd_t *pmd,unsigned long address) +int __pte_alloc (struct mm_struct *mm,struct vm_area_struct *vma, +pmd_t *pmd,unsigned long address) {pgtable_t new =pte_alloc_one (mm, address); +int wait_split_huge_page;if (!new)return -ENOMEM ;
@@ -346,14 +348,18 @@ int __pte_alloc(struct mm_struct *mm, pmsmp_wmb ();/* Could be smp_wmb__xxx(before|after)_spin_lock */ spin_lock (&mm->page_table_lock); -if (!pmd_present (*pmd)) {/* Has another populated it ? */ + wait_split_huge_page =0 ; +if (likely (pmd_none (*pmd))) {/* Has another populated it ? */ mm->nr_ptes++;pmd_populate (mm, pmd, new); new =NULL ; - } + }else if (unlikely (pmd_trans_splitting (*pmd))) + wait_split_huge_page =1 ;spin_unlock (&mm->page_table_lock);if (new)pte_free (mm, new); +if (wait_split_huge_page) +wait_split_huge_page (vma->anon_vma, pmd);return 0 ; }
@@ -366,10 +372,11 @@ int __pte_alloc_kernel(pmd_t *pmd, unsigsmp_wmb ();/* See comment in __pte_alloc */ spin_lock (&init_mm.page_table_lock); -if (!pmd_present (*pmd)) {/* Has another populated it ? */ +if (likely (pmd_none (*pmd))) {/* Has another populated it ? */ pmd_populate_kernel (&init_mm, pmd, new); new =NULL ; - } + }else +VM_BUG_ON (pmd_trans_splitting (*pmd));spin_unlock (&init_mm.page_table_lock);if (new)pte_free_kernel (&init_mm, new);
@@ -3020,7 +3027,7 @@ int handle_mm_fault(struct mm_struct *mm pmd =pmd_alloc (mm, pud, address);if (!pmd)return VM_FAULT_OOM ; - pte =pte_alloc_map (mm, pmd, address); + pte =pte_alloc_map (mm, vma, pmd, address);if (!pte)return VM_FAULT_OOM ;
mm/mremap.c +4 -3
@@ -48,7 +48,8 @@ static pmd_t *get_old_pmd(struct mm_strureturn pmd; } -static pmd_t *alloc_new_pmd (struct mm_struct *mm,unsigned long addr) +static pmd_t *alloc_new_pmd (struct mm_struct *mm,struct vm_area_struct *vma, +unsigned long addr) {pgd_t *pgd;pud_t *pud;
@@ -63,7 +64,7 @@ static pmd_t *alloc_new_pmd(struct mm_stif (!pmd)return NULL ; -if (!pmd_present (*pmd) &&__pte_alloc (mm, pmd, addr)) +if (!pmd_present (*pmd) &&__pte_alloc (mm, vma, pmd, addr))return NULL ;return pmd;
@@ -148,7 +149,7 @@ unsigned long move_page_tables(struct vm old_pmd =get_old_pmd (vma->vm_mm, old_addr);if (!old_pmd)continue ; - new_pmd =alloc_new_pmd (vma->vm_mm, new_addr); + new_pmd =alloc_new_pmd (vma->vm_mm, vma, new_addr);if (!new_pmd)break ; next = (new_addr +PMD_SIZE ) &PMD_MASK ;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 18/36 add pmd mmu_notifier helpers
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Add mmu notifier helpers to handle pmd huge operations.
---
include/linux/mmu_notifier.h +40 -0
@@ -243,6 +243,32 @@ static inline void mmu_notifier_mm_destr __pte; \ }) +#define pmdp_clear_flush_notify (__vma, __address, __pmdp) \ +({ \ + pmd_t __pmd; \ + struct vm_area_struct *___vma = __vma; \ + unsigned long ___address = __address; \ + VM_BUG_ON(__address & ~HPAGE_PMD_MASK); \ + mmu_notifier_invalidate_range_start(___vma->vm_mm, ___address, \ + (__address)+HPAGE_PMD_SIZE);\ + __pmd = pmdp_clear_flush(___vma, ___address, __pmdp); \ + mmu_notifier_invalidate_range_end(___vma->vm_mm, ___address, \ + (__address)+HPAGE_PMD_SIZE); \ + __pmd; \ +}) + +#define pmdp_splitting_flush_notify (__vma, __address, __pmdp) \ +({ \ + struct vm_area_struct *___vma = __vma; \ + unsigned long ___address = __address; \ + VM_BUG_ON(__address & ~HPAGE_PMD_MASK); \ + mmu_notifier_invalidate_range_start(___vma->vm_mm, ___address, \ + (__address)+HPAGE_PMD_SIZE);\ + pmdp_splitting_flush(___vma, ___address, __pmdp); \ + mmu_notifier_invalidate_range_end(___vma->vm_mm, ___address, \ + (__address)+HPAGE_PMD_SIZE); \ +}) +#define ptep_clear_flush_young_notify (__vma, __address, __ptep) \ ({ \ int __young; \
@@ -254,6 +280,17 @@ static inline void mmu_notifier_mm_destr __young; \ }) +#define pmdp_clear_flush_young_notify (__vma, __address, __pmdp) \ +({ \ + int __young; \ + struct vm_area_struct *___vma = __vma; \ + unsigned long ___address = __address; \ + __young = pmdp_clear_flush_young(___vma, ___address, __pmdp); \ + __young |= mmu_notifier_clear_flush_young(___vma->vm_mm, \ + ___address); \ + __young; \ +}) +#define set_pte_at_notify (__mm, __address, __ptep, __pte) \ ({ \ struct mm_struct *___mm = __mm; \
@@ -305,7 +342,10 @@ static inline void mmu_notifier_mm_destr }#define ptep_clear_flush_young_notify ptep_clear_flush_young +#define pmdp_clear_flush_young_notify pmdp_clear_flush_young#define ptep_clear_flush_notify ptep_clear_flush +#define pmdp_clear_flush_notify pmdp_clear_flush +#define pmdp_splitting_flush_notify pmdp_splitting_flush#define set_pte_at_notify set_pte_at#endif /* CONFIG_MMU_NOTIFIER */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 19/36 clear page compound
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
split_huge_page must transform a compound page to a regular page and needs ClearPageCompound.
---
include/linux/page-flags.h +16 -1
@@ -349,7 +349,7 @@ static inline void set_page_writeback(st* tests can be used in performance sensitive paths. PageCompound is * generally not used in hot code paths. */ -__PAGEFLAG(Head, head) +__PAGEFLAG(Head, head) CLEARPAGEFLAG(Head, head) __PAGEFLAG(Tail, tail)static inline int PageCompound (struct page *page)
@@ -357,6 +357,13 @@ static inline int PageCompound(struct pa return page->flags & ((1L << PG_head) | (1L << PG_tail)); } +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static inline void ClearPageCompound (struct page *page) +{ +BUG_ON (!PageHead (page)); +ClearPageHead (page); +} +#endif #else /* * Reduce page flag use as much as possible by overlapping
@@ -394,6 +401,14 @@ static inline void __ClearPageTail(struc page->flags &= ~PG_head_tail_mask; } +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static inline void ClearPageCompound (struct page *page) +{ +BUG_ON (page->flags & PG_head_tail_mask != (1 << PG_compound)); +ClearPageCompound (page); +} +#endif +#endif /* !PAGEFLAGS_EXTENDED */ #ifdef CONFIG_MMU
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 20/36 add pmd_huge_pte to mm_struct
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
This increase the size of the mm struct a bit but it is needed to preallocate one pte for each hugepage so that split_huge_page will not require a fail path. Guarantee of success is a fundamental property of split_huge_page to avoid decrasing swapping reliability and to avoid adding -ENOMEM fail paths that would otherwise force the hugepage-unaware VM code to learn rolling back in the middle of its pte mangling operations (if something we need it to learn handling pmd_trans_huge natively rather being capable of rollback). When split_huge_page runs a pte is needed to succeed the split, to map the newly splitted regular pages with a regular pte. This way all existing VM code remains backwards compatible by just adding a split_huge_page* one liner. The memory waste of those preallocated ptes is negligible and so it is worth it.
---
include/linux/mm_types.h +3 -0
@@ -291,6 +291,9 @@ struct mm_struct {#ifdef CONFIG_MMU_NOTIFIER struct mmu_notifier_mm *mmu_notifier_mm;#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +pgtable_t pmd_huge_pte;/* protected by page_table_lock */ +#endif };/* Future-safe accessor for struct mm_struct's cpu_vm_mask. */
kernel/fork.c +7 -0
@@ -498,6 +498,9 @@ void __mmdrop(struct mm_struct *mm)mm_free_pgd (mm);destroy_context (mm);mmu_notifier_mm_destroy (mm); +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +VM_BUG_ON (mm->pmd_huge_pte); +#endif free_mm (mm); }EXPORT_SYMBOL_GPL (__mmdrop);
@@ -638,6 +641,10 @@ struct mm_struct *dup_mm(struct task_str mm->token_priority =0 ; mm->last_interval =0 ; +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + mm->pmd_huge_pte =NULL ; +#endif +if (!mm_init (mm, tsk)) goto fail_nomem;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 21/36 split_huge_page_mm/vma
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
split_huge_page_mm/vma compat code. Each one of those would need to be expanded to hundred of lines of complex code without a fully reliable split_huge_page_mm/vma functionality.
---
arch/x86/kernel/vm86_32.c +1 -0
@@ -179,6 +179,7 @@ static void mark_screen_rdonly(struct mmif (pud_none_or_clear_bad (pud)) goto out; pmd =pmd_offset (pud,0xA0000 ); +split_huge_page_mm (mm,0xA0000 , pmd);if (pmd_none_or_clear_bad (pmd)) goto out; pte =pte_offset_map_lock (mm, pmd,0xA0000 , &ptl);
mm/mempolicy.c +1 -0
@@ -446,6 +446,7 @@ static inline int check_pmd_range(struct pmd =pmd_offset (pud, addr); do { next = pmd_addr_end(addr, end); + split_huge_page_vma(vma, pmd); if (pmd_none_or_clear_bad(pmd)) continue; if (check_pte_range(vma, pmd, addr, next, nodes,
mm/mincore.c +1 -0
@@ -132,6 +132,7 @@ static long do_mincore(unsigned long addif (pud_none_or_clear_bad (pud)) goto none_mapped; pmd =pmd_offset (pud, addr); +split_huge_page_vma (vma, pmd);if (pmd_none_or_clear_bad (pmd)) goto none_mapped;
mm/mprotect.c +1 -0
@@ -89,6 +89,7 @@ static inline void change_pmd_range(stru pmd =pmd_offset (pud, addr); do { next = pmd_addr_end(addr, end); + split_huge_page_mm(mm, addr, pmd); if (pmd_none_or_clear_bad(pmd)) continue; change_pte_range(mm, pmd, addr, next, newprot, dirty_accountable);
mm/mremap.c +1 -0
@@ -42,6 +42,7 @@ static pmd_t *get_old_pmd(struct mm_strureturn NULL ; pmd =pmd_offset (pud, addr); +split_huge_page_mm (mm, addr, pmd);if (pmd_none_or_clear_bad (pmd))return NULL ;
mm/pagewalk.c +1 -0
@@ -34,6 +34,7 @@ static int walk_pmd_range(pud_t *pud, un pmd =pmd_offset (pud, addr); do { next = pmd_addr_end(addr, end); + split_huge_page_mm(walk->mm, addr, pmd); if (pmd_none_or_clear_bad(pmd)) { if (walk->pte_hole) err = walk->pte_hole(addr, next, walk);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 22/36 split_huge_page paging
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Paging logic that splits the page before it is unmapped and added to swap to ensure backwards compatibility with the legacy swap code. Eventually swap should natively pageout the hugepages to increase performance and decrease seeking and fragmentation of swap space. swapoff can just skip over huge pmd as they cannot be part of swap yet. In add_to_swap be careful to split the page only if we got a valid swap entry so we don't split hugepages with a full swap.
In theory we could split pages before isolating them during the lru scan, but for khugepaged to be safe, I'm relying on either mmap_sem write mode, or PG_lock taken, so split_huge_page has to run either with mmap_sem read/write mode or PG_lock taken. Calling it from isolate_lru_page would make locking more complicated, in addition to that split_huge_page would deadlock if called by __isolate_lru_page because it has to take the lru lock to add the tail pages.
---
mm/memory-failure.c +2 -0
@@ -378,6 +378,8 @@ static void collect_procs_anon(struct pastruct task_struct *tsk;struct anon_vma *av; +if (unlikely (split_huge_page (page))) +return ;read_lock (&tasklist_lock); av =page_lock_anon_vma (page);if (av ==NULL )/* Not actually mapped anymore */
mm/rmap.c +1 -0
@@ -1174,6 +1174,7 @@ int try_to_unmap(struct page *page, enumint ret;BUG_ON (!PageLocked (page)); +BUG_ON (PageTransHuge (page));if (unlikely (PageKsm (page))) ret =try_to_unmap_ksm (page, flags);
mm/swap_state.c +6 -0
@@ -156,6 +156,12 @@ int add_to_swap(struct page *page)if (!entry.val)return 0 ; +if (unlikely (PageTransHuge (page))) +if (unlikely (split_huge_page (page))) { +swapcache_free (entry,NULL ); +return 0 ; + } +/* * Radix-tree node allocations from PF_MEMALLOC contexts could * completely exhaust the page allocator. __GFP_NOMEMALLOC
mm/swapfile.c +2 -0
@@ -905,6 +905,8 @@ static inline int unuse_pmd_range(struct pmd =pmd_offset (pud, addr); do { next = pmd_addr_end(addr, end); + if (unlikely(pmd_trans_huge(*pmd))) + continue; if (pmd_none_or_clear_bad(pmd)) continue; ret = unuse_pte_range(vma, pmd, addr, next, entry, page);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 23/36 clear_copy_huge_page
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Move the copy/clear_huge_page functions to common code to share between hugetlb.c and huge_memory.c.
---
--- include/linux/mm.h | 9 ++++++ mm/hugetlb.c | 69 ++-------------------------------------------------- mm/memory.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 82 insertions(+), 66 deletions(-)
include/linux/mm.h +9 -0
@@ -1496,5 +1496,14 @@ extern void dump_page(struct page *page)extern int sysctl_nr_trim_pages;#endif +#if defined(CONFIG_TRANSPARENT_HUGEPAGE ) || defined(CONFIG_HUGETLBFS ) +extern void clear_huge_page (struct page *page, +unsigned long addr, +unsigned int pages_per_huge_page); +extern void copy_huge_page (struct page *dst,struct page *src, +unsigned long addr,struct vm_area_struct *vma, +unsigned int pages_per_huge_page); +#endif /* CONFIG_TRANSPARENT_HUGEPAGE || CONFIG_HUGETLBFS */ +#endif /* __KERNEL__ */ #endif /* _LINUX_MM_H */
mm/hugetlb.c +3 -66
87 lines not on this page · raw message
mm/memory.c +70 -0
73 lines not on this page · raw message
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 24/36 kvm mmu transparent hugepage support
In reply to [email protected]From: Marcelo Tosatti <[email protected]>
This should work for both hugetlbfs and transparent hugepages.
---
arch/x86/kvm/mmu.c +9 -0
@@ -489,6 +489,15 @@ static int host_mapping_level(struct kvm out:up_read (¤t->mm->mmap_sem); +/* check for transparent hugepages */ +if (page_size ==PAGE_SIZE ) { +struct page *page =gfn_to_page (kvm, gfn); + +if (!is_error_page (page) &&PageHead (page)) + page_size =KVM_HPAGE_SIZE (2 ); +kvm_release_page_clean (page); + } +for (i =PT_PAGE_TABLE_LEVEL ; i < (PT_PAGE_TABLE_LEVEL +KVM_NR_PAGE_SIZES ); ++i) {if (page_size >=KVM_HPAGE_SIZE (i))
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 25/36 _GFP_NO_KSWAPD
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Transparent hugepage allocations must be allowed not to invoke kswapd or any other kind of indirect reclaim (especially when the defrag sysfs is control disabled). It's unacceptable to swap out anonymous pages (potentially anonymous transparent hugepages) in order to create new transparent hugepages. This is true for the MADV_HUGEPAGE areas too (swapping out a kvm virtual machine and so having it suffer an unbearable slowdown, so another one with guest physical memory marked MADV_HUGEPAGE can run 30% faster if it is running memory intensive workloads, makes no sense). If a transparent hugepage allocation fails the slowdown is minor and there is total fallback, so kswapd should never be asked to swapout memory to allow the high order allocation to succeed.
---
include/linux/gfp.h +3 -1
@@ -59,13 +59,15 @@ struct vm_area_struct;#define __GFP_NOTRACK ((__force gfp_t)0)#endif +#define __GFP_NO_KSWAPD ((__force gfp_t)0x400000u) +/* * This may seem redundant, but it's a way of annotating false positives vs. * allocations that simply cannot be supported (e.g. page tables). */ #define __GFP_NOTRACK_FALSE_POSITIVE (__GFP_NOTRACK) -#define __GFP_BITS_SHIFT 22/* Room for 22 __GFP_FOO bits */ +#define __GFP_BITS_SHIFT 23/* Room for 23 __GFP_FOO bits */ #define __GFP_BITS_MASK ((__force gfp_t)((1 << __GFP_BITS_SHIFT) - 1))/* This equals 0, but use constants in case they ever change */
mm/page_alloc.c +2 -1
@@ -1829,7 +1829,8 @@ __alloc_pages_slowpath(gfp_t gfp_mask, u goto nopage; restart: -wake_all_kswapd (order, zonelist, high_zoneidx); +if (!(gfp_mask & __GFP_NO_KSWAPD)) +wake_all_kswapd (order, zonelist, high_zoneidx);/* * OK, we're below the kswapd watermark and have kicked background
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 25/36] _GFP_NO_KSWAPD
Quoted 14 lines · On 02/21/2010 09:10 AM, [email protected] wrote:
From: Andrea Arcangeli<[email protected]>
Transparent hugepage allocations must be allowed not to invoke kswapd or any other kind of indirect reclaim (especially when the defrag sysfs is control disabled). It's unacceptable to swap out anonymous pages (potentially anonymous transparent hugepages) in order to create new transparent hugepages. This is true for the
MADV_HUGEPAGEareas too (swapping out a kvm virtual machine and so having it suffer an unbearable slowdown, so another one with guest physical memory markedMADV_HUGEPAGEcan run 30% faster if it is running memory intensive workloads, makes no sense). If a transparent hugepage allocation fails the slowdown is minor and there is total fallback, so kswapd should never be asked to swapout memory to allow the high order allocation to succeed.
Quoted 1 line
Signed-off-by Andrea Arcangeli<[email protected]>
Once Mel's defragmentation code is in, we can kick off that code instead when a hugepage allocation fails.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 25/36] _GFP_NO_KSWAPD
Quoted 2 lines · Rik van Riel
Once Mel's defragmentation code is in, we can kick off that code instead when a hugepage allocation fails.
That will be cool yes!! Then maybe we can turn on defrag by default... (maybe because it'd still slowdown the allocation time)
I think at least for khugepaged invoking memory compaction code by default is going to be good idea. And then I wonder if it makes sense to allow the user to disable defrag in khugepaged, if yes then it'd require a new sysfs file in the khugepaged directory.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 25/36] _GFP_NO_KSWAPD
Quoted 5 lines · Andrea Arcangeli
Quoted 3 lines · Rik van Riel
Once Mel's defragmentation code is in, we can kick off that code instead when a hugepage allocation fails.
Quoted 8 lines
That will be cool yes!! Then maybe we can turn on defrag by default... (maybe because it'd still slowdown the allocation time)
I think at least for khugepaged invoking memory compaction code by default is going to be good idea. And then I wonder if it makes sense to allow the user to disable defrag in khugepaged, if yes then it'd require a new sysfs file in the khugepaged directory.
If we detect hugepage pressure, we can run compaction in a separate thread, so we can have low latency allocations.
Signature · 7 lines
Do not meddle in the internals of kernels, for they are subtle and quick to panic. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 25/36] _GFP_NO_KSWAPD
Quoted 9 lines · Avi Kivity
Quoted 8 lines · Andrea Arcangeli
Quoted 3 lines · Rik van Riel
Once Mel's defragmentation code is in, we can kick off that code instead when a hugepage allocation fails.
That will be cool yes!! Then maybe we can turn on defrag by default... (maybe because it'd still slowdown the allocation time)
Quoted 9 lines
Quoted 5 lines
I think at least for khugepaged invoking memory compaction code by default is going to be good idea. And then I wonder if it makes sense to allow the user to disable defrag in khugepaged, if yes then it'd require a new sysfs file in the khugepaged directory.
If we detect hugepage pressure, we can run compaction in a separate thread, so we can have low latency allocations.
It'd require something like "kcompactd" and a definition of hugepage pressure but yeah, it's feasible. I think it should be on the relatively long-finger until such point as there is clear data on how long processes stall on compaction that could be resolved with a separate thread. I suspect what will happen in practice is that there will be pairings of (compaction,reclaim) during promotion where reclaim is periodically required to dump unused page cache before compaction can progress. If that prediction is accurate, would not help because it would be kicked awake, see that enough memory is not free and then go to sleep. kswapd could take on a dual role where it decides whether to reclaim or compact but it's harder to predict what the performance impact would be.
I'm not against the idea, but I wouldn't rush to implement it sooner than it's needed either.
Signature · 9 lines
Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 26/36 dont alloc harder for gfp nomemalloc even if nowait
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Not worth throwing away the precious reserved free memory pool for allocations that can fail gracefully (either through mempool or because they're transhuge allocations later falling back to 4k allocations).
---
mm/page_alloc.c +5 -1
@@ -1773,7 +1773,11 @@ gfp_to_alloc_flags(gfp_t gfp_mask)*/ alloc_flags |= (gfp_mask & __GFP_HIGH); -if (!wait) { +/* +* Not worth trying to allocate harder for __GFP_NOMEMALLOC +* even if it can't schedule. +*/ +if (!wait && !(gfp_mask & __GFP_NOMEMALLOC)) { alloc_flags |=ALLOC_HARDER ;/* * Ignore cpuset if GFP_ATOMIC (!wait) rather than fail alloc.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 26/36] dont alloc harder for gfp nomemalloc even if nowait
Quoted 7 lines · On 02/21/2010 09:10 AM, [email protected] wrote:
From: Andrea Arcangeli<[email protected]>
Not worth throwing away the precious reserved free memory pool for allocations that can fail gracefully (either through mempool or because they're transhuge allocations later falling back to 4k allocations).
Signed-off-by Andrea Arcangeli<[email protected]>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 27/36 transparent hugepage core
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Lately I've been working to make KVM use hugepages transparently without the usual restrictions of hugetlbfs. Some of the restrictions I'd like to see removed:
1) hugepages have to be swappable or the guest physical memory remains locked in RAM and can't be paged out to swap
2) if a hugepage allocation fails, regular pages should be allocated instead and mixed in the same vma without any failure and without userland noticing
3) if some task quits and more hugepages become available in the buddy, guest physical memory backed by regular pages should be relocated on hugepages automatically in regions under madvise(MADV_HUGEPAGE) (ideally event driven by waking up the kernel deamon if the order=HPAGE_PMD_SHIFT-PAGE_SHIFT list becomes not null)
4) avoidance of reservation and maximization of use of hugepages whenever possible. Reservation (needed to avoid runtime fatal faliures) may be ok for 1 machine with 1 database with 1 database cache with 1 database cache size known at boot time. It's definitely not feasible with a virtualization hypervisor usage like RHEV-H that runs an unknown number of virtual machines with an unknown size of each virtual machine with an unknown amount of pagecache that could be potentially useful in the host for guest not using O_DIRECT (aka cache=off).
hugepages in the virtualization hypervisor (and also in the guest!) are much more important than in a regular host not using virtualization, becasue with NPT/EPT they decrease the tlb-miss cacheline accesses from 24 to 19 in case only the hypervisor uses transparent hugepages, and they decrease the tlb-miss cacheline accesses from 19 to 15 in case both the linux hypervisor and the linux guest both uses this patch (though the guest will limit the addition speedup to anonymous regions only for now...). Even more important is that the tlb miss handler is much slower on a NPT/EPT guest than for a regular shadow paging or no-virtualization scenario. So maximizing the amount of virtual memory cached by the TLB pays off significantly more with NPT/EPT than without (even if there would be no significant speedup in the tlb-miss runtime).
The first (and more tedious) part of this work requires allowing the VM to handle anonymous hugepages mixed with regular pages transparently on regular anonymous vmas. This is what this patch tries to achieve in the least intrusive possible way. We want hugepages and hugetlb to be used in a way so that all applications can benefit without changes (as usual we leverage the KVM virtualization design: by improving the Linux VM at large, KVM gets the performance boost too).
The most important design choice is: always fallback to 4k allocation if the hugepage allocation fails! This is the _very_ opposite of some large pagecache patches that failed with -EIO back then if a 64k (or similar) allocation failed...
Second important decision (to reduce the impact of the feature on the existing pagetable handling code) is that at any time we can split an hugepage into 512 regular pages and it has to be done with an operation that can't fail. This way the reliability of the swapping isn't decreased (no need to allocate memory when we are short on memory to swap) and it's trivial to plug a split_huge_page* one-liner where needed without polluting the VM. Over time we can teach mprotect, mremap and friends to handle pmd_trans_huge natively without calling split_huge_page*. The fact it can't fail isn't just for swap:
if split_huge_page would return -ENOMEM (instead of the current void) we'd need to rollback the mprotect from the middle of it (ideally including undoing the split_vma) which would be a big change and in the very wrong direction (it'd likely be simpler not to call split_huge_page at all and to teach mprotect and friends to handle hugepages instead of rolling them back from the middle). In short the very value of split_huge_page is that it can't fail.
The collapsing and madvise(MADV_HUGEPAGE) part will remain separated and incremental and it'll just be an "harmless" addition later if this initial part is agreed upon. It also should be noted that locking-wise replacing regular pages with hugepages is going to be very easy if compared to what I'm doing below in split_huge_page, as it will only happen when page_count(page) matches page_mapcount(page) if we can take the PG_lock and mmap_sem in write mode. collapse_huge_page will be a "best effort" that (unlike split_huge_page) can fail at the minimal sign of trouble and we can try again later. collapse_huge_page will be similar to how KSM works and the madvise(MADV_HUGEPAGE) will work similar to madvise(MADV_MERGEABLE).
The default I like is that transparent hugepages are used at page fault time. This can be changed with /sys/kernel/mm/transparent_hugepage/enabled. The control knob can be set to three values "always", "madvise", "never" which mean respectively that hugepages are always used, or only inside madvise(MADV_HUGEPAGE) regions, or never used. /sys/kernel/mm/transparent_hugepage/defrag instead controls if the hugepage allocation should defrag memory aggressively "always", only inside "madvise" regions, or "never".
The pmd_trans_splitting/pmd_trans_huge locking is very solid. The put_page (from get_user_page users that can't use mmu notifier like O_DIRECT) that runs against a __split_huge_page_refcount instead was a pain to serialize in a way that would result always in a coherent page count for both tail and head. I think my locking solution with a compound_lock taken only after the page_first is valid and is still a PageHead should be safe but it surely needs review from SMP race point of view. In short there is no current existing way to serialize the O_DIRECT final put_page against split_huge_page_refcount so I had to invent a new one (O_DIRECT loses knowledge on the mapping status by the time gup_fast returns so...). And I didn't want to impact all gup/gup_fast users for now, maybe if we change the gup interface substantially we can avoid this locking, I admit I didn't think too much about it because changing the gup unpinning interface would be invasive.
If we ignored O_DIRECT we could stick to the existing compound refcounting code, by simply adding a get_user_pages_fast_flags(foll_flags) where KVM (and any other mmu notifier user) would call it without FOLL_GET (and if FOLL_GET isn't set we'd just BUG_ON if nobody registered itself in the current task mmu notifier list yet). But O_DIRECT is fundamental for decent performance of virtualized I/O on fast storage so we can't avoid it to solve the race of put_page against split_huge_page_refcount to achieve a complete hugepage feature for KVM.
Swap and oom works fine (well just like with regular pages ;). MMU notifier is handled transparently too, with the exception of the young bit on the pmd, that didn't have a range check but I think KVM will be fine because the whole point of hugepages is that EPT/NPT will also use a huge pmd when they notice gup returns pages with PageCompound set, so they won't care of a range and there's just the pmd young bit to check in that case.
NOTE: in some cases if the L2 cache is small, this may slowdown and waste memory during COWs because 4M of memory are accessed in a single fault instead of 8k (the payoff is that after COW the program can run faster). So we might want to switch the copy_huge_page (and clear_huge_page too) to not temporal stores. I also extensively researched ways to avoid this cache trashing with a full prefault logic that would cow in 8k/16k/32k/64k up to 1M (I can send those patches that fully implemented prefault) but I concluded they're not worth it and they add an huge additional complexity and they remove all tlb benefits until the full hugepage has been faulted in, to save a little bit of memory and some cache during app startup, but they still don't improve substantially the cache-trashing during startup if the prefault happens in >4k chunks. One reason is that those 4k pte entries copied are still mapped on a perfectly cache-colored hugepage, so the trashing is the worst one can generate in those copies (cow of 4k page copies aren't so well colored so they trashes less, but again this results in software running faster after the page fault). Those prefault patches allowed things like a pte where post-cow pages were local 4k regular anon pages and the not-yet-cowed pte entries were pointing in the middle of some hugepage mapped read-only. If it doesn't payoff substantially with todays hardware it will payoff even less in the future with larger l2 caches, and the prefault logic would blot the VM a lot. If one is emebdded transparent_hugepage can be disabled during boot with sysfs or with the boot commandline parameter transparent_hugepage=0 (or transparent_hugepage=2 to restrict hugepages inside madvise regions) that will ensure not a single hugepage is allocated at boot time. It is simple enough to just disable transparent hugepage globally and let transparent hugepages be allocated selectively by applications in the MADV_HUGEPAGE region (both at page fault time, and if enabled with the collapse_huge_page too through the kernel daemon).
This patch supports only hugepages mapped in the pmd, archs that have smaller hugepages will not fit in this patch alone. Also some archs like power have certain tlb limits that prevents mixing different page size in the same regions so they will not fit in this framework that requires "graceful fallback" to basic PAGE_SIZE in case of physical memory fragmentation. hugetlbfs remains a perfect fit for those because its software limits happen to match the hardware limits. hugetlbfs also remains a perfect fit for hugepage sizes like 1GByte that cannot be hoped to be found not fragmented after a certain system uptime and that would be very expensive to defragment with relocation, so requiring reservation. hugetlbfs is the "reservation way", the point of transparent hugepages is not to have any reservation at all and maximizing the use of cache and hugepages at all times automatically.
Some performance result:
vmx andrea # LD_PRELOAD=/usr/lib64/libhugetlbfs.so HUGETLB_MORECORE=yes HUGETLB_PATH=/mnt/huge/ ./largep ages3
memset page fault 1566023
memset tlb miss 453854
memset second tlb miss 453321
random access tlb miss 41635
random access second tlb miss 41658
vmx andrea # LD_PRELOAD=/usr/lib64/libhugetlbfs.so HUGETLB_MORECORE=yes HUGETLB_PATH=/mnt/huge/ ./largepages3 memset page fault 1566471
memset tlb miss 453375
memset second tlb miss 453320
random access tlb miss 41636
random access second tlb miss 41637
vmx andrea # ./largepages3
memset page fault 1566642
memset tlb miss 453417
memset second tlb miss 453313
random access tlb miss 41630
random access second tlb miss 41647
vmx andrea # ./largepages3
memset page fault 1566872
memset tlb miss 453418
memset second tlb miss 453315
random access tlb miss 41618
random access second tlb miss 41659
vmx andrea # echo 0 > /proc/sys/vm/transparent_hugepage
vmx andrea # ./largepages3
memset page fault 2182476
memset tlb miss 460305
memset second tlb miss 460179
random access tlb miss 44483
random access second tlb miss 44186
vmx andrea # ./largepages3
memset page fault 2182791
memset tlb miss 460742
memset second tlb miss 459962
random access tlb miss 43981
random access second tlb miss 43988
============
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/time.h>
#define SIZE (3UL*1024*1024*1024)
int main()
{
char *p = malloc(SIZE), *p2;
struct timeval before, after;
gettimeofday(&before, NULL);
memset(p, 0, SIZE);
gettimeofday(&after, NULL);
printf("memset page fault %Lu\n",
(after.tv_sec-before.tv_sec)*1000000UL +
after.tv_usec-before.tv_usec);
gettimeofday(&before, NULL);
memset(p, 0, SIZE);
gettimeofday(&after, NULL);
printf("memset tlb miss %Lu\n",
(after.tv_sec-before.tv_sec)*1000000UL +
after.tv_usec-before.tv_usec);
gettimeofday(&before, NULL);
memset(p, 0, SIZE);
gettimeofday(&after, NULL);
printf("memset second tlb miss %Lu\n",
(after.tv_sec-before.tv_sec)*1000000UL +
after.tv_usec-before.tv_usec);
gettimeofday(&before, NULL);
for (p2 = p; p2 < p+SIZE; p2 += 4096)
*p2 = 0;
gettimeofday(&after, NULL);
printf("random access tlb miss %Lu\n",
(after.tv_sec-before.tv_sec)*1000000UL +
after.tv_usec-before.tv_usec);
gettimeofday(&before, NULL);
for (p2 = p; p2 < p+SIZE; p2 += 4096)
*p2 = 0;
gettimeofday(&after, NULL);
printf("random access second tlb miss %Lu\n",
(after.tv_sec-before.tv_sec)*1000000UL +
after.tv_usec-before.tv_usec);
return 0;
}============
---
include/linux/gfp.h +3 -0
@@ -86,6 +86,9 @@ struct vm_area_struct; __GFP_HARDWALL | __GFP_HIGHMEM | \ __GFP_MOVABLE)#define GFP_IOFS (__GFP_IO | __GFP_FS) +#define GFP_TRANSHUGE (__GFP_HARDWALL | __GFP_HIGHMEM | \ + __GFP_MOVABLE | __GFP_COMP | __GFP_NOMEMALLOC | \ + __GFP_NORETRY | __GFP_NOWARN | __GFP_NO_KSWAPD)#ifdef CONFIG_NUMA #define GFP_THISNODE (__GFP_THISNODE | __GFP_NOWARN | __GFP_NORETRY)
include/linux/huge_mm.h new file +132 -0
132 lines not on this page · raw message
include/linux/mm.h +4 -0
@@ -106,6 +106,9 @@ extern unsigned int kobjsize(const void#define VM_SAO 0x20000000/* Strong Access Ordering (powerpc) */ #define VM_PFN_AT_MMAP 0x40000000/* PFNMAP vma that is fully mapped at mmap time */ #define VM_MERGEABLE 0x80000000/* KSM may merge identical pages */ +#if BITS_PER_LONG >32 +#define VM_HUGEPAGE 0x100000000UL/* MADV_HUGEPAGE marked this vma */ +#endif #ifndef VM_STACK_DEFAULT_FLAGS /* arch can override this */ #define VM_STACK_DEFAULT_FLAGS VM_DATA_DEFAULT_FLAGS
@@ -234,6 +237,7 @@ struct inode;* files which need it (119 of them) */ #include <linux/page-flags.h> +#include <linux/huge_mm.h> /* * Methods to modify the page usage count.
include/linux/mm_inline.h +9 -2
@@ -20,14 +20,21 @@ static inline int page_is_file_cache(str }static inline void -add_page_to_lru_list (struct zone *zone,struct page *page,enum lru_list l) +__add_page_to_lru_list (struct zone *zone,struct page *page,enum lru_list l, +struct list_head *head) { -list_add (&page->lru, &zone->lru[l].list); +list_add (&page->lru, head);__inc_zone_state (zone,NR_LRU_BASE + l);mem_cgroup_add_lru_list (page, l); }static inline void +add_page_to_lru_list (struct zone *zone,struct page *page,enum lru_list l) +{ +__add_page_to_lru_list (zone, page, l, &zone->lru[l].list); +} + +static inline void del_page_from_lru_list (struct zone *zone,struct page *page,enum lru_list l) {list_del (&page->lru);
include/linux/swap.h +2 -0
@@ -205,6 +205,8 @@ extern unsigned int nr_free_pagecache_pa/* linux/mm/swap.c */ extern void __lru_cache_add (struct page *,enum lru_list lru);extern void lru_cache_add_lru (struct page *,enum lru_list lru); +extern void lru_add_page_tail (struct zone * zone, +struct page *page,struct page *page_tail);extern void activate_page (struct page *);extern void mark_page_accessed (struct page *);extern void lru_add_drain (void );
mm/Makefile +1 -0
@@ -40,3 +40,4 @@ obj-$(CONFIG_MEMORY_FAILURE) += memory-f obj-$(CONFIG_HWPOISON_INJECT) += hwpoison-inject.o obj-$(CONFIG_DEBUG_KMEMLEAK) += kmemleak.o obj-$(CONFIG_DEBUG_KMEMLEAK_TEST) += kmemleak-test.o +obj-$(CONFIG_TRANSPARENT_HUGEPAGE) += huge_memory.o
mm/huge_memory.c new file +855 -0
855 lines not on this page · raw message
mm/memory.c +58 -7
105 lines not on this page · raw message
mm/rmap.c +36 -23
93 lines not on this page · raw message
mm/swap.c +37 -0
@@ -461,6 +461,43 @@ void __pagevec_release(struct pagevec *pEXPORT_SYMBOL (__pagevec_release); +/* used by __split_huge_page_refcount() */ +void lru_add_page_tail (struct zone * zone, +struct page *page,struct page *page_tail) +{ +int active; +enum lru_list lru; +const int file =0 ; +struct list_head *head; + +VM_BUG_ON (!PageHead (page)); +VM_BUG_ON (PageCompound (page_tail)); +VM_BUG_ON (PageLRU (page_tail)); +VM_BUG_ON (!spin_is_locked (&zone->lru_lock)); + +SetPageLRU (page_tail); + +if (page_evictable (page_tail,NULL )) { +if (PageActive (page)) { +SetPageActive (page_tail); + active =1 ; + lru =LRU_ACTIVE_ANON ; + }else { + active =0 ; + lru =LRU_INACTIVE_ANON ; + } +update_page_reclaim_stat (zone, page_tail, file, active); +if (likely (PageLRU (page))) + head = page->lru.prev; +else + head = &zone->lru[lru].list; +__add_page_to_lru_list (zone, page_tail, lru, head); + }else { +SetPageUnevictable (page_tail); +add_page_to_lru_list (zone, page_tail,LRU_UNEVICTABLE ); + } +} +/* * Add the passed pages to the LRU, then drop the caller's refcount * on them. Reinitialises the caller's pagevec.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 28/36 adapt to mm_counter in -mm
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
The interface changed slightly.
---
mm/huge_memory.c +3 -3
@@ -249,7 +249,7 @@ static int __do_huge_pmd_anonymous_page(page_add_new_anon_rmap (page, vma, haddr);set_pmd_at (mm, haddr, pmd, entry);prepare_pmd_huge_pte (pgtable, mm); -add_mm_counter (mm, anon_rss,HPAGE_PMD_NR ); +add_mm_counter (mm,MM_ANONPAGES ,HPAGE_PMD_NR );spin_unlock (&mm->page_table_lock); }
@@ -320,7 +320,7 @@ int copy_huge_pmd(struct mm_struct *dst_VM_BUG_ON (!PageHead (src_page));get_page (src_page);page_dup_rmap (src_page); -add_mm_counter (dst_mm, anon_rss,HPAGE_PMD_NR ); +add_mm_counter (dst_mm,MM_ANONPAGES ,HPAGE_PMD_NR );pmdp_set_wrprotect (src_mm, addr, src_pmd); pmd =pmd_mkold (pmd_wrprotect (pmd));
@@ -561,7 +561,7 @@ int zap_huge_pmd(struct mmu_gather *tlb,pmd_clear (pmd);page_remove_rmap (page);VM_BUG_ON (page_mapcount (page) <0 ); -add_mm_counter (tlb->mm, anon_rss, -HPAGE_PMD_NR ); +add_mm_counter (tlb->mm,MM_ANONPAGES , -HPAGE_PMD_NR );spin_unlock (&tlb->mm->page_table_lock);VM_BUG_ON (!PageHead (page));tlb_remove_page (tlb, page);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 28/36] adapt to mm_counter in -mm
Quoted 5 lines · On 02/21/2010 09:10 AM, [email protected] wrote:
From: Andrea Arcangeli<[email protected]>
The interface changed slightly.
Signed-off-by Andrea Arcangeli<[email protected]>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 29/36 page anon_vma
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Find the anon_vma to lock from the page rather than from the vma, after recent anon_vma changes that allows a vma to belong to more than a single anon_vma.
--- mm/huge_memory.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-)
mm/huge_memory.c +13 -11
@@ -761,13 +761,14 @@ static void __split_huge_page(struct pag struct anon_vma *anon_vma) {int mapcount, mapcount2; -struct vm_area_struct *vma; +struct anon_vma_chain *avc;BUG_ON (!PageHead (page));BUG_ON (PageTail (page)); mapcount =0 ; -list_for_each_entry (vma, &anon_vma->head, anon_vma_node) { +list_for_each_entry (avc, &anon_vma->head, same_anon_vma) { +struct vm_area_struct *vma = avc->vma;unsigned long addr =vma_address (page, vma);if (addr == -EFAULT )continue ;
@@ -778,7 +779,8 @@ static void __split_huge_page(struct pag__split_huge_page_refcount (page); mapcount2 =0 ; -list_for_each_entry (vma, &anon_vma->head, anon_vma_node) { +list_for_each_entry (avc, &anon_vma->head, same_anon_vma) { +struct vm_area_struct *vma = avc->vma;unsigned long addr =vma_address (page, vma);if (addr == -EFAULT )continue ;
@@ -791,29 +793,29 @@ static void __split_huge_page(struct pagvoid __split_huge_page_vma (struct vm_area_struct *vma,pmd_t *pmd) {struct page *page; -struct anon_vma *anon_vma;struct mm_struct *mm;BUG_ON (vma->vm_flags &VM_HUGETLB ); mm = vma->vm_mm; - anon_vma = vma->anon_vma; - -spin_lock (&anon_vma->lock); -BUG_ON (pmd_trans_splitting (*pmd));spin_lock (&mm->page_table_lock);if (unlikely (!pmd_trans_huge (*pmd))) {spin_unlock (&mm->page_table_lock); -spin_unlock (&anon_vma->lock);return ; } page =pmd_page (*pmd); +VM_BUG_ON (!page_count (page)); +get_page (page);spin_unlock (&mm->page_table_lock); -__split_huge_page (page, anon_vma); +/* +* The vma->anon_vma->lock is the wrong lock if the page is shared, +* the anon_vma->lock pointed by page->mapping is the right one. +*/ +split_huge_page (page); -spin_unlock (&anon_vma->lock); +put_page (page);BUG_ON (pmd_trans_huge (*pmd)); }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 29/36] page anon_vma
Quoted 6 lines · On 02/21/2010 09:10 AM, [email protected] wrote:
From: Andrea Arcangeli<[email protected]>
Find the
anon_vmato lock from the page rather than from the vma, after recentanon_vmachanges that allows a vma to belong to more than a singleanon_vma.Signed-off-by Andrea Arcangeli<[email protected]>
This could be folded into earlier patches, so bisectability is preserved.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 30/36 verify pmd_trans_huge isnt leaking
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
pte_trans_huge must not leak in certain vmas like the mmio special pfn or filebacked mappings.
---
mm/memory.c +6 -1
@@ -1333,6 +1333,7 @@ int __get_user_pages(struct task_struct pmd =pmd_offset (pud, pg);if (pmd_none (*pmd))return i ? : -EFAULT ; +VM_BUG_ON (pmd_trans_huge (*pmd)); pte =pte_offset_map (pmd, pg);if (pte_none (*pte)) {pte_unmap (pte);
@@ -1534,8 +1535,10 @@ pte_t *get_locked_pte(struct mm_struct *pud_t * pud =pud_alloc (mm, pgd, addr);if (pud) {pmd_t * pmd =pmd_alloc (mm, pud, addr); -if (pmd) +if (pmd) { +VM_BUG_ON (pmd_trans_huge (*pmd));return pte_alloc_map_lock (mm, pmd, addr, ptl); + } }return NULL ; }
@@ -1756,6 +1759,7 @@ static inline int remap_pmd_range(struct pmd =pmd_alloc (mm, pud, addr);if (!pmd)return -ENOMEM ; +VM_BUG_ON (pmd_trans_huge (*pmd)); do { next = pmd_addr_end(addr, end); if (remap_pte_range(mm, pmd, addr, next,
@@ -3221,6 +3225,7 @@ static int follow_pte(struct mm_struct * goto out; pmd =pmd_offset (pud, address); +VM_BUG_ON (pmd_trans_huge (*pmd));if (pmd_none (*pmd) ||unlikely (pmd_bad (*pmd))) goto out;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 30/36] verify pmd_trans_huge isnt leaking
Quoted 6 lines · On 02/21/2010 09:10 AM, [email protected] wrote:
From: Andrea Arcangeli<[email protected]>
pte_trans_hugemust not leak in certain vmas like the mmio special pfn or filebacked mappings.Signed-off-by Andrea Arcangeli<[email protected]>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 31/36 madvise(MADV_HUGEPAGE)
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Add madvise MADV_HUGEPAGE to mark regions that are important to be hugepage backed. Return -EINVAL if the vma is not of an anonymous type, or the feature isn't built into the kernel. Never silently return success.
---
include/linux/huge_mm.h +6 -0
@@ -103,6 +103,7 @@ extern int split_huge_page(struct page *#endif extern unsigned long vma_address (struct page *page,struct vm_area_struct *vma); +extern int hugepage_madvise (unsigned long *vm_flags);static inline int PageTransHuge (struct page *page) {VM_BUG_ON (PageTail (page));
@@ -127,6 +128,11 @@ static inline int split_huge_page(struct#define wait_split_huge_page (__anon_vma, __pmd) \ do { } while (0)#define PageTransHuge (page) 0 +static inline int hugepage_madvise (unsigned long *vm_flags) +{ +BUG_ON (0 ); +return 0 ; +}#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ #endif /* _LINUX_HUGE_MM_H */
mm/huge_memory.c +16 -0
@@ -854,3 +854,19 @@ out_unlock: out:return ret; } + +int hugepage_madvise (unsigned long *vm_flags) +{ +/* +* Be somewhat over-protective like KSM for now! +*/ +if (*vm_flags & (VM_HUGEPAGE |VM_SHARED |VM_MAYSHARE | +VM_PFNMAP |VM_IO |VM_DONTEXPAND | +VM_RESERVED |VM_HUGETLB |VM_INSERTPAGE | +VM_MIXEDMAP |VM_SAO )) +return -EINVAL ; + + *vm_flags |=VM_HUGEPAGE ; + +return 0 ; +}
mm/madvise.c +8 -0
@@ -71,6 +71,11 @@ static long madvise_behavior(struct vm_aif (error) goto out;break ; +case MADV_HUGEPAGE : + error =hugepage_madvise (&new_flags); +if (error) + goto out; +break ; }if (new_flags == vma->vm_flags) {
@@ -283,6 +288,9 @@ madvise_behavior_valid(int behavior)case MADV_MERGEABLE :case MADV_UNMERGEABLE :#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +case MADV_HUGEPAGE : +#endif return 1 ;default :
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 32/36 pmd_trans_huge migrate bugcheck
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
No pmd_trans_huge should ever materialize in migration ptes areas, because we split the hugepage before migration ptes are instantiated.
---
include/linux/huge_mm.h +5 -0
@@ -113,6 +113,10 @@ static inline int PageTransHuge(struct pVM_BUG_ON (PageTail (page)); return PageHead(page); } +static inline int PageTransCompound (struct page *page) +{ +return PageCompound (page); +}#else /* CONFIG_TRANSPARENT_HUGEPAGE */ #define HPAGE_PMD_SHIFT ({ BUG(); 0; })#define HPAGE_PMD_MASK ({ BUG(); 0; })
@@ -134,6 +138,7 @@ static inline int split_huge_page(struct#define wait_split_huge_page (__anon_vma, __pmd) \ do { } while (0)#define PageTransHuge (page) 0 +#define PageTransCompound (page) 0static inline int hugepage_madvise (unsigned long *vm_flags) {BUG_ON (0 );
mm/migrate.c +5 -0
@@ -99,6 +99,7 @@ static int remove_migration_pte(struct p goto out; pmd =pmd_offset (pud, addr); +VM_BUG_ON (pmd_trans_huge (*pmd));if (!pmd_present (*pmd)) goto out;
@@ -819,6 +820,10 @@ static int do_move_page_to_node_array(stif (PageReserved (page) ||PageKsm (page)) goto put_and_set; +if (unlikely (PageTransCompound (page))) +if (unlikely (split_huge_page (page))) + goto put_and_set; + pp->page = page; err =page_to_nid (page);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 33/36 memcg compound
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Teach memcg to charge/uncharge compound pages.
---
--- Documentation/cgroups/memory.txt | 4 + mm/memcontrol.c | 80 +++++++++++++++++++++++---------------- 2 files changed, 52 insertions(+), 32 deletions(-)
Documentation/cgroups/memory.txt +4 -0
@@ -4,6 +4,10 @@ NOTE: The Memory Resource Controller has to as the memory controller in this document. Do not confuse memory controller used here with the memory controller that is used in hardware. +NOTE: When in this documentation we refer to PAGE_SIZE, we actually +mean the real page size of the page being accounted which is bigger than +PAGE_SIZE for compound pages. + Salient features a. Enable control of Anonymous, Page Cache (mapped and unmapped) and
mm/memcontrol.c +48 -32
246 lines not on this page · raw message
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 34/36 memcg huge memory
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Add memcg charge/uncharge to hugepage faults in huge_memory.c.
---
mm/huge_memory.c +25 -5
@@ -224,6 +224,7 @@ static int __do_huge_pmd_anonymous_page(VM_BUG_ON (!PageCompound (page)); pgtable =pte_alloc_one (mm, haddr);if (unlikely (!pgtable)) { +mem_cgroup_uncharge_page (page);put_page (page);return VM_FAULT_OOM ; }
@@ -234,6 +235,7 @@ static int __do_huge_pmd_anonymous_page(spin_lock (&mm->page_table_lock);if (unlikely (!pmd_none (*pmd))) {spin_unlock (&mm->page_table_lock); +mem_cgroup_uncharge_page (page);put_page (page);pte_free (mm, pgtable); }else {
@@ -278,6 +280,10 @@ int do_huge_pmd_anonymous_page(struct mm page =alloc_hugepage ();if (unlikely (!page)) goto out; +if (unlikely (mem_cgroup_newpage_charge (page, mm,GFP_KERNEL ))) { +put_page (page); + goto out; + }return __do_huge_pmd_anonymous_page (mm, vma, haddr, pmd, page); }
@@ -377,9 +383,15 @@ static int do_huge_pmd_wp_page_fallback(for (i =0 ; i <HPAGE_PMD_NR ; i++) { pages[i] =alloc_page_vma (GFP_HIGHUSER_MOVABLE , vma, address); -if (unlikely (!pages[i])) { -while (--i >=0 ) +if (unlikely (!pages[i] || +mem_cgroup_newpage_charge (pages[i], mm, +GFP_KERNEL ))) { +if (pages[i])put_page (pages[i]); +while (--i >=0 ) { +mem_cgroup_uncharge_page (pages[i]); +put_page (pages[i]); + }kfree (pages); ret |=VM_FAULT_OOM ; goto out;
@@ -438,8 +450,10 @@ out: out_free_pages:spin_unlock (&mm->page_table_lock); -for (i =0 ; i <HPAGE_PMD_NR ; i++) +for (i =0 ; i <HPAGE_PMD_NR ; i++) { +mem_cgroup_uncharge_page (pages[i]);put_page (pages[i]); + }kfree (pages); goto out; }
@@ -481,13 +495,19 @@ int do_huge_pmd_wp_page(struct mm_struct goto out; } +if (unlikely (mem_cgroup_newpage_charge (new_page, mm,GFP_KERNEL ))) { +put_page (new_page); + ret |=VM_FAULT_OOM ; + goto out; + }copy_huge_page (new_page, page, haddr, vma,HPAGE_PMD_NR );__SetPageUptodate (new_page);spin_lock (&mm->page_table_lock); -if (unlikely (!pmd_same (*pmd, orig_pmd))) +if (unlikely (!pmd_same (*pmd, orig_pmd))) { +mem_cgroup_uncharge_page (new_page);put_page (new_page); -else { + }else {pmd_t entry; entry =mk_pmd (new_page, vma->vm_page_prot); entry =maybe_pmd_mkwrite (pmd_mkdirty (entry), vma);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 35/36 transparent hugepage vmstat
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Add hugepage stat information to /proc/vmstat and /proc/meminfo.
---
fs/proc/meminfo.c +7 -0
@@ -101,6 +101,9 @@ static int meminfo_proc_show(struct seq_#ifdef CONFIG_MEMORY_FAILURE "HardwareCorrupted: %5lu kB\n"#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +"AnonHugePages: %8lu kB\n" +#endif ,K (i.totalram), K(i.freeram),
@@ -151,6 +154,10 @@ static int meminfo_proc_show(struct seq_#ifdef CONFIG_MEMORY_FAILURE ,atomic_long_read(&mce_bad_pages) << (PAGE_SHIFT - 10)#endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + ,K(global_page_state(NR_ANON_TRANSPARENT_HUGEPAGES) * +HPAGE_PMD_NR ) +#endif );hugetlb_report_meminfo (m);
include/linux/mmzone.h +1 -0
@@ -112,6 +112,7 @@ enum zone_stat_item {NUMA_LOCAL ,/* allocation from local node */ NUMA_OTHER ,/* allocation from other node */ #endif +NR_ANON_TRANSPARENT_HUGEPAGES , NR_VM_ZONE_STAT_ITEMS };/*
mm/huge_memory.c +3 -0
@@ -723,6 +723,9 @@ static void __split_huge_page_refcount(sput_page (page_tail); } +__dec_zone_page_state (page,NR_ANON_TRANSPARENT_HUGEPAGES ); +__mod_zone_page_state (zone,NR_ANON_PAGES ,HPAGE_PMD_NR ); +ClearPageCompound (page);compound_unlock (page);spin_unlock_irq (&zone->lru_lock);
mm/rmap.c +16 -4
@@ -687,8 +687,13 @@ void page_add_anon_rmap(struct page *pag struct vm_area_struct *vma, unsigned long address) { int first = atomic_inc_and_test(&page->_mapcount); -if (first) -__inc_zone_page_state (page,NR_ANON_PAGES ); +if (first) { +if (!PageTransHuge (page)) +__inc_zone_page_state (page,NR_ANON_PAGES ); +else +__inc_zone_page_state (page, +NR_ANON_TRANSPARENT_HUGEPAGES ); + }if (unlikely (PageKsm (page)))return ;
@@ -716,7 +721,10 @@ void page_add_new_anon_rmap(struct pageVM_BUG_ON (address < vma->vm_start || address >= vma->vm_end);SetPageSwapBacked (page);atomic_set (&page->_mapcount,0 );/* increment count (starts at -1) */ -__inc_zone_page_state (page,NR_ANON_PAGES ); +if (!PageTransHuge (page)) +__inc_zone_page_state (page,NR_ANON_PAGES ); +else +__inc_zone_page_state (page,NR_ANON_TRANSPARENT_HUGEPAGES );__page_set_anon_rmap (page, vma, address);if (page_evictable (page, vma))lru_cache_add_lru (page,LRU_ACTIVE_ANON );
@@ -763,7 +771,11 @@ void page_remove_rmap(struct page *page) }if (PageAnon (page)) {mem_cgroup_uncharge_page (page); -__dec_zone_page_state (page,NR_ANON_PAGES ); +if (!PageTransHuge (page)) +__dec_zone_page_state (page,NR_ANON_PAGES ); +else +__dec_zone_page_state (page, +NR_ANON_TRANSPARENT_HUGEPAGES ); }else {__dec_zone_page_state (page,NR_FILE_MAPPED );mem_cgroup_update_file_mapped (page,-1 );
mm/vmstat.c +3 -0
@@ -655,6 +655,9 @@ static const char * const vmstat_text[]"numa_local" ,"numa_other" , #endif +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +"nr_anon_transparent_hugepages" , +#endif #ifdef CONFIG_VM_EVENT_COUNTERS "pgpgin",
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
PATCH 36/36 khugepaged
In reply to [email protected]From: Andrea Arcangeli <[email protected]>
Add khugepaged to relocate fragmented pages into hugepages if new hugepages become available. (this is indipendent of the defrag logic that will have to make new hugepages available)
---
--- include/linux/huge_mm.h | 2 include/linux/khugepaged.h | 32 + include/linux/sched.h | 1 kernel/fork.c | 5 mm/huge_memory.c | 981 ++++++++++++++++++++++++++++++++++++++++++++- 5 files changed, 1014 insertions(+), 7 deletions(-)
include/linux/huge_mm.h +2 -0
@@ -23,6 +23,8 @@ extern int zap_huge_pmd(struct mmu_gatheenum transparent_hugepage_flag {TRANSPARENT_HUGEPAGE_FLAG ,TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG , +TRANSPARENT_HUGEPAGE_KHUGEPAGED_FLAG , +TRANSPARENT_HUGEPAGE_KHUGEPAGED_REQ_MADV_FLAG ,TRANSPARENT_HUGEPAGE_DEFRAG_FLAG ,#ifdef CONFIG_DEBUG_VM TRANSPARENT_HUGEPAGE_DEBUG_COW_FLAG ,
include/linux/khugepaged.h new file +32 -0
@@ -0,0 +1,32 @@ +#ifndef _LINUX_KHUGEPAGED_H +#define _LINUX_KHUGEPAGED_H + +#include <linux/sched.h> /* MMF_VM_HUGEPAGE */ + +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +extern int __khugepaged_enter (struct mm_struct *mm); +extern void __khugepaged_exit (struct mm_struct *mm); + +static inline int khugepaged_fork (struct mm_struct *mm,struct mm_struct *oldmm) +{ +if (test_bit (MMF_VM_HUGEPAGE , &oldmm->flags)) +return __khugepaged_enter (mm); +return 0 ; +} + +static inline void khugepaged_exit (struct mm_struct *mm) +{ +if (test_bit (MMF_VM_HUGEPAGE , &mm->flags)) +__khugepaged_exit (mm); +} +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +static inline int khugepaged_fork (struct mm_struct *mm,struct mm_struct *oldmm) +{ +return 0 ; +} +static inline void khugepaged_exit (struct mm_struct *mm) +{ +} +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ + +#endif /* _LINUX_KHUGEPAGED_H */
include/linux/sched.h +1 -0
@@ -432,6 +432,7 @@ extern int get_dumpable(struct mm_struct#endif /* leave room for more dump flags */ #define MMF_VM_MERGEABLE 16/* KSM may merge identical pages */ +#define MMF_VM_HUGEPAGE 17/* set when VM_HUGEPAGE is set on vma */ #define MMF_INIT_MASK (MMF_DUMPABLE_MASK | MMF_DUMP_FILTER_MASK)
kernel/fork.c +5 -0
@@ -65,6 +65,7 @@#include <linux/perf_event.h> #include <linux/posix-timers.h> #include <linux/user-return-notifier.h> +#include <linux/khugepaged.h> #include <asm/pgtable.h> #include <asm/pgalloc.h>
@@ -307,6 +308,9 @@ static int dup_mmap(struct mm_struct *mm retval =ksm_fork (mm, oldmm);if (retval) goto out; + retval =khugepaged_fork (mm, oldmm); +if (retval) + goto out;for (mpnt = oldmm->mmap; mpnt; mpnt = mpnt->vm_next) {struct file *file;
@@ -519,6 +523,7 @@ void mmput(struct mm_struct *mm)if (atomic_dec_and_test (&mm->mm_users)) {exit_aio (mm);ksm_exit (mm); +khugepaged_exit (mm);/* must run before exit_mmap */ exit_mmap (mm);set_mm_exe_file (mm,NULL );if (!list_empty (&mm->mmlist)) {
mm/huge_memory.c +974 -7
1,023 lines not on this page · raw message
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 36/36] khugepaged
Quoted 768 lines · On Sun, 21 Feb 2010 15:10:45 +0100 [email protected] wrote:
From: Andrea Arcangeli <[email protected]>
Add khugepaged to relocate fragmented pages into hugepages if new hugepages become available. (this is indipendent of the defrag logic that will have to make new hugepages available)
Signed-off-by Andrea Arcangeli <[email protected]>Acked-by Rik van Riel <[email protected]>---
--- include/linux/huge_mm.h | 2 include/linux/khugepaged.h | 32 + include/linux/sched.h | 1 kernel/fork.c | 5 mm/huge_memory.c | 981 ++++++++++++++++++++++++++++++++++++++++++++- 5 files changed, 1014 insertions(+), 7 deletions(-)include/linux/huge_mm.h +2
-0@@ -23,6 +23,8 @@ extern int zap_huge_pmd(struct mmu_gatheenum transparent_hugepage_flag {TRANSPARENT_HUGEPAGE_FLAG ,TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG , +TRANSPARENT_HUGEPAGE_KHUGEPAGED_FLAG , +TRANSPARENT_HUGEPAGE_KHUGEPAGED_REQ_MADV_FLAG ,TRANSPARENT_HUGEPAGE_DEFRAG_FLAG ,#ifdef CONFIG_DEBUG_VM TRANSPARENT_HUGEPAGE_DEBUG_COW_FLAG ,include/linux/khugepaged.h new file +32
-0@@ -0,0 +1,32 @@ +#ifndef _LINUX_KHUGEPAGED_H +#define _LINUX_KHUGEPAGED_H + +#include <linux/sched.h> /* MMF_VM_HUGEPAGE */ + +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +extern int __khugepaged_enter (struct mm_struct *mm); +extern void __khugepaged_exit (struct mm_struct *mm); + +static inline int khugepaged_fork (struct mm_struct *mm,struct mm_struct *oldmm) +{ +if (test_bit (MMF_VM_HUGEPAGE , &oldmm->flags)) +return __khugepaged_enter (mm); +return 0 ; +} + +static inline void khugepaged_exit (struct mm_struct *mm) +{ +if (test_bit (MMF_VM_HUGEPAGE , &mm->flags)) +__khugepaged_exit (mm); +} +#else /* CONFIG_TRANSPARENT_HUGEPAGE */ +static inline int khugepaged_fork (struct mm_struct *mm,struct mm_struct *oldmm) +{ +return 0 ; +} +static inline void khugepaged_exit (struct mm_struct *mm) +{ +} +#endif /* CONFIG_TRANSPARENT_HUGEPAGE */ + +#endif /* _LINUX_KHUGEPAGED_H */ include/linux/sched.h +1
-0@@ -432,6 +432,7 @@ extern int get_dumpable(struct mm_struct#endif /* leave room for more dump flags */ #define MMF_VM_MERGEABLE 16/* KSM may merge identical pages */ +#define MMF_VM_HUGEPAGE 17/* set when VM_HUGEPAGE is set on vma */ #define MMF_INIT_MASK (MMF_DUMPABLE_MASK | MMF_DUMP_FILTER_MASK)kernel/fork.c +5
-0@@ -65,6 +65,7 @@#include <linux/perf_event.h> #include <linux/posix-timers.h> #include <linux/user-return-notifier.h> +#include <linux/khugepaged.h> #include <asm/pgtable.h> #include <asm/pgalloc.h> @@ -307,6 +308,9 @@ static int dup_mmap(struct mm_struct *mm retval =ksm_fork (mm, oldmm);if (retval) goto out; + retval =khugepaged_fork (mm, oldmm); +if (retval) + goto out;for (mpnt = oldmm->mmap; mpnt; mpnt = mpnt->vm_next) {struct file *file;@@ -519,6 +523,7 @@ void mmput(struct mm_struct *mm)if (atomic_dec_and_test (&mm->mm_users)) {exit_aio (mm);ksm_exit (mm); +khugepaged_exit (mm);/* must run before exit_mmap */ exit_mmap (mm);set_mm_exe_file (mm,NULL );if (!list_empty (&mm->mmlist)) {mm/huge_memory.c +610
-7@@ -12,14 +12,121 @@#include <linux/mmu_notifier.h> #include <linux/rmap.h> #include <linux/swap.h> +#include <linux/mm_inline.h> +#include <linux/kthread.h> +#include <linux/khugepaged.h> #include <asm/tlb.h> #include <asm/pgalloc.h> #include "internal.h" unsigned long transparent_hugepage_flags__read_mostly = - (1 <<TRANSPARENT_HUGEPAGE_FLAG ); + (1 <<TRANSPARENT_HUGEPAGE_FLAG )| + (1 <<TRANSPARENT_HUGEPAGE_KHUGEPAGED_FLAG ); + +/* default scan 8*512 pte (or vmas) every 30 second */ +static unsigned int khugepaged_pages_to_scan__read_mostly =HPAGE_PMD_NR *8 ; +static unsigned int khugepaged_pages_collapsed; +static unsigned int khugepaged_full_scans; +static unsigned int khugepaged_scan_sleep_millisecs__read_mostly =10000 ; +/* during fragmentation poll the hugepage allocator once every minute */ +static unsigned int khugepaged_alloc_sleep_millisecs__read_mostly =60000 ; +static struct task_struct *khugepaged_thread__read_mostly ; +static DEFINE_MUTEX (khugepaged_mutex); +static DEFINE_SPINLOCK (khugepaged_mm_lock); +static DECLARE_WAIT_QUEUE_HEAD (khugepaged_wait); + +static int khugepaged (void *none); +static int mm_slots_hash_init (void ); +static int khugepaged_slab_init (void ); +static void khugepaged_slab_free (void ); + +#define MM_SLOTS_HASH_HEADS 1024 +static struct hlist_head *mm_slots_hash__read_mostly ; +static struct kmem_cache *mm_slot_cache__read_mostly ; + +/** +* struct mm_slot - hash lookup from mm to mm_slot +* @hash: hash collision list +* @mm_node: khugepaged scan list headed in khugepaged_scan.mm_head +* @mm: the mm that this information is valid for +*/ +struct mm_slot { +struct hlist_node hash; +struct list_head mm_node; +struct mm_struct *mm; +}; + +/** +* struct khugepaged_scan - cursor for scanning +* @mm_head: the head of the mm list to scan +* @mm_slot: the current mm_slot we are scanning +* @address: the next address inside that to be scanned +* +* There is only the one khugepaged_scan instance of this cursor structure. +*/ +struct khugepaged_scan { +struct list_head mm_head; +struct mm_slot *mm_slot; +unsigned long address; +} khugepaged_scan = { + .mm_head =LIST_HEAD_INIT (khugepaged_scan.mm_head), +}; + +#define khugepaged_enabled () \ + (transparent_hugepage_flags & \ + ((1<<TRANSPARENT_HUGEPAGE_KHUGEPAGED_FLAG) | \ + (1<<TRANSPARENT_HUGEPAGE_KHUGEPAGED_REQ_MADV_FLAG))) +#define khugepaged_always () \ + (transparent_hugepage_flags & \ + (1<<TRANSPARENT_HUGEPAGE_KHUGEPAGED_FLAG)) +#define khugepaged_req_madv () \ + (transparent_hugepage_flags & \ + (1<<TRANSPARENT_HUGEPAGE_KHUGEPAGED_REQ_MADV_FLAG)) + +static int start_khugepaged (void ) +{ +int err =0 ; +if (khugepaged_enabled ()) { +int wakeup; +if (unlikely (!mm_slot_cache || !mm_slots_hash)) { + err = -ENOMEM ; + goto out; + } +mutex_lock (&khugepaged_mutex); +if (!khugepaged_thread) + khugepaged_thread =kthread_run (khugepaged,NULL , +"khugepaged" ); +if (unlikely (IS_ERR (khugepaged_thread))) { +clear_bit (TRANSPARENT_HUGEPAGE_KHUGEPAGED_FLAG , + &transparent_hugepage_flags); +clear_bit (TRANSPARENT_HUGEPAGE_KHUGEPAGED_REQ_MADV_FLAG , + &transparent_hugepage_flags); +printk (KERN_ERR +"khugepaged: kthread_run(khugepaged) failed\n" ); + err =PTR_ERR (khugepaged_thread); + khugepaged_thread =NULL ; + } + wakeup = !list_empty (&khugepaged_scan.mm_head); +mutex_unlock (&khugepaged_mutex); +if (wakeup) +wake_up_interruptible (&khugepaged_wait); + }else +/* wakeup to exit */ +wake_up_interruptible (&khugepaged_wait); +out: +return err; +}#ifdef CONFIG_SYSFS + +static void wakeup_khugepaged (void ) +{ +mutex_lock (&khugepaged_mutex); +if (khugepaged_thread) +wake_up_process (khugepaged_thread); +mutex_unlock (&khugepaged_mutex); +} + static ssize_t double_flag_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf, enum transparent_hugepage_flag enabled,@@ -151,20 +258,188 @@ static struct attribute *hugepage_attr[]static struct attribute_group hugepage_attr_group = { .attrs = hugepage_attr, - .name ="transparent_hugepage" , +}; + +static ssize_t scan_sleep_millisecs_show (struct kobject *kobj, +struct kobj_attribute *attr, +char *buf) +{ +return sprintf (buf,"%u\n" , khugepaged_scan_sleep_millisecs); +} + +static ssize_t scan_sleep_millisecs_store (struct kobject *kobj, +struct kobj_attribute *attr, +const char *buf,size_t count) +{ +unsigned long msecs; +int err; + + err =strict_strtoul (buf,10 , &msecs); +if (err || msecs >UINT_MAX ) +return -EINVAL ; + + khugepaged_scan_sleep_millisecs = msecs; +wakeup_khugepaged (); + +return count; +} +static struct kobj_attribute scan_sleep_millisecs_attr = +__ATTR (scan_sleep_millisecs,0644 , scan_sleep_millisecs_show, + scan_sleep_millisecs_store); + +static ssize_t alloc_sleep_millisecs_show (struct kobject *kobj, +struct kobj_attribute *attr, +char *buf) +{ +return sprintf (buf,"%u\n" , khugepaged_alloc_sleep_millisecs); +} + +static ssize_t alloc_sleep_millisecs_store (struct kobject *kobj, +struct kobj_attribute *attr, +const char *buf,size_t count) +{ +unsigned long msecs; +int err; + + err =strict_strtoul (buf,10 , &msecs); +if (err || msecs >UINT_MAX ) +return -EINVAL ; + + khugepaged_alloc_sleep_millisecs = msecs; +wakeup_khugepaged (); + +return count; +} +static struct kobj_attribute alloc_sleep_millisecs_attr = +__ATTR (alloc_sleep_millisecs,0644 , alloc_sleep_millisecs_show, + alloc_sleep_millisecs_store); + +static ssize_t pages_to_scan_show (struct kobject *kobj, +struct kobj_attribute *attr, +char *buf) +{ +return sprintf (buf,"%u\n" , khugepaged_pages_to_scan); +} +static ssize_t pages_to_scan_store (struct kobject *kobj, +struct kobj_attribute *attr, +const char *buf,size_t count) +{ +int err; +unsigned long pages; + + err =strict_strtoul (buf,10 , &pages); +if (err || !pages || pages >UINT_MAX ) +return -EINVAL ; + + khugepaged_pages_to_scan = pages; + +return count; +} +static struct kobj_attribute pages_to_scan_attr = +__ATTR (pages_to_scan,0644 , pages_to_scan_show, + pages_to_scan_store); + +static ssize_t pages_collapsed_show (struct kobject *kobj, +struct kobj_attribute *attr, +char *buf) +{ +return sprintf (buf,"%u\n" , khugepaged_pages_collapsed); +} +static struct kobj_attribute pages_collapsed_attr = +__ATTR_RO (pages_collapsed); + +static ssize_t full_scans_show (struct kobject *kobj, +struct kobj_attribute *attr, +char *buf) +{ +return sprintf (buf,"%u\n" , khugepaged_full_scans); +} +static struct kobj_attribute full_scans_attr = +__ATTR_RO (full_scans); + +static ssize_t khugepaged_enabled_show (struct kobject *kobj, +struct kobj_attribute *attr,char *buf) +{ +return double_flag_show (kobj, attr, buf, +TRANSPARENT_HUGEPAGE_KHUGEPAGED_FLAG , +TRANSPARENT_HUGEPAGE_KHUGEPAGED_REQ_MADV_FLAG ); +} +static ssize_t khugepaged_enabled_store (struct kobject *kobj, +struct kobj_attribute *attr, +const char *buf,size_t count) +{ +ssize_t ret; + + ret =double_flag_store (kobj, attr, buf, count, +TRANSPARENT_HUGEPAGE_KHUGEPAGED_FLAG , +TRANSPARENT_HUGEPAGE_KHUGEPAGED_REQ_MADV_FLAG ); +if (ret >0 ) { +int err =start_khugepaged (); +if (err) + ret = err; + } +return ret; +} +static struct kobj_attribute khugepaged_enabled_attr = +__ATTR (enabled,0644 , khugepaged_enabled_show, + khugepaged_enabled_store); + +static struct attribute *khugepaged_attr[] = { + &khugepaged_enabled_attr.attr, + &pages_to_scan_attr.attr, + &pages_collapsed_attr.attr, + &full_scans_attr.attr, + &scan_sleep_millisecs_attr.attr, + &alloc_sleep_millisecs_attr.attr, +NULL , +}; + +static struct attribute_group khugepaged_attr_group = { + .attrs = khugepaged_attr, + .name ="khugepaged" , };#endif /* CONFIG_SYSFS */ static int __init hugepage_init (void ) { -#ifdef CONFIG_SYSFS int err; +#ifdef CONFIG_SYSFS +static struct kobject *hugepage_kobj; - err =sysfs_create_group (mm_kobj, &hugepage_attr_group); -if (err) -printk (KERN_ERR "hugepage: register sysfs failed\n" ); + err = -ENOMEM ; + hugepage_kobj =kobject_create_and_add ("transparent_hugepage" , mm_kobj); +if (unlikely (!hugepage_kobj)) { +printk (KERN_ERR "hugepage: failed kobject create\n" ); + goto out; + } + + err =sysfs_create_group (hugepage_kobj, &hugepage_attr_group); +if (err) { +printk (KERN_ERR "hugepage: failed register hugeage group\n" ); + goto out; + } + + err =sysfs_create_group (hugepage_kobj, &khugepaged_attr_group); +if (err) { +printk (KERN_ERR "hugepage: failed register hugeage group\n" ); + goto out; + }#endif -return 0 ; + + err =khugepaged_slab_init (); +if (err) + goto out; + + err =mm_slots_hash_init (); +if (err) { +khugepaged_slab_free (); + goto out; + } + +start_khugepaged (); + +out: +return err; }module_init (hugepage_init)@@ -181,6 +456,15 @@ static int __init setup_transparent_huge transparent_hugepage_flags); transparent_hugepage_flags =0 ; } +if (test_bit (TRANSPARENT_HUGEPAGE_KHUGEPAGED_FLAG , + &transparent_hugepage_flags) && +test_bit (TRANSPARENT_HUGEPAGE_KHUGEPAGED_REQ_MADV_FLAG , + &transparent_hugepage_flags)) { +printk (KERN_WARNING +"transparent_hugepage=%lu invalid parameter, disabling" , + transparent_hugepage_flags); + transparent_hugepage_flags =0 ; + }return 1 ; }__setup ("transparent_hugepage=" , setup_transparent_hugepage);@@ -276,6 +560,12 @@ int do_huge_pmd_anonymous_page(struct mmif (haddr >= vma->vm_start && haddr +HPAGE_PMD_SIZE <= vma->vm_end) {if (unlikely (anon_vma_prepare (vma)))return VM_FAULT_OOM ; +if (unlikely (!test_bit (MMF_VM_HUGEPAGE , &mm->flags))) +if (khugepaged_always () || + (khugepaged_req_madv () && + vma->vm_flags &VM_HUGEPAGE )) +if (__khugepaged_enter (mm)) +return VM_FAULT_OOM ; page =alloc_hugepage ();if (unlikely (!page)) goto out;@@ -894,3 +1184,680 @@ int hugepage_madvise(unsigned long *vm_freturn 0 ; } + +static int __init khugepaged_slab_init (void ) +{ + mm_slot_cache =kmem_cache_create ("khugepaged_mm_slot" , +sizeof (struct mm_slot ), + __alignof__(struct mm_slot ),0 ,NULL ); +if (!mm_slot_cache) +return -ENOMEM ; + +return 0 ; +} + +static void __init khugepaged_slab_free (void ) +{ +kmem_cache_destroy (mm_slot_cache); + mm_slot_cache =NULL ; +} + +static inline struct mm_slot *alloc_mm_slot (void ) +{ +if (!mm_slot_cache)/* initialization failed */ +return NULL ; +return kmem_cache_zalloc (mm_slot_cache,GFP_KERNEL ); +} + +static inline void free_mm_slot (struct mm_slot *mm_slot) +{ +kmem_cache_free (mm_slot_cache, mm_slot); +} + +static int __init mm_slots_hash_init (void ) +{ + mm_slots_hash =kzalloc (MM_SLOTS_HASH_HEADS *sizeof (struct hlist_head ), +GFP_KERNEL ); +if (!mm_slots_hash) +return -ENOMEM ; +return 0 ; +} + +#if 0 +static void __init mm_slots_hash_free (void ) +{ +kfree (mm_slots_hash); + mm_slots_hash =NULL ; +} +#endif + +static struct mm_slot *get_mm_slot (struct mm_struct *mm) +{ +struct mm_slot *mm_slot; +struct hlist_head *bucket; +struct hlist_node *node; + + bucket = &mm_slots_hash[((unsigned long )mm /sizeof (struct mm_struct )) + %MM_SLOTS_HASH_HEADS ]; +hlist_for_each_entry (mm_slot, node, bucket, hash) { +if (mm == mm_slot->mm) +return mm_slot; + } +return NULL ; +} + +static void insert_to_mm_slots_hash (struct mm_struct *mm, +struct mm_slot *mm_slot) +{ +struct hlist_head *bucket; + + bucket = &mm_slots_hash[((unsigned long )mm /sizeof (struct mm_struct )) + %MM_SLOTS_HASH_HEADS ]; + mm_slot->mm = mm; +hlist_add_head (&mm_slot->hash, bucket); +} + +int __khugepaged_enter (struct mm_struct *mm) +{ +struct mm_slot *mm_slot; +int wakeup; + + mm_slot =alloc_mm_slot (); +if (!mm_slot) +return -ENOMEM ; + +spin_lock (&khugepaged_mm_lock); +insert_to_mm_slots_hash (mm, mm_slot); +/* +* Insert just behind the scanning cursor, to let the area settle +* down a little. +*/ + wakeup =list_empty (&khugepaged_scan.mm_head); +list_add_tail (&mm_slot->mm_node, &khugepaged_scan.mm_head); +set_bit (MMF_VM_HUGEPAGE , &mm->flags); +spin_unlock (&khugepaged_mm_lock); + +atomic_inc (&mm->mm_count); +if (wakeup) +wake_up_interruptible (&khugepaged_wait); + +return 0 ; +} + +void __khugepaged_exit (struct mm_struct *mm) +{ +struct mm_slot *mm_slot; +int free =0 ; + +spin_lock (&khugepaged_mm_lock); + mm_slot =get_mm_slot (mm); +if (mm_slot && khugepaged_scan.mm_slot != mm_slot) { +hlist_del (&mm_slot->hash); +list_del (&mm_slot->mm_node); + free =1 ; + } + +if (free) { +clear_bit (MMF_VM_HUGEPAGE , &mm->flags); +spin_unlock (&khugepaged_mm_lock); +free_mm_slot (mm_slot); +mmdrop (mm); + }else if (mm_slot) { +spin_unlock (&khugepaged_mm_lock); +/* +* This is required to serialize against +* khugepaged_test_exit() (which is guaranteed to run +* under mmap sem read mode). Stop here (after we +* return all pagetables will be destroyed) until +* khugepaged has finished working on the pagetables +* under the mmap_sem. +*/ +down_write (&mm->mmap_sem); +up_write (&mm->mmap_sem); + }else +spin_unlock (&khugepaged_mm_lock); +} + +static inline int khugepaged_test_exit (struct mm_struct *mm) +{ +return atomic_read (&mm->mm_users) ==0 ; +} + +static void release_pte_page (struct page *page) +{ +/* 0 stands for page_is_file_cache(page) == false */ +dec_zone_page_state (page,NR_ISOLATED_ANON +0 ); +unlock_page (page); +putback_lru_page (page); +} + +static void release_pte_pages (pte_t *pte,pte_t *_pte) +{ +while (--_pte >= pte) +release_pte_page (pte_page (*_pte)); +} + +static void release_all_pte_pages (pte_t *pte) +{ +release_pte_pages (pte, pte +HPAGE_PMD_NR ); +} + +static int __collapse_huge_page_isolate (struct vm_area_struct *vma, +unsigned long address, +pte_t *pte) +{ +struct page *page; +pte_t *_pte; +int referenced =0 , isolated =0 ; +for (_pte = pte; _pte < pte+HPAGE_PMD_NR ; + _pte++, address +=PAGE_SIZE ) { +pte_t pteval = *_pte; +if (!pte_present (pteval) || !pte_write (pteval)) { +release_pte_pages (pte, _pte); + goto out; + } +/* If there is no mapped pte young don't collapse the page */ +if (pte_young (pteval)) + referenced =1 ; + page =vm_normal_page (vma, address, pteval); +if (unlikely (!page)) { +release_pte_pages (pte, _pte); + goto out; + } +VM_BUG_ON (PageCompound (page)); +BUG_ON (!PageAnon (page)); +VM_BUG_ON (!PageSwapBacked (page)); + +/* cannot use mapcount: can't collapse if there's a gup pin */ +if (page_count (page) !=1 ) { +release_pte_pages (pte, _pte); + goto out; + } +/* +* We can do it before isolate_lru_page because the +* page can't be freed from under us. NOTE: PG_lock +* is needed to serialize against split_huge_page +* when invoked from the VM. +*/ +if (!trylock_page (page)) { +release_pte_pages (pte, _pte); + goto out; + } +/* +* Isolate the page to avoid collapsing an hugepage +* currently in use by the VM. +*/ +if (isolate_lru_page (page)) { +unlock_page (page); +release_pte_pages (pte, _pte); + goto out; + } +/* 0 stands for page_is_file_cache(page) == false */ +inc_zone_page_state (page,NR_ISOLATED_ANON +0 ); +VM_BUG_ON (!PageLocked (page)); +VM_BUG_ON (PageLRU (page)); + } +if (unlikely (!referenced)) +release_all_pte_pages (pte); +else + isolated =1 ; +out: +return isolated; +} + +static void __collapse_huge_page_copy (pte_t *pte,struct page *page, +struct vm_area_struct *vma, +unsigned long address, +spinlock_t *ptl) +{ +pte_t *_pte; +for (_pte = pte; _pte < pte+HPAGE_PMD_NR ; _pte++) { +struct page *src_page =pte_page (*_pte); +copy_user_highpage (page, src_page, address, vma); +VM_BUG_ON (page_mapcount (src_page) !=1 ); +VM_BUG_ON (page_count (src_page) !=2 ); +release_pte_page (src_page); +/* +* ptl mostly unnecessary, but preempt has to be disabled +* to update the per-cpu stats inside page_remove_rmap(). +*/ +spin_lock (ptl); +/* paravirt calls inside pte_clear here are superfluous */ +pte_clear (vma->vm_mm, address, _pte); +page_remove_rmap (src_page); +spin_unlock (ptl); +free_page_and_swap_cache (src_page); + + address +=PAGE_SIZE ; + page++; + } +} + +static void collapse_huge_page (struct mm_struct *mm, +unsigned long address, +struct page **hpage) +{ +struct vm_area_struct *vma; +pgd_t *pgd; +pud_t *pud; +pmd_t *pmd, _pmd; +pte_t *pte; +pgtable_t pgtable; +struct page *new_page; +spinlock_t *ptl; +int isolated; +unsigned long hstart, hend; + +VM_BUG_ON (address & ~HPAGE_PMD_MASK ); +VM_BUG_ON (!*hpage); + +/* +* Prevent all access to pagetables with the exception of +* gup_fast later hanlded by the ptep_clear_flush and the VM +* handled by the anon_vma lock + PG_lock. +*/ +down_write (&mm->mmap_sem); +if (unlikely (khugepaged_test_exit (mm))) + goto out; + + vma =find_vma (mm, address); + hstart = (vma->vm_start + ~HPAGE_PMD_MASK ) &HPAGE_PMD_MASK ; + hend = vma->vm_end &HPAGE_PMD_MASK ; +if (address < hstart || address +HPAGE_PMD_SIZE > hend) + goto out; + +if (!(vma->vm_flags &VM_HUGEPAGE ) && !khugepaged_always ()) + goto out; + +/* VM_PFNMAP vmas may have vm_ops null but vm_file set */ +if (!vma->anon_vma || vma->vm_ops || vma->vm_file) + goto out; +VM_BUG_ON (is_linear_pfn_mapping (vma) ||is_pfn_mapping (vma)); + + pgd =pgd_offset (mm, address); +if (!pgd_present (*pgd)) + goto out; + + pud =pud_offset (pgd, address); +if (!pud_present (*pud)) + goto out; + + pmd =pmd_offset (pud, address); +/* pmd can't go away or become huge under us */ +if (!pmd_present (*pmd) ||pmd_trans_huge (*pmd)) + goto out; + +/* +* Stop anon_vma rmap pagetable access. vma->anon_vma->lock is +* enough for now (we don't need to check each anon_vma +* pointed by each page->mapping) because collapse_huge_page +* only works on not-shared anon pages (that are guaranteed to +* belong to vma->anon_vma). +*/ +spin_lock (&vma->anon_vma->lock); + + pte =pte_offset_map (pmd, address);
mm/huge_memory.c int hugepage_madvise(unsigned long *vm_f · line 1509
Quoted 10 lines
mm/huge_memory.c +10
-0+ ptl =pte_lockptr (mm, pmd); + +spin_lock (&mm->page_table_lock);/* probably unnecessary */ +/* after this gup_fast can't run anymore */ + _pmd =pmdp_clear_flush_notify (vma, address, pmd); +spin_unlock (&mm->page_table_lock); + +spin_lock (ptl); + isolated =__collapse_huge_page_isolate (vma, address, pte); +spin_unlock (ptl);
Is it safe to take zone->lock under pte_lock and anon_vma->lock ?
I think usual way is
page = follow_page(FOLL_GET)
isolate_page(page)
Quoted 8 lines
mm/huge_memory.c +8
-0+pte_unmap (pte); + +if (unlikely (!isolated)) { +spin_lock (&mm->page_table_lock); +BUG_ON (!pmd_none (*pmd)); +set_pmd_at (mm, address, pmd, _pmd); +spin_unlock (&mm->page_table_lock); +spin_unlock (&vma->anon_vma->lock);
mm/huge_memory.c int hugepage_madvise(unsigned long *vm_f · line 1527
Quoted 10 lines
mm/huge_memory.c +10
-0+ goto out; + } + +/* +* All pages are isolated and locked so anon_vma rmap +* can't run anymore. +*/ +spin_unlock (&vma->anon_vma->lock); + + new_page = *hpage;
I'm not sure but....where this *hpage is chareged to proper memcg ? I think it's good to charge this newpage in the top of this function. (And cancel it at failure, of course.)
Thanks,
-Kame
Quoted 338 lines
mm/huge_memory.c +336
-1+__collapse_huge_page_copy (pte, new_page, vma, address, ptl); +__SetPageUptodate (new_page); + pgtable =pmd_pgtable (_pmd); +VM_BUG_ON (page_count (pgtable) !=1 ); +VM_BUG_ON (page_mapcount (pgtable) !=0 ); + + _pmd =mk_pmd (new_page, vma->vm_page_prot); + _pmd =maybe_pmd_mkwrite (pmd_mkdirty (_pmd), vma); + _pmd =pmd_mkhuge (_pmd); + +/* +* spin_lock() below is not the equivalent of smp_wmb(), so +* this is needed to avoid the copy_huge_page writes to become +* visible after the set_pmd_at() write. +*/ +smp_wmb (); + +spin_lock (&mm->page_table_lock); +BUG_ON (!pmd_none (*pmd)); +page_add_new_anon_rmap (new_page, vma, address); +set_pmd_at (mm, address, pmd, _pmd); +update_mmu_cache (vma, address, entry); +prepare_pmd_huge_pte (pgtable, mm); + mm->nr_ptes--; +spin_unlock (&mm->page_table_lock); + + *hpage =NULL ; + khugepaged_pages_collapsed++; +out: +up_write (&mm->mmap_sem); +} + +static int khugepaged_scan_pmd (struct mm_struct *mm, +struct vm_area_struct *vma, +unsigned long address, +struct page **hpage) +{ +pgd_t *pgd; +pud_t *pud; +pmd_t *pmd; +pte_t *pte, *_pte; +int ret =0 , referenced =0 ; +struct page *page; +unsigned long _address; +spinlock_t *ptl; + +VM_BUG_ON (address & ~HPAGE_PMD_MASK ); + + pgd =pgd_offset (mm, address); +if (!pgd_present (*pgd)) + goto out; + + pud =pud_offset (pgd, address); +if (!pud_present (*pud)) + goto out; + + pmd =pmd_offset (pud, address); +if (!pmd_present (*pmd) ||pmd_trans_huge (*pmd)) + goto out; + + pte =pte_offset_map_lock (mm, pmd, address, &ptl); +for (_address = address, _pte = pte; _pte < pte+HPAGE_PMD_NR ; + _pte++, _address +=PAGE_SIZE ) { +pte_t pteval = *_pte; +if (!pte_present (pteval) || !pte_write (pteval)) + goto out_unmap; +if (pte_young (pteval)) + referenced =1 ; + page =vm_normal_page (vma, _address, pteval); +if (unlikely (!page)) + goto out_unmap; +VM_BUG_ON (PageCompound (page)); +if (!PageLRU (page) ||PageLocked (page) || !PageAnon (page)) + goto out_unmap; +/* cannot use mapcount: can't collapse if there's a gup pin */ +if (page_count (page) !=1 ) + goto out_unmap; + } +if (referenced) + ret =1 ; +out_unmap: +pte_unmap_unlock (pte, ptl); +if (ret) { +up_read (&mm->mmap_sem); +collapse_huge_page (mm, address, hpage); + } +out: +return ret; +} + +static void collect_mm_slot (struct mm_slot *mm_slot) +{ +struct mm_struct *mm = mm_slot->mm; + +VM_BUG_ON (!spin_is_locked (&khugepaged_mm_lock)); + +if (khugepaged_test_exit (mm)) { +/* free mm_slot */ +hlist_del (&mm_slot->hash); +list_del (&mm_slot->mm_node); +clear_bit (MMF_VM_MERGEABLE , &mm->flags); +free_mm_slot (mm_slot); +mmdrop (mm); + } +} + +static unsigned int khugepaged_scan_mm_slot (unsigned int pages, +struct page **hpage) +{ +struct mm_slot *mm_slot; +struct mm_struct *mm; +struct vm_area_struct *vma; +int progress =0 ; + +VM_BUG_ON (!pages); +VM_BUG_ON (!spin_is_locked (&khugepaged_mm_lock)); + +if (khugepaged_scan.mm_slot) + mm_slot = khugepaged_scan.mm_slot; +else { + mm_slot =list_entry (khugepaged_scan.mm_head.next, + struct mm_slot, mm_node); + khugepaged_scan.address =0 ; + khugepaged_scan.mm_slot = mm_slot; + } +spin_unlock (&khugepaged_mm_lock); + + mm = mm_slot->mm; +down_read (&mm->mmap_sem); +if (unlikely (khugepaged_test_exit (mm))) + vma =NULL ; +else + vma =find_vma (mm, khugepaged_scan.address); + + progress++; +for (; vma; vma = vma->vm_next) { +unsigned long hstart, hend; + +cond_resched (); +if (unlikely (khugepaged_test_exit (mm))) { + progress++; +break ; + } + +if (!(vma->vm_flags &VM_HUGEPAGE ) && + !khugepaged_always ()) { + progress++; +continue ; + } + +/* VM_PFNMAP vmas may have vm_ops null but vm_file set */ +if (!vma->anon_vma || vma->vm_ops || vma->vm_file) { + khugepaged_scan.address = vma->vm_end; + progress++; +continue ; + } +VM_BUG_ON (is_linear_pfn_mapping (vma) ||is_pfn_mapping (vma)); + + hstart = (vma->vm_start + ~HPAGE_PMD_MASK ) &HPAGE_PMD_MASK ; + hend = vma->vm_end &HPAGE_PMD_MASK ; +if (hstart >= hend) { + progress++; +continue ; + } +if (khugepaged_scan.address < hstart) + khugepaged_scan.address = hstart; +if (khugepaged_scan.address > hend) { + khugepaged_scan.address = hend +HPAGE_PMD_SIZE ; + progress++; +continue ; + } +BUG_ON (khugepaged_scan.address & ~HPAGE_PMD_MASK ); + +while (khugepaged_scan.address < hend) { +int ret; +cond_resched (); +if (unlikely (khugepaged_test_exit (mm))) + goto breakouterloop; + +VM_BUG_ON (khugepaged_scan.address < hstart || + khugepaged_scan.address +HPAGE_PMD_SIZE > + hend); + ret =khugepaged_scan_pmd (mm, vma, + khugepaged_scan.address, + hpage); +/* move to next address */ + khugepaged_scan.address +=HPAGE_PMD_SIZE ; + progress +=HPAGE_PMD_NR ; +if (ret) +/* we released mmap_sem so break loop */ + goto breakouterloop_mmap_sem; +if (progress >= pages) + goto breakouterloop; + } + } +breakouterloop: +up_read (&mm->mmap_sem);/* exit_mmap will destroy ptes after this */ +breakouterloop_mmap_sem: + +spin_lock (&khugepaged_mm_lock); +BUG_ON (khugepaged_scan.mm_slot != mm_slot); +/* +* Release the current mm_slot if this mm is about to die, or +* if we scanned all vmas of this mm. +*/ +if (khugepaged_test_exit (mm) || !vma) { +/* +* Make sure that if mm_users is reaching zero while +* khugepaged runs here, khugepaged_exit will find +* mm_slot not pointing to the exiting mm. +*/ +if (mm_slot->mm_node.next != &khugepaged_scan.mm_head) { + khugepaged_scan.mm_slot =list_entry ( + mm_slot->mm_node.next, + struct mm_slot, mm_node); + khugepaged_scan.address =0 ; + }else { + khugepaged_scan.mm_slot =NULL ; + khugepaged_full_scans++; + } + +collect_mm_slot (mm_slot); + } + +return progress; +} + +static int khugepaged_has_work (void ) +{ +return !list_empty (&khugepaged_scan.mm_head) && +khugepaged_enabled (); +} + +static int khugepaged_wait_event (void ) +{ +return !list_empty (&khugepaged_scan.mm_head) || + !khugepaged_enabled (); +} + +static void khugepaged_do_scan (struct page **hpage) +{ +unsigned int progress =0 , pass_through_head =0 ; +unsigned int pages = khugepaged_pages_to_scan; + +barrier ();/* write khugepaged_pages_to_scan to local stack */ + +while (progress < pages) { +cond_resched (); + +if (!*hpage) { + *hpage =alloc_hugepage (); +if (unlikely (!*hpage)) +break ; + } + +spin_lock (&khugepaged_mm_lock); +if (!khugepaged_scan.mm_slot) + pass_through_head++; +if (khugepaged_has_work () && + pass_through_head <2 ) + progress +=khugepaged_scan_mm_slot (pages - progress, + hpage); +else + progress = pages; +spin_unlock (&khugepaged_mm_lock); + } +} + +static struct page *khugepaged_alloc_hugepage (void ) +{ +struct page *hpage; + +do { + hpage =alloc_hugepage (); +if (!hpage) +schedule_timeout_interruptible ( +msecs_to_jiffies ( + khugepaged_alloc_sleep_millisecs)); + }while (unlikely (!hpage) && +likely (khugepaged_enabled ())); +return hpage; +} + +static void khugepaged_loop (void ) +{ +struct page *hpage; + +while (likely (khugepaged_enabled ())) { + hpage =khugepaged_alloc_hugepage (); +if (unlikely (!hpage)) +break ; + +khugepaged_do_scan (&hpage); +if (hpage) +put_page (hpage); +if (khugepaged_has_work ()) { +if (!khugepaged_scan_sleep_millisecs) +continue ; +schedule_timeout_interruptible ( +msecs_to_jiffies ( + khugepaged_scan_sleep_millisecs)); + }else if (khugepaged_enabled ()) +wait_event_interruptible (khugepaged_wait, +khugepaged_wait_event ()); + } +} + +static int khugepaged (void *none) +{ +struct mm_slot *mm_slot; + +set_user_nice (current,19 ); + +for (;;) { +BUG_ON (khugepaged_thread != current); +khugepaged_loop (); +BUG_ON (khugepaged_thread != current); + +mutex_lock (&khugepaged_mutex); +if (!khugepaged_enabled ()) +break ; +mutex_unlock (&khugepaged_mutex); + } + +spin_lock (&khugepaged_mm_lock); + mm_slot = khugepaged_scan.mm_slot; + khugepaged_scan.mm_slot =NULL ; +if (mm_slot) +collect_mm_slot (mm_slot); +spin_unlock (&khugepaged_mm_lock); + + khugepaged_thread =NULL ; +mutex_unlock (&khugepaged_mutex); + +return 0 ; +} --
Quoted 5 lines
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 36/36] khugepaged
Quoted 8 lines · On Tue, 23 Feb 2010 16:58:07 +0900 KAMEZAWA Hiroyuki…
On Sun, 21 Feb 2010 15:10:45 +0100
mm/huge_memory.c int hugepage_madvise(unsigned long *vm_f · line 1509
Quoted 3 lines
mm/huge_memory.c +3
-0+spin_lock (ptl); + isolated =__collapse_huge_page_isolate (vma, address, pte); +spin_unlock (ptl);Is it safe to take
zone->lockunderpte_lockandanon_vma->lock?
Quoted 4 lines
I think usual way is
page =follow_page(FOLL_GET)
isolate_page(page)
I'm sorry it was written in rmap.c as
* mapping->i_mmap_lock
* anon_vma->lock
* mm->page_table_lock or pte_lock
* zone->lru_lock (in mark_page_accessed, isolate_lru_page)
Regards,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 36/36] khugepaged
In reply to KAMEZAWA HiroyukiQuoted 3 lines · KAMEZAWA Hiroyuki
I'm not sure but....where this *hpage is chareged to proper memcg ? I think it's good to charge this newpage in the top of this function. (And cancel it at failure, of course.)
That is just a temporary page owned by khugepaged, not owned by any memcg user. Who should I account it against? If allocation fails khugepaged just waits alloc_sleep_msec and tries again later.
When the allocated page is actually used to collapse an hugepage, an amount of memory equal to the size of the hpage is released. In turn khugepaged changes nothing in the memcg accounting. There's just this hpage temporary page that is also released if you turn off khugepaged via sysctl, and I wouldn't know who to account it against. While it's true it takes 512 more space than the khugepaged kernel stack, conceptually it's the same thing as the kernel stack of the kernel thread, so by that argument we should account khugepaged 4k of kernel stack too.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 36/36] khugepaged
Quoted 9 lines · On Tue, 23 Feb 2010 15:26:34 +0100 Andrea Arcangeli <[email protected]> wrote:
Quoted 3 lines · KAMEZAWA Hiroyuki
I'm not sure but....where this *hpage is chareged to proper memcg ? I think it's good to charge this newpage in the top of this function. (And cancel it at failure, of course.)
That is just a temporary page owned by khugepaged, not owned by any memcg user. Who should I account it against? If allocation fails khugepaged just waits
alloc_sleep_msecand tries again later.
I can't track all your code, too complex.
What I can see via this patch 36/36 is
- all mapped pages are uncharged at page_remove_rmap(),
- huge page (new_page) is not charged.
Quoted 3 lines
When the allocated page is actually used to collapse an hugepage, an amount of memory equal to the size of the hpage is released. In turn khugepaged changes nothing in the memcg accounting.
That's wrong.
We cannot assume all mapped pages are belongs to the same memcg. You should think
- all mapped pages are uncharged when page_remove_rmap() is called in __collapse_huge_page() from unknown memcg.
- You have to charge a new hugepage when it's mapped to mm's memcg.
Then, silent account migration occurs. I think it's small problem but should be documented somewhere.
Thanks,
-Kame
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Andrew Morton
maintainerRe: [patch 36/36] khugepaged
In reply to [email protected]Quoted 3 lines · On Sun, 21 Feb 2010 15:10:45 +0100 [email protected] wrote:
Add khugepaged to relocate fragmented pages into hugepages if new hugepages become available. (this is indipendent of the defrag logic that will have to make new hugepages available)
What does this mean? What are the user-visible effects if (when) this kernel thread fails to keep up?
Generally it seems like a bad idea to do this sort of thing asynchronously. Because it reduces repeatability across runs and across machines - system behaviour becomes more dependent on the size of the machine and the amount of activity in unrelated jobs?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 36/36] khugepaged
Quoted 8 lines · Andrew Morton
Quoted 3 lines · On Sun, 21 Feb 2010 15:10:45 +0100 [email protected] wrote:
Add khugepaged to relocate fragmented pages into hugepages if new hugepages become available. (this is indipendent of the defrag logic that will have to make new hugepages available)
What does this mean? What are the user-visible effects if (when) this kernel thread fails to keep up?
The result will be that applications use small pages, instead of large ones, and potentially run slightly slower.
The same kind of slowdowns that memory pressure can already cause to userland processes.
Quoted 4 lines
Generally it seems like a bad idea to do this sort of thing asynchronously. Because it reduces repeatability across runs and across machines - system behaviour becomes more dependent on the size of the machine and the amount of activity in unrelated jobs?
Isn't system performance already dependent on the size of the machine and the amount of activity in unrelated jobs?
Using hugepages is a performance enhancement only and otherwise transparent to userspace.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Andrew Morton
maintainerRe: [patch 36/36] khugepaged
Quoted 7 lines · On Wed, 24 Feb 2010 15:28:44 -0500 Rik van Riel <[email protected]> wrote:
Quoted 4 lines
Generally it seems like a bad idea to do this sort of thing asynchronously. Because it reduces repeatability across runs and across machines - system behaviour becomes more dependent on the size of the machine and the amount of activity in unrelated jobs?
Isn't system performance already dependent on the size of the machine and the amount of activity in unrelated jobs?
I said "repeatability".
Quoted 2 lines
Using hugepages is a performance enhancement only and otherwise transparent to userspace.
And it's bad that a job run will take a varying amount of CPU time due to unrelated activity. Yes, that can already happen, but it's undesirable and it's undesirable to worsen things.
If this work could be done synchronously then runtimes become more consistent, which is a good thing.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 36/36] khugepaged
Quoted 15 lines · Andrew Morton
Quoted 7 lines · On Wed, 24 Feb 2010 15:28:44 -0500 Rik van Riel<[email protected]> wrote:
Quoted 4 lines
Generally it seems like a bad idea to do this sort of thing asynchronously. Because it reduces repeatability across runs and across machines - system behaviour becomes more dependent on the size of the machine and the amount of activity in unrelated jobs?
Isn't system performance already dependent on the size of the machine and the amount of activity in unrelated jobs?
I said "repeatability".
Quoted 2 lines
Using hugepages is a performance enhancement only and otherwise transparent to userspace.
Quoted 6 lines
And it's bad that a job run will take a varying amount of CPU time due to unrelated activity. Yes, that can already happen, but it's undesirable and it's undesirable to worsen things.
If this work could be done synchronously then runtimes become more consistent, which is a good thing.
Only if it means run times become shorter...
I would argue that running consistently slower would be worse than running inconsitently faster, but maybe that's just me :)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Andrew Morton
maintainerRe: [patch 36/36] khugepaged
Quoted 16 lines · On Wed, 24 Feb 2010 15:57:31 -0500 Rik van Riel <[email protected]> wrote:
Quoted 15 lines · Andrew Morton
Quoted 7 lines · On Wed, 24 Feb 2010 15:28:44 -0500 Rik van Riel<[email protected]> wrote:
Quoted 4 lines
Generally it seems like a bad idea to do this sort of thing asynchronously. Because it reduces repeatability across runs and across machines - system behaviour becomes more dependent on the size of the machine and the amount of activity in unrelated jobs?
Isn't system performance already dependent on the size of the machine and the amount of activity in unrelated jobs?
I said "repeatability".
Quoted 2 lines
Using hugepages is a performance enhancement only and otherwise transparent to userspace.
Quoted 9 lines
Quoted 6 lines
And it's bad that a job run will take a varying amount of CPU time due to unrelated activity. Yes, that can already happen, but it's undesirable and it's undesirable to worsen things.
If this work could be done synchronously then runtimes become more consistent, which is a good thing.
Only if it means run times become shorter...
That of course would be a problem to be traded off against the advantage. One would need to quantify these things to make that call.
I asked a question and all I'm getting in reply is flippancy and unsubstantiated assertions. It may have been a bad question, but they're certainly bad answers :(
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 36/36] khugepaged
Quoted 7 lines · Andrew Morton
Quoted 6 lines · On Wed, 24 Feb 2010 15:57:31 -0500 Rik van Riel<[email protected]> wrote:
Quoted 4 lines · Andrew Morton
On Wed, 24 Feb 2010 15:28:44 -0500 Rik van Riel<[email protected]> wrote:
If this work could be done synchronously then runtimes become more consistent, which is a good thing.
Quoted 8 lines
Quoted 1 line
Only if it means run times become shorter...
That of course would be a problem to be traded off against the advantage. One would need to quantify these things to make that call.
I asked a question and all I'm getting in reply is flippancy and unsubstantiated assertions. It may have been a bad question, but they're certainly bad answers :(
The hugepage patchset as it stands tries to allocate huge pages synchronously, but will fall back to normal 4kB pages if they are not.
Similarly, khugepaged only compacts anonymous memory into hugepages if/when hugepages become available.
Trying to always allocate hugepages synchronously would mean potentially having to defragment memory synchronously, before we can allocate memory for a page fault.
While I have no numbers, I have the strong suspicion that the performance impact of potentially defragmenting 2MB of memory before each page fault could lead to more performance inconsistency than allocating small pages at first and having them collapsed into large pages later...
The amount of work involved in making a 2MB page available could be fairly big, which is why I suspect we will be better off doing it asynchronously - preferably on otherwise idle CPU core.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Andrew Morton
maintainerRe: [patch 36/36] khugepaged
Quoted 17 lines · On Wed, 24 Feb 2010 16:24:16 -0500 Rik van Riel <[email protected]> wrote:
The hugepage patchset as it stands tries to allocate huge pages synchronously, but will fall back to normal 4kB pages if they are not.
Similarly, khugepaged only compacts anonymous memory into hugepages if/when hugepages become available.
Trying to always allocate hugepages synchronously would mean potentially having to defragment memory synchronously, before we can allocate memory for a page fault.
While I have no numbers, I have the strong suspicion that the performance impact of potentially defragmenting 2MB of memory before each page fault could lead to more performance inconsistency than allocating small pages at first and having them collapsed into large pages later...
Quoted 4 lines
The amount of work involved in making a 2MB page available could be fairly big, which is why I suspect we will be better off doing it asynchronously - preferably on otherwise idle CPU core.
Sounds right. How much CPU consumption are we seeing from khugepaged?
The above-quoted text would make a good addition to the (skimpy) changelog!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 36/36] khugepaged
Quoted 1 line · Andrew Morton
Sounds right. How much CPU consumption are we seeing from khugepaged?
zero cpu consumption, least on my laptop with default values. Maybe default isn't aggressive enough but it will still cover very long-lived allocations just fine. (for short lived allocations using hugepages or not won't make a difference except during the first page fault that will run some 50% faster, and cows that will be slower if there's cache trashing)
Quoted 2 lines
The above-quoted text would make a good addition to the (skimpy) changelog!
Agreed, I will integrate it... Also I need to check memcg in khugepaged.
Thanks!
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 36/36] khugepaged
In reply to Rik van RielQuoted 17 lines · Rik van Riel
The hugepage patchset as it stands tries to allocate huge pages synchronously, but will fall back to normal 4kB pages if they are not.
Similarly, khugepaged only compacts anonymous memory into hugepages if/when hugepages become available.
Trying to always allocate hugepages synchronously would mean potentially having to defragment memory synchronously, before we can allocate memory for a page fault.
While I have no numbers, I have the strong suspicion that the performance impact of potentially defragmenting 2MB of memory before each page fault could lead to more performance inconsistency than allocating small pages at first and having them collapsed into large pages later...
Quoted 4 lines
The amount of work involved in making a 2MB page available could be fairly big, which is why I suspect we will be better off doing it asynchronously - preferably on otherwise idle CPU core.
I agree. This is also why I have doubts we'll need a memory compaction kernel thread that has to provide free hugepages always available for page faults. But that's another topic and the memory compaction kernel thread may be worth it indipendent of khugepaged. Surely if there wasn't khugepaged, such a memory compaction kernel thread would be a must, but we need khugepaged for other reasons too so we can as well take advantage of it to speedup the short lived allocations by not requiring them to defrag memory. Long lived allocations will be taken care of by khugepaged.
The fundamental reason why khugepaged is unavoidable, is that some memory can be fragmented and not everything can be relocated. So when a virtual machine quits and releases gigabytes of hugepages, we want to use those freely available hugepages to create huge-pmd in the other virtual machines that may be running on fragmented memory, to maximize the CPU efficiency at all times. The scan is slow, it takes nearly zero cpu time, except when it copies data (in which case it means we definitely want to pay for that cpu time) so it seems a good tradeoff.
As sysctl that control defrag there is only one right now and it turns defrag on and off. We could make it more finegrined and have two files, one for the page faults in transparent_hugepage/defrag as always|madvise|never, and one yes|no in transparent_hugepage/khugepaged/defrag but that may be overdesign... I'm not sure really when and how to invoke memory compaction, so having that maximum amount of knobs really is only requires if we can't came up with an optimal design. If we can came up with an optimal solution the current system wide "yes|no" in transparent_hugepage/defrag should be enough (currently it defaults to "no" because there's no real memory compaction invoked yet, and shrinking blind isn't very helpful anyway, unless we go with __GFP_REPEAT|GFP_IO|GFP_FS which stalls the system often).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [patch 36/36] khugepaged
Quoted 8 lines · Andrea Arcangeli
As sysctl that control defrag there is only one right now and it turns defrag on and off. We could make it more finegrined and have two files, one for the page faults in transparent_hugepage/defrag as always|madvise|never, and one yes|no in transparent_hugepage/khugepaged/defrag but that may be overdesign... I'm not sure really when and how to invoke memory compaction, so having that maximum amount of knobs really is only requires if we can't came up with an optimal design.
The knobs may be useful for testing what the best default behaviour would be, as well as for workloads with special needs (eg. HPC vs. workloads with many short lived small processes).
On systems with many CPU cores, it would also be fairly easy to do some background memory compaction on an idle CPU core, so we have huge pages available for when processes need them...
There are a lot of unknowns here still, so we probably need to stay flexible for a while to come.
The only thing we do know is that the hugepages can really speed up some workloads.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Hello everyone,
Quoted 8 lines · On Sun, Feb 21, 2010 at 03:10:09PM +0100, [email protected] wrote:
This is a port of the latest version of transparent hugepage to
git://zen-kernel.org/kernel/mmotm.gitThe relevant changes are the addition of the
page_anon_vmapatch, the patch to adapt the rss accounting to -mm, and a one liner fix in theclear_copy_huge_pagecleanup patch (that was crashing hugetlbfs).http://www.kernel.org/pub/linux/kernel/people/andrea/patches/v2.6/2.6.33-rc7-mm1+/transparent_hugepage-11/
somebody asked a single patch to test on top ofgit://zen-kernel.org/kernel/mmotm.git so here it is:
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>