RDMA/cxgb3: Mark rdma device with CXIO_ERROR_FATAL when removing.
PATCH 1/1 RDMA/cxgb3: Mark rdma device with CXIO_ERROR_FATAL when removing.
If cxgb3 calls the iw_cxgb3 t3cclient remove function due to a device removal event, then the iwch device must be marked with CXIO_ERROR_FATAL since the device below us is going away. Otherwise, we can get stuck in a deadlock as rdma ULPs try and deallocate objects (like MRs, QPs, etc). So always mark the device with CXIO_ERROR_FATAL when removing.
---
drivers/infiniband/hw/cxgb3/iwch.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/infiniband/hw/cxgb3/iwch.c +1 -0
@@ -188,6 +188,7 @@ static void close_rnic_dev(struct t3cdev *tdev)mutex_lock (&dev_mutex);list_for_each_entry_safe (dev, tmp, &dev_list, entry) {if (dev->rdev.t3cdev_p == tdev) { + dev->rdev.flags =CXIO_ERROR_FATAL ;cancel_delayed_work_sync (&dev->db_drop_task);list_del (&dev->entry);iwch_unregister_device (dev);
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20100222220722.20959.48045.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org
Roland Dreier
Appliedthanks, applied. I think I got all the pending cxgb3 patches, let me know if I missed some.
Signature · 7 lines
Roland Dreier <[email protected]> For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html