RDMA/nes: add support for KR device id 0x0110
PATCH 1/1 RDMA/nes: add support for KR device id 0x0110
Add support for KR device id 0x0110. While at it, cleanup nes_init_phy() by splitting it into nes_init_1g_phy() and nes_init_2025_phy(). Deprecate NES_PHY_TYPE_IRIS which is no longer being manufactured.
--- drivers/infiniband/hw/nes/nes.c | 1 + drivers/infiniband/hw/nes/nes.h | 5 +- drivers/infiniband/hw/nes/nes_hw.c | 400 ++++++++++++++++++++--------------- drivers/infiniband/hw/nes/nes_hw.h | 2 +- drivers/infiniband/hw/nes/nes_nic.c | 57 +----- 5 files changed, 245 insertions(+), 220 deletions(-)
drivers/infiniband/hw/nes/nes.c +1 -0
@@ -110,6 +110,7 @@ static unsigned int sysfs_idx_addr;static struct pci_device_id nes_pci_table[] = { {PCI_VENDOR_ID_NETEFFECT ,PCI_DEVICE_ID_NETEFFECT_NE020 ,PCI_ANY_ID ,PCI_ANY_ID }, + {PCI_VENDOR_ID_NETEFFECT ,PCI_DEVICE_ID_NETEFFECT_NE020_KR ,PCI_ANY_ID ,PCI_ANY_ID }, {0 } };
drivers/infiniband/hw/nes/nes.h +3 -2
@@ -64,8 +64,9 @@* NetEffect PCI vendor id and NE010 PCI device id. */ #ifndef PCI_VENDOR_ID_NETEFFECT /* not in pci.ids yet */ -#define PCI_VENDOR_ID_NETEFFECT 0x1678 -#define PCI_DEVICE_ID_NETEFFECT_NE020 0x0100 +#define PCI_VENDOR_ID_NETEFFECT 0x1678 +#define PCI_DEVICE_ID_NETEFFECT_NE020 0x0100 +#define PCI_DEVICE_ID_NETEFFECT_NE020_KR 0x0110#endif #define NE020_REV 4
drivers/infiniband/hw/nes/nes_hw.c +231 -165
462 lines not on this page · raw message
drivers/infiniband/hw/nes/nes_hw.h +1 -1
@@ -37,12 +37,12 @@#define NES_PHY_TYPE_CX4 1#define NES_PHY_TYPE_1G 2 -#define NES_PHY_TYPE_IRIS 3#define NES_PHY_TYPE_ARGUS 4#define NES_PHY_TYPE_PUMA_1G 5#define NES_PHY_TYPE_PUMA_10G 6#define NES_PHY_TYPE_GLADIUS 7#define NES_PHY_TYPE_SFP_D 8 +#define NES_PHY_TYPE_KR 9#define NES_MULTICAST_PF_MAX 8
drivers/infiniband/hw/nes/nes_nic.c +7 -50
89 lines not on this page · raw message
Signature · 6 lines
1.6.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 4 lines
Add support for KR device id
0x0110. While at it, cleanupnes_init_phy()by splitting it intones_init_1g_phy()andnes_init_2025_phy(). DeprecateNES_PHY_TYPE_IRISwhich is no longer being manufactured.
By "deprecate NES_PHY_TYPE_IRIS" it seems you mean remove all support for this PHY type?
Were cards of this type sold? Because I think it's way too early to drop support for any PHY variant (it's not like these are some 10BASE2 cards from decades ago -- these are 10 gigabit NICs at most only a few years old) unless it is something like an experimental card that never escaped from your labs.
- R.
Signature · 7 lines
Roland Dreier <[email protected]> For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): adavddmxnqf.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org
Quoted 2 lines
By "deprecate
NES_PHY_TYPE_IRIS" it seems you mean remove all support for this PHY type?
yes, see below.
Quoted 5 lines
Were cards of this type sold? Because I think it's way too early to drop support for any PHY variant (it's not like these are some 10BASE2 cards from decades ago -- these are 10 gigabit NICs at most only a few years old) unless it is something like an experimental card that never escaped from your labs.
Iris is an XFP card. NetEffect didn't make that many and maybe a few were given out as evals. The biggest reason for removing the support is I don't have a card to test code changes. There are other cards that I am supporting even though we no longer make them as Intel. I will keep those around as long as I have cards, in a secret hiding place. :-)
Chien
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 603F8A3875DCE940BA37B49D0A6EA0AE842C0E89-uLM7Qlg6Mbekrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org
Quoted 5 lines
Iris is an XFP card. NetEffect didn't make that many and maybe a few were given out as evals. The biggest reason for removing the support is I don't have a card to test code changes. There are other cards that I am supporting even though we no longer make them as Intel. I will keep those around as long as I have cards, in a secret hiding place. :-)
OK, if you're comfortable that no one is still using such cards then it's fine with me to remove the support.
- R.
Signature · 7 lines
Roland Dreier <[email protected]> For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): ada635lxk4l.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org
Quoted 8 lines
Quoted 5 lines
Iris is an XFP card. NetEffect didn't make that many and maybe a few were given out as evals. The biggest reason for removing the support is I don't have a card to test code changes. There are other cards that I am supporting even though we no longer make them as Intel. I will keep those around as long as I have cards, in a secret hiding place. :-)
OK, if you're comfortable that no one is still using such cards then it's fine with me to remove the support.
Thanks.
Chien
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html