Skip to contentSkip to conversation

staging/serial2002: Fix filp_open usage

PATCH In review OGAWA Hirofumi 2 participants 2 messages Feb 22, 2010 – Feb 24, 2010 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging/serial2002: Fix filp_open usage

---

 drivers/staging/comedi/drivers/serial2002.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/serial2002.c renamed from drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix +1 -1
diff -puN drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix drivers/staging/comedi/drivers/serial2002.c
@@ -397,7 +397,7 @@ static void serial_2002_open(struct come
 	char port[20];
 
 	sprintf(port, "/dev/ttyS%d", devpriv->port);
-	devpriv->tty = filp_open(port, 0, O_RDWR);
+	devpriv->tty = filp_open(port, O_RDWR, 0);
 	if (IS_ERR(devpriv->tty)) {
 		printk("serial_2002: file open error = %ld\n",
 		       PTR_ERR(devpriv->tty));

_

Signature · 1 line
OGAWA Hirofumi <[email protected]>
#1 lore raw
Quoted 11 lines · OGAWA Hirofumi

---

 drivers/staging/comedi/drivers/serial2002.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix drivers/staging/comedi/drivers/serial2002.c

drivers/staging/comedi/drivers/serial2002.c static void serial_2002_open(struct come · line 400

Quoted 5 lines
drivers/staging/comedi/drivers/serial2002.c renamed from drivers/staging/comedi/drivers/serial2002.c~serial2002-filp_open-fix +1 -1
@@ -397,7 +397,7 @@ static void serial_2002_open(struct come
 	char port[20];
 
 	sprintf(port, "/dev/ttyS%d", devpriv->port);
-	devpriv->tty = filp_open(port, 0, O_RDWR);
+	devpriv->tty = filp_open(port, O_RDWR, 0);

Oh wow that code is scary :)

I'll queue this up and remember to nuke the whole thing soon...

thanks,

greg k-h