Skip to contentSkip to conversation

ppc4xx: Corrected EBC register bit definitions

PATCH New Eugene O'Brien 3 participants 5 messages Feb 23, 2010 – Feb 24, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Corrected EBC register bit definitions

Corrected the bit field positions of the external master priority low and the external master priority high values in the EBC configuration register.

---
 include/asm-ppc/ppc4xx-ebc.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
include/asm-ppc/ppc4xx-ebc.h +0 -2
index 9680f70..697a916 100644
@@ -143,10 +143,10 @@
 #define EBC_CFG_EBTC_MASK	PPC_REG_VAL(0, 0x1)
 #define EBC_CFG_EBTC_HI		PPC_REG_VAL(0, 0x0)
 #define EBC_CFG_EBTC_DRIVEN	PPC_REG_VAL(0, 0x1)
-#define EBC_CFG_EMPH_MASK	PPC_REG_VAL(6, 0x3)
-#define EBC_CFG_EMPH_ENCODE(n)	PPC_REG_VAL(6, (static_cast(u32, n)) &

0x3)
-#define EBC_CFG_EMPL_MASK PPC_REG_VAL(8, 0x3)
-#define EBC_CFG_EMPL_ENCODE(n) PPC_REG_VAL(8, (static_cast(u32, n)) &
0x3)
+#define EBC_CFG_EMPL_MASK PPC_REG_VAL(6, 0x3)
+#define EBC_CFG_EMPL_ENCODE(n) PPC_REG_VAL(6, (static_cast(u32, n)) &
0x3)
+#define EBC_CFG_EMPH_MASK PPC_REG_VAL(8, 0x3)
+#define EBC_CFG_EMPH_ENCODE(n) PPC_REG_VAL(8, (static_cast(u32, n)) &
0x3)
#define EBC_CFG_CSTC_MASK PPC_REG_VAL(9, 0x1)
#define EBC_CFG_CSTC_HI PPC_REG_VAL(9, 0x0)
#define EBC_CFG_CSTC_DRIVEN PPC_REG_VAL(9, 0x1)

Signature · 1 line
1.7.0.rc1.10.gb8bb
#1 lore raw

PATCH 1/1 ppc4xx: Corrected EBC register bit definitions

Dear "Eugene O'Brien",

Quoted 15 lines · In message <[email protected]> you…

Corrected the bit field positions of the external master priority low and the external master priority high values in the EBC configuration register.

---
 include/asm-ppc/ppc4xx-ebc.h |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
include/asm-ppc/ppc4xx-ebc.h +0 -0
index 9680f70..697a916 100644

include/asm-ppc/ppc4xx-ebc.h line 146

Quoted 6 lines
include/asm-ppc/ppc4xx-ebc.h +0 -2
@@ -143,10 +143,10 @@
 #define EBC_CFG_EBTC_MASK	PPC_REG_VAL(0, 0x1)
 #define EBC_CFG_EBTC_HI		PPC_REG_VAL(0, 0x0)
 #define EBC_CFG_EBTC_DRIVEN	PPC_REG_VAL(0, 0x1)
-#define EBC_CFG_EMPH_MASK	PPC_REG_VAL(6, 0x3)
-#define EBC_CFG_EMPH_ENCODE(n)	PPC_REG_VAL(6, (static_cast(u32, n)) &
 0x3)

Your patch is line-wrapped.

Please use git-send-email to send patches, or fix your mailer configuration.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All I ask is a chance to prove that money can't make me happy.
#2 lore raw

PATCH 1/1 ppc4xx: Corrected EBC register bit definitions

In reply to Eugene O'Brien

Eugene,

Quoted 3 lines · On Tuesday 23 February 2010 22:19:04 Eugene O'Brien wrote:

Corrected the bit field positions of the external master priority low and the external master priority high values in the EBC configuration register.

In addition to Wolfgangs comment (patch is line wrapped): I just checked the 440EP and the 440EPx users manual, and it seems that the original bit masks are correct. Which PPC4xx variant are you using? Please double check again if you your patch is correct.

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

#3 lore raw

PATCH 1/1 ppc4xx: Corrected EBC register bit definitions

Hello Stefan,

Quoted 1 line

In addition to Wolfgangs comment (patch is line wrapped): I just

checked the

Quoted 1 line

440EP and the 440EPx users manual, and it seems that the original bit

masks

Quoted 1 line

are correct. Which PPC4xx variant are you using? Please double check

again if

Quoted 2 lines

you your patch is correct.

I am working on another platform based on the PPC405GPr. You are correct in your observation and my patch is incorrect. The original bit masks are correct for the PPC440EP and PPC440EPx but **not** for the PPC405GPr so a correction is required.

According to the AMCC documentation, the EMPL, EMPH bit positions are as you defined them for the PPC440 processors and they are as I define them for the PPC405 processors (in the group of processors defined as CONFIG_EBC_PPC4xx_IBM_VER1). The PPC405EP is an exception since it does not seem to allow external bus mastering and these bits are reserved. Therefore a proper patch needs to set the bit position of the EMPL and EMPH fields differently with the CONFIG_EBC_PPC4xx_IBM_VER1 group accordingly. I can attempt a patch for that if you like.

My apologies for the line wrapping mistake (I believe my email client is not line wrapping but it got line wrapped somewhere else... possibly in the Microsoft exchange server).

Regards,
Eugene

#4 lore raw

PATCH 1/1 ppc4xx: Corrected EBC register bit definitions

Hi Eugene,

Quoted 4 lines · On Wednesday 24 February 2010 16:12:48 Eugene O'Brien wrote:

I am working on another platform based on the PPC405GPr. You are correct in your observation and my patch is incorrect. The original bit masks are correct for the PPC440EP and PPC440EPx but **not** for the PPC405GPr so a correction is required.

I see.

Quoted 8 lines

According to the AMCC documentation, the EMPL, EMPH bit positions are as you defined them for the PPC440 processors and they are as I define them for the PPC405 processors (in the group of processors defined as CONFIG_EBC_PPC4xx_IBM_VER1). The PPC405EP is an exception since it does not seem to allow external bus mastering and these bits are reserved. Therefore a proper patch needs to set the bit position of the EMPL and EMPH fields differently with the CONFIG_EBC_PPC4xx_IBM_VER1 group accordingly. I can attempt a patch for that if you like.

Yes, please do so. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de