Skip to contentSkip to conversation

mac80211: use listen interval 5 as default

PATCH New Helmut Schaa 1 participant 1 message Feb 24, 2010 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mac80211: use listen interval 5 as default

Currently if a driver does not set hw.max_listen_interval a listen interval of 1 is negotiated with the AP. Thus, the AP could drop buffered frames for us after just one beacon interval which can easily happen with the current powersave and scan implementation. To avoid this issue increase the default interval to 5 which should be a reasonable safe default.

---
 net/mac80211/main.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
net/mac80211/main.c +5 -1
index ec8f767..06c33b6 100644
@@ -558,8 +558,12 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
 
 	debugfs_hw_add(local);
 
+	/*
+	 * if the driver doesn't specify a max listen interval we
+	 * use 5 which should be a safe default
+	 */
 	if (local->hw.max_listen_interval == 0)
-		local->hw.max_listen_interval = 1;
+		local->hw.max_listen_interval = 5;
 
 	local->hw.conf.listen_interval = local->hw.max_listen_interval;
 
Signature · 1 line
1.6.0.2