drm: fix char constant (sparse warning)
Subsystems (2)
PATCH 1/1 drm: fix char constant (sparse warning)
From: Randy Dunlap <[email protected]>
Fix radeon/atombios.h sparse warning (24 times):
drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constant
--- drivers/gpu/drm/radeon/atombios.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/atombios.h +1 -1
@@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER#define SW_I2C_CNTL_WRITE1BIT 6/* ==============================VESA definition Portion=============================== */ -#define VESA_OEM_PRODUCT_REV '01.00' +#define VESA_OEM_PRODUCT_REV "01.00"#define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB/* refer to VBE spec p.32, no TTY support */ #define VESA_MODE_WIN_ATTRIBUTE 7#define VESA_WIN_SIZE 64
Dave Airlie
maintainerQuoted 5 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix
radeon/atombios.hsparse warning (24 times):
drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constant
We get this file from AMD pretty much as-is and I hate deviating it as it causes merge issues. Alex any change you can get this fixed upstream?
Dave.
Quoted 24 lines
Signed-off-by Randy Dunlap <[email protected]>Cc David Airlie <[email protected]>---
drivers/gpu/drm/radeon/atombios.h | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/radeon/atombios.h +1
-2@@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER #define SW_I2C_CNTL_WRITE1BIT 6 /* ==============================VESA definition Portion=============================== */ -#define VESA_OEM_PRODUCT_REV '01.00' +#define VESA_OEM_PRODUCT_REV "01.00" #define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB /* refer to VBE spec p.32, no TTY support */ #define VESA_MODE_WIN_ATTRIBUTE 7 #define VESA_WIN_SIZE 64 --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 10 lines · Dave Airlie
Quoted 5 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix
radeon/atombios.hsparse warning (24 times):
drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constantWe get this file from AMD pretty much as-is and I hate deviating it as it causes merge issues. Alex any change you can get this fixed upstream?
I can try.
Alex
Quoted 27 lines
Dave.
Quoted 24 lines
Signed-off-by Randy Dunlap <[email protected]>Cc David Airlie <[email protected]>---
drivers/gpu/drm/radeon/atombios.h | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/radeon/atombios.h +1
-2@@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER #define SW_I2C_CNTL_WRITE1BIT 6 /* ==============================VESA definition Portion=============================== */ -#define VESA_OEM_PRODUCT_REV '01.00' +#define VESA_OEM_PRODUCT_REV "01.00" #define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB /* refer to VBE spec p.32, no TTY support */ #define VESA_MODE_WIN_ATTRIBUTE 7 #define VESA_WIN_SIZE 64 --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 10 lines · Alex Deucher
Quoted 9 lines · Dave Airlie
Quoted 5 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix
radeon/atombios.hsparse warning (24 times):
drivers/gpu/drm/radeon/atombios.h:4091:63: error: Bad character constantWe get this file from AMD pretty much as-is and I hate deviating it as it causes merge issues. Alex any change you can get this fixed upstream?
Ah, thanks for that info.
Quoted 5 lines
Quoted 1 line
I can try.
Alex
OK, thanks.
Quoted 21 lines
Quoted 21 lines
Dave.
Quoted 19 lines
Signed-off-by Randy Dunlap <[email protected]>Cc David Airlie <[email protected]>--- drivers/gpu/drm/radeon/atombios.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/radeon/atombios.h +1
-2@@ -4088,7 +4088,7 @@ typedef struct _SW_I2C_IO_DATA_PARAMETER#define SW_I2C_CNTL_WRITE1BIT 6/* ==============================VESA definition Portion=============================== */ -#define VESA_OEM_PRODUCT_REV '01.00' +#define VESA_OEM_PRODUCT_REV "01.00"#define VESA_MODE_ATTRIBUTE_MODE_SUPPORT 0xBB/* refer to VBE spec p.32, no TTY support */ #define VESA_MODE_WIN_ATTRIBUTE 7#define VESA_WIN_SIZE 64 --
Signature · 1 line
~Randy