NFSD: NFSv4 callback client should use RPC_TASK_SOFTCONN
Subsystems (2)
PATCH 1/1 NFSD: NFSv4 callback client should use RPC_TASK_SOFTCONN
The server's callback client should stop trying to connect to the client's callback server as soon as it gets ECONNREFUSED.
The NFS server's callback client does not call rpc_ping(), but appears to have it's own "ping" procedure, so it wasn't covered by commit caabea8a.
---
Hi Bruce-
Noticed at Connectathon. I think this is appropriate for 2.6.34, which opened today.
fs/nfsd/nfs4callback.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
fs/nfsd/nfs4callback.c +2 -1
@@ -542,7 +542,8 @@ void do_probe_callback(struct nfs4_client *clp) };int status; - status =rpc_call_async (cb->cb_client, &msg,RPC_TASK_SOFT , + status =rpc_call_async (cb->cb_client, &msg, +RPC_TASK_SOFT |RPC_TASK_SOFTCONN , &nfsd4_cb_probe_ops, (void *)clp);if (status) {warn_no_callback_path (clp, status);
A message that is not in the archive (sent off-list or not yet received): 20100224214709.1399.59887.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]
J. Bruce Fields
AppliedQuoted 7 lines · Chuck Lever
The server's callback client should stop trying to connect to the client's callback server as soon as it gets ECONNREFUSED.
The NFS server's callback client does not call
rpc_ping(), but appears to have it's own "ping" procedure, so it wasn't covered by commitcaabea8a.
Quoted 7 lines
Signed-off-by Chuck Lever <[email protected]>---
Hi Bruce-
Noticed at Connectathon. I think this is appropriate for 2.6.34, which opened today.
Thanks, applied for 2.6.34.
--b.
Quoted 19 lines
fs/nfsd/nfs4callback.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)fs/nfsd/nfs4callback.c +2
-1@@ -542,7 +542,8 @@ void do_probe_callback(struct nfs4_client *clp) };int status; - status =rpc_call_async (cb->cb_client, &msg,RPC_TASK_SOFT , + status =rpc_call_async (cb->cb_client, &msg, +RPC_TASK_SOFT |RPC_TASK_SOFTCONN , &nfsd4_cb_probe_ops, (void *)clp);if (status) {warn_no_callback_path (clp, status);