Skip to contentSkip to conversation

xen: fbdev frontend needs xenbus frontend

PATCH In review Bastian Blank 3 participants 4 messages Feb 24, 2010 – Feb 25, 2010 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen: fbdev frontend needs xenbus frontend

The fbdev (and kbddev) frontend needs the xenbus frontend, but does not define a dependency. Make the fbdev frontend select the xenbus frontend.

drivers/video/Kconfig +1 -0
index 188e1ba..efac9e3 100644
@@ -2063,6 +2063,7 @@ config XEN_FBDEV_FRONTEND
 	select FB_SYS_IMAGEBLIT
 	select FB_SYS_FOPS
 	select FB_DEFERRED_IO
+	select XEN_XENBUS_FRONTEND
 	default y
 	help
 	  This driver implements the front-end of the Xen virtual
Signature · 2 lines
No more blah, blah, blah!
		-- Kirk, "Miri", stardate 2713.6
#1 lore raw
Quoted 3 lines · Bastian Blank

The fbdev (and kbddev) frontend needs the xenbus frontend, but does not define a dependency. Make the fbdev frontend select the xenbus frontend.

Isn't this the same as ba69ea42f8ba8286cbe0e939bd1ce781b7905b84? If so (and if the above mention commit isn't in xen/next) shouldn't you also make this change for drives/input/Kconfig for XEN_KBDDEV_FRONTEND?

Quoted 23 lines
drivers/video/Kconfig +1 -0
index 188e1ba..efac9e3 100644
@@ -2063,6 +2063,7 @@ config XEN_FBDEV_FRONTEND
 	select FB_SYS_IMAGEBLIT
 	select FB_SYS_FOPS
 	select FB_DEFERRED_IO
+	select XEN_XENBUS_FRONTEND
 	default y
 	help
 	  This driver implements the front-end of the Xen virtual
Signature · 7 lines
No more blah, blah, blah!
		-- Kirk, "Miri", stardate 2713.6

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
#2 lore raw
Quoted 11 lines · Konrad Rzeszutek Wilk
Quoted 4 lines · Bastian Blank

The fbdev (and kbddev) frontend needs the xenbus frontend, but does not define a dependency. Make the fbdev frontend select the xenbus frontend.

Isn't this the same as ba69ea42f8ba8286cbe0e939bd1ce781b7905b84? If so (and if the above mention commit isn't in xen/next) shouldn't you also make this change for drives/input/Kconfig for XEN_KBDDEV_FRONTEND?

Did that end up in .33? Should we put it in -stable too?

J

#3 lore raw
Quoted 7 lines · Jeremy Fitzhardinge
Quoted 6 lines · Konrad Rzeszutek Wilk
Quoted 4 lines · Bastian Blank

The fbdev (and kbddev) frontend needs the xenbus frontend, but does not define a dependency. Make the fbdev frontend select the xenbus frontend.

Quoted 7 lines
Quoted 5 lines

Isn't this the same as ba69ea42f8ba8286cbe0e939bd1ce781b7905b84? If so (and if the above mention commit isn't in xen/next) shouldn't you also make this change for drives/input/Kconfig for XEN_KBDDEV_FRONTEND?

Did that end up in .33? Should we put it in -stable too?

I took a look at the code and I think Bastian's is OK. The -stable has this:

152 config XEN_KBDDEV_FRONTEND

153         tristate "Xen virtual keyboard and mouse support"
154         depends on XEN_FBDEV_FRONTEND
155         default y

So it would end up selecting the xenbus frontend as well with Bastian's patch.