Skip to contentSkip to conversation

IPv6: fix anycast address ref count leakage

PATCH In review Stephen Hemminger 1 participant 2 messages Feb 25, 2010 – Feb 26, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IPv6: fix anycast address ref count leakage

The recent change in net-next to keep IPv6 address can lead to device hanging with unresolved refcount on removal. The issue is that the conversion of address from permanent to temporary needs to notify the anycast list code to clean up it's ref count. Also, want to tell other uses of IPv6 (bonding/sctp) that the address is no longer available.

The fix is to notify like a regular delete. When link comes back, DAD runs and will notify with NETDEV_UP that address is back.

The decrement of idev refcount when cleaning up addrconf_hash, should never cause address to be freed; therefore it can use __in6_ifa_put.

The timer cleanup should be done when address deletion is done in second loop.

net/ipv6/addrconf.c +8 -8
@@ -2653,8 +2653,7 @@ static int addrconf_ifdown(struct net_de
 			    (how || !(ifa->flags&IFA_F_PERMANENT))) {
 				*bifa = ifa->lst_next;
 				ifa->lst_next = NULL;
-				addrconf_del_timer(ifa);
-				in6_ifa_put(ifa);
+				__in6_ifa_put(ifa);
 				continue;
 			}
 			bifa = &ifa->lst_next;
@@ -2706,14 +2705,15 @@ static int addrconf_ifdown(struct net_de
 			ifa->if_next = NULL;
 
 			ifa->dead = 1;
-			write_unlock_bh(&idev->lock);
+		}
+		addrconf_del_timer(ifa);
+		write_unlock_bh(&idev->lock);
 
-			__ipv6_ifa_notify(RTM_DELADDR, ifa);
-			atomic_notifier_call_chain(&inet6addr_chain, NETDEV_DOWN, ifa);
-			in6_ifa_put(ifa);
+		__ipv6_ifa_notify(RTM_DELADDR, ifa);
+		atomic_notifier_call_chain(&inet6addr_chain, NETDEV_DOWN, ifa);
+		in6_ifa_put(ifa);
 
-			write_lock_bh(&idev->lock);
-		}
+		write_lock_bh(&idev->lock);
 	}
 	write_unlock_bh(&idev->lock);
 
#1 lore raw
Quoted 9 lines · On Thu, 25 Feb 2010 15:57:07 -0800 Stephen Hemminger <[email protected]>…

The recent change in net-next to keep IPv6 address can lead to device hanging with unresolved refcount on removal. The issue is that the conversion of address from permanent to temporary needs to notify the anycast list code to clean up it's ref count. Also, want to tell other uses of IPv6 (bonding/sctp) that the address is no longer available.

The fix is to notify like a regular delete. When link comes back, DAD runs and will notify with NETDEV_UP that address is back.

Quoted 8 lines

The decrement of idev refcount when cleaning up addrconf_hash, should never cause address to be freed; therefore it can use __in6_ifa_put.

The timer cleanup should be done when address deletion is done in second loop.

Wait till I split/revise this one; it has a problem.