Skip to contentSkip to conversation

Fix dev_list_sysfs interface to allow domains to read sysfs lnk_file.

PATCH New Dominick Grift 2 participants 3 messages Feb 26, 2010 – Mar 4, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix dev_list_sysfs interface to allow domains to read sysfs lnk_file.

---
:100644 100644 fe31e1f... 83c4a2a... M policy/modules/kernel/devices.if

 policy/modules/kernel/devices.if |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
policy/modules/kernel/devices.if +1 -0
index fe31e1f..83c4a2a 100644
@@ -3322,6 +3322,7 @@ interface(`dev_list_sysfs',`
 	')
 
 	list_dirs_pattern($1, sysfs_t, sysfs_t)
+	allow $1 sysfs_t:lnk_file read_lnk_file_perms;
 ')
 
 ########################################
Signature · 9 lines
1.6.6.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20100226/f2452777/attachment.bin 
#1 lore raw

PATCH 1/1 Fix dev_list_sysfs interface to allow domains to read sysfs lnk_file.

Quoted 1 line · Dominick Grift

I'm on the fence for this one. Normally I think this is better suited for dev_read_sysfs(), which has this perm already. But since sysfs is so highly linked, I suppose it could make sense. What prompted this?

Quoted 21 lines

---
:100644 100644 fe31e1f... 83c4a2a... M policy/modules/kernel/devices.if

 policy/modules/kernel/devices.if |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
policy/modules/kernel/devices.if +1 -0
index fe31e1f..83c4a2a 100644
@@ -3322,6 +3322,7 @@ interface(`dev_list_sysfs',`
 	')
 
 	list_dirs_pattern($1, sysfs_t, sysfs_t)
+	allow $1 sysfs_t:lnk_file read_lnk_file_perms;
 ')
 
 ########################################

_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy

Signature · 3 lines
Chris PeBenito
Tresys Technology, LLC
(410) 290-1411 x150
#2 lore raw

PATCH 1/1 Fix dev_list_sysfs interface to allow domains to read sysfs lnk_file.

Quoted 6 lines · Christopher J. PeBenito
Quoted 1 line · Dominick Grift

I'm on the fence for this one. Normally I think this is better suited for dev_read_sysfs(), which has this perm already. But since sysfs is so highly linked, I suppose it could make sense. What prompted this?

Well i needed an interface that does not provide access to read files but does provides access to read lnk_files (for listing sysfs).

I needed it for my kismet policy:

Quoted 19 lines

dev_list_sysfs(kismet_servers)
allow kismet_servers sysfs_t:lnk_file read;

Quoted 16 lines

---
:100644 100644 fe31e1f... 83c4a2a... M policy/modules/kernel/devices.if

 policy/modules/kernel/devices.if |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
policy/modules/kernel/devices.if +1 -0
index fe31e1f..83c4a2a 100644
@@ -3322,6 +3322,7 @@ interface(`dev_list_sysfs',`
 	')
 
 	list_dirs_pattern($1, sysfs_t, sysfs_t)
+	allow $1 sysfs_t:lnk_file read_lnk_file_perms;
 ')
 
Quoted 6 lines
Quoted 5 lines
policy/modules/kernel/devices.if +0 -0
 ########################################

_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20100304/3a3fa11e/attachment.bin