Skip to contentSkip to conversation

pci: Add VPD parsing support

PATCH In review Matt Carlson 3 participants 4 messages Feb 27, 2010 – Feb 28, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover pci: Add VPD parsing support

This patch adds code to help parse a device's VPD. The bnx2 and tg3 network drivers are modified as an example on how to use the API. I believe the bnx2x driver will also use this API in the future.

Changes from v2:
* Constified the vpd buffer and keyword parameters.

Changes from v1:
* Renamed pci_vpd_find_tag() and pci_vpd_find_info_keyword() parameter names.
* Added docbook notations for functions and inline functions.
* Moved pci-vpd.h contents to pci.h

maintainer
#1 lore raw

From: "Matt Carlson" <[email protected]>
Date: Fri, 26 Feb 2010 16:04:38 -0800

Quoted 3 lines

This patch adds code to help parse a device's VPD. The bnx2 and tg3 network drivers are modified as an example on how to use the API. I believe the bnx2x driver will also use this API in the future.

PCI folks, ok with this?

And if so, OK if I merge this via the net-next-2.6 tree?

Thanks!

Acked-by
#2 lore raw
Quoted 10 lines · On Sat, 27 Feb 2010 03:08:31 -0800 (PST) David Miller <[email protected]>…

From: "Matt Carlson" <[email protected]>
Date: Fri, 26 Feb 2010 16:04:38 -0800

Quoted 3 lines

This patch adds code to help parse a device's VPD. The bnx2 and tg3 network drivers are modified as an example on how to use the API. I believe the bnx2x driver will also use this API in the future.

PCI folks, ok with this?

And if so, OK if I merge this via the net-next-2.6 tree?

Yeah, latest round looks good to me. Thanks for doing this, Matt!

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
maintainer
#3 lore raw

From: Jesse Barnes <[email protected]>
Date: Sat, 27 Feb 2010 08:46:30 -0800

Quoted 10 lines
Quoted 7 lines · On Sat, 27 Feb 2010 03:08:31 -0800 (PST) David Miller <[email protected]>…

From: "Matt Carlson" <[email protected]>
Date: Fri, 26 Feb 2010 16:04:38 -0800

Quoted 3 lines

This patch adds code to help parse a device's VPD. The bnx2 and tg3 network drivers are modified as an example on how to use the API. I believe the bnx2x driver will also use this API in the future.

Quoted 7 lines
Quoted 3 lines

PCI folks, ok with this?

And if so, OK if I merge this via the net-next-2.6 tree?

Yeah, latest round looks good to me. Thanks for doing this, Matt!

Thanks Jesse, I've added these changes to my tree.