Skip to contentSkip to conversation

Driver core: Reduce the level of request_firmware() messages

PATCH In review Rafael J. Wysocki 5 participants 14 messages Feb 27, 2010 – Mar 16, 2010 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Driver core: Reduce the level of request_firmware() messages

From: Rafael J. Wysocki <[email protected]>

The messages from _request_firmware() informing that firmware is being requested or built-in firmware is going to be used are printed at KERN_INFO, which produces lots of noise on systems with huge numbers of AMD CPUs. Reduce the level of these messages to KERN_DEBUG to get rid of that noise.

---
 drivers/base/firmware_class.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/base/firmware_class.c +2 -3
Index: linux-2.6.32-SLE11-SP1/drivers/base/firmware_class.c
===================================================================
@@ -487,15 +487,14 @@ _request_firmware(const struct firmware 
 	     builtin++) {
 		if (strcmp(name, builtin->name))
 			continue;
-		dev_info(device, "firmware: using built-in firmware %s\n",
-			 name);
+		dev_dbg(device, "firmware: using built-in firmware %s\n", name);
 		firmware->size = builtin->size;
 		firmware->data = builtin->data;
 		return 0;
 	}
 
 	if (uevent)
-		dev_info(device, "firmware: requesting %s\n", name);
+		dev_dbg(device, "firmware: requesting %s\n", name);
 
 	retval = fw_setup_device(firmware, &f_dev, name, device, uevent);
 	if (retval)
#1 lore raw
Quoted 9 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The messages from _request_firmware() informing that firmware is being requested or built-in firmware is going to be used are printed at KERN_INFO, which produces lots of noise on systems with huge numbers of AMD CPUs. Reduce the level of these messages to KERN_DEBUG to get rid of that noise.

Looks good, I'll queue it up on Tuesday.

thanks,

greg k-h

#2 lore raw
In reply to Rafael J. Wysocki

Hello Rafael,

Quoted 8 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The messages from _request_firmware() informing that firmware is being requested or built-in firmware is going to be used are printed at KERN_INFO, which produces lots of noise on systems with huge numbers of AMD CPUs.  Reduce the level of these messages to KERN_DEBUG to get rid of that noise.

Which firmware we are using is very useful information. Because of huge numbers of CPUs it seems noise then better provide the information for first cpu and for the rest of the CPUs you can show by KERN_DEBUG.

Thanks,
--
Jaswinder Singh.

Quoted 33 lines

---
 drivers/base/firmware_class.c |    5 ++---

 1 file changed, 2 insertions(+), 3 deletions(-)

Index: linux-2.6.32-SLE11-SP1/drivers/base/firmware_class.c
===================================================================

drivers/base/firmware_class.c +2 -4
@@ -487,15 +487,14 @@ _request_firmware(const struct firmware
             builtin++) {
                if (strcmp(name, builtin->name))
                        continue;
-               dev_info(device, "firmware: using built-in firmware %s\n",
-                        name);
+               dev_dbg(device, "firmware: using built-in firmware %s\n", name);
                firmware->size = builtin->size;
                firmware->data = builtin->data;
                return 0;
        }
 
        if (uevent)
-               dev_info(device, "firmware: requesting %s\n", name);
+               dev_dbg(device, "firmware: requesting %s\n", name);
 
        retval = fw_setup_device(firmware, &f_dev, name, device, uevent);
        if (retval)
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

#3 lore raw
Quoted 12 lines · Jaswinder Singh Rajput

Hello Rafael,

Quoted 8 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The messages from _request_firmware() informing that firmware is being requested or built-in firmware is going to be used are printed at KERN_INFO, which produces lots of noise on systems with huge numbers of AMD CPUs. Reduce the level of these messages to KERN_DEBUG to get rid of that noise.

Quoted 4 lines

Which firmware we are using is very useful information. Because of huge numbers of CPUs it seems noise then better provide the information for first cpu and for the rest of the CPUs you can show by KERN_DEBUG.

That would have been better indeed, but the problem is _request_firmware() doesn't allow us to change the level of its messages on demand.

Rafael

#4 lore raw

Hello Rafael,

Quoted 11 lines · Rafael J. Wysocki
Quoted 10 lines · Jaswinder Singh Rajput
Quoted 8 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The messages from _request_firmware() informing that firmware is being requested or built-in firmware is going to be used are printed at KERN_INFO, which produces lots of noise on systems with huge numbers of AMD CPUs. Reduce the level of these messages to KERN_DEBUG to get rid of that noise.

Quoted 7 lines
Quoted 4 lines

Which firmware we are using is very useful information. Because of huge numbers of CPUs it seems noise then better provide the information for first cpu and for the rest of the CPUs you can show by KERN_DEBUG.

That would have been better indeed, but the problem is _request_firmware() doesn't allow us to change the level of its messages on demand.

Can we try this :

	if (smp_processor_id())
		dev_dbg(..);
	else
		dev_info(..);

Thanks,
--
Jaswinder Singh.

#5 lore raw
Quoted 22 lines · Jaswinder Singh Rajput

Hello Rafael,

Quoted 11 lines · Rafael J. Wysocki
Quoted 10 lines · Jaswinder Singh Rajput
Quoted 8 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The messages from _request_firmware() informing that firmware is being requested or built-in firmware is going to be used are printed at KERN_INFO, which produces lots of noise on systems with huge numbers of AMD CPUs. Reduce the level of these messages to KERN_DEBUG to get rid of that noise.

Quoted 7 lines
Quoted 4 lines

Which firmware we are using is very useful information. Because of huge numbers of CPUs it seems noise then better provide the information for first cpu and for the rest of the CPUs you can show by KERN_DEBUG.

That would have been better indeed, but the problem is _request_firmware() doesn't allow us to change the level of its messages on demand.

Quoted 6 lines

Can we try this :

	if (smp_processor_id())
		dev_dbg(..);
	else
		dev_info(..);

Well, it doesn't look particularly nice, does it?

Besides, say we're requesting firmware for a non-CPU device which happens to run on CPU1. Then, dev_dbg() will be used, which most likely is not what we want.

Rafael

#6 lore raw

Hello Rafael,

Quoted 29 lines · Rafael J. Wysocki
Quoted 21 lines · Jaswinder Singh Rajput
Quoted 11 lines · Rafael J. Wysocki
Quoted 10 lines · Jaswinder Singh Rajput
Quoted 8 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The messages from _request_firmware() informing that firmware is being requested or built-in firmware is going to be used are printed at KERN_INFO, which produces lots of noise on systems with huge numbers of AMD CPUs.  Reduce the level of these messages to KERN_DEBUG to get rid of that noise.

Quoted 7 lines
Quoted 4 lines

Which firmware we are using is very useful information. Because of huge numbers of CPUs it seems noise then better provide the information for first cpu and for the rest of the CPUs you can show by KERN_DEBUG.

That would have been better indeed, but the problem is _request_firmware() doesn't allow us to change the level of its messages on demand.

Quoted 6 lines

Can we try this :

      if (smp_processor_id())
              dev_dbg(..);
      else
              dev_info(..);

Quoted 6 lines

Well, it doesn't look particularly nice, does it?

Besides, say we're requesting firmware for a non-CPU device which happens to run on CPU1.  Then, dev_dbg() will be used, which most likely is not what we want.

Yes, you are right. But atleast can you try it once and show the output with and without this.

Thanks,
--
Jaswinder.

#7 lore raw
Quoted 34 lines · Jaswinder Singh Rajput

Hello Rafael,

Quoted 31 lines · Rafael J. Wysocki
Quoted 21 lines · Jaswinder Singh Rajput
Quoted 11 lines · Rafael J. Wysocki
Quoted 10 lines · Jaswinder Singh Rajput
Quoted 8 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The messages from _request_firmware() informing that firmware is being requested or built-in firmware is going to be used are printed at KERN_INFO, which produces lots of noise on systems with huge numbers of AMD CPUs.  Reduce the level of these messages to KERN_DEBUG to get rid of that noise.

Quoted 7 lines
Quoted 4 lines

Which firmware we are using is very useful information. Because of huge numbers of CPUs it seems noise then better provide the information for first cpu and for the rest of the CPUs you can show by KERN_DEBUG.

That would have been better indeed, but the problem is _request_firmware() doesn't allow us to change the level of its messages on demand.

Quoted 6 lines

Can we try this :

      if (smp_processor_id())
              dev_dbg(..);
      else
              dev_info(..);

Well, it doesn't look particularly nice, does it?

Quoted 7 lines
Quoted 4 lines

Besides, say we're requesting firmware for a non-CPU device which happens to run on CPU1.  Then, dev_dbg() will be used, which most likely is not what we want.

Yes, you are right. But atleast can you try it once and show the output with and without this.

Was there ever a resolution to this? Rafael, do you want me to apply your original patch now?

thanks,

greg k-h

#8 lore raw
Quoted 40 lines · Greg KH
Quoted 39 lines · Jaswinder Singh Rajput

Hello Rafael,

Quoted 35 lines · Rafael J. Wysocki
Quoted 21 lines · Jaswinder Singh Rajput
Quoted 11 lines · Rafael J. Wysocki
Quoted 10 lines · Jaswinder Singh Rajput
Quoted 8 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

The messages from _request_firmware() informing that firmware is being requested or built-in firmware is going to be used are printed at KERN_INFO, which produces lots of noise on systems with huge numbers of AMD CPUs. Reduce the level of these messages to KERN_DEBUG to get rid of that noise.

Quoted 7 lines
Quoted 4 lines

Which firmware we are using is very useful information. Because of huge numbers of CPUs it seems noise then better provide the information for first cpu and for the rest of the CPUs you can show by KERN_DEBUG.

That would have been better indeed, but the problem is _request_firmware() doesn't allow us to change the level of its messages on demand.

Quoted 6 lines

Can we try this :

      if (smp_processor_id())
              dev_dbg(..);
      else
              dev_info(..);

Well, it doesn't look particularly nice, does it?

Besides, say we're requesting firmware for a non-CPU device which happens to run on CPU1. Then, dev_dbg() will be used, which most likely is not what we want.

Quoted 4 lines
Quoted 2 lines

Yes, you are right. But atleast can you try it once and show the output with and without this.

Was there ever a resolution to this?

Nope.

Quoted 1 line

Rafael, do you want me to apply your original patch now?

I still think it's a good idea. The information about what firmware is being used doesn't seem to be very useful for anything but debugging, so I think KERN_DEBUG is actually the right level for these messages.

Rafael

#9 lore raw

Hello Rafael,

Quoted 5 lines · Rafael J. Wysocki

I still think it's a good idea.  The information about what firmware is being used doesn't seem to be very useful for anything but debugging, so I think KERN_DEBUG is actually the right level for these messages.

Can we use printk_once()

Thanks,
--
Jaswinder Singh.

#10 lore raw
Quoted 10 lines · Jaswinder Singh Rajput

Hello Rafael,

Quoted 5 lines · Rafael J. Wysocki

I still think it's a good idea. The information about what firmware is being used doesn't seem to be very useful for anything but debugging, so I think KERN_DEBUG is actually the right level for these messages.

Can we use printk_once()

Yes, I guess so.

OK, I'll rework the patch.

Thanks,
Rafael

#11 lore raw

Hello Rafael,

Quoted 10 lines · Rafael J. Wysocki
Quoted 9 lines · Jaswinder Singh Rajput

Hello Rafael,

Quoted 5 lines · Rafael J. Wysocki

I still think it's a good idea.  The information about what firmware is being used doesn't seem to be very useful for anything but debugging, so I think KERN_DEBUG is actually the right level for these messages.

Quoted 6 lines
Quoted 1 line

Can we use printk_once()

Yes, I guess so.

OK, I'll rework the patch.

Good, so you need to prepare printk_once() with condition like in our case so that it prints once for a particular name.

Thanks,
--
Jaswinder Singh.

#12 lore raw
In reply to Jaswinder Singh Rajput
Quoted 10 lines · Jaswinder Singh Rajput

Hello Rafael,

Quoted 5 lines · Rafael J. Wysocki

I still think it's a good idea.  The information about what firmware is being used doesn't seem to be very useful for anything but debugging, so I think KERN_DEBUG is actually the right level for these messages.

Can we use printk_once()

No, I'd rather use dev_dbg() that way we can dynamically turn it on and off as needed. I took Rafael's original patch.

Funny thing is, someone else also sent the same patch, so there must be others wanting this change :)

thanks,

greg k-h

#13 lore raw
Quoted 10 lines · Greg KH
Quoted 9 lines · Jaswinder Singh Rajput

Hello Rafael,

Quoted 5 lines · Rafael J. Wysocki

I still think it's a good idea. The information about what firmware is being used doesn't seem to be very useful for anything but debugging, so I think KERN_DEBUG is actually the right level for these messages.

Quoted 4 lines
Quoted 1 line

Can we use printk_once()

No, I'd rather use dev_dbg() that way we can dynamically turn it on and off as needed. I took Rafael's original patch.

OK, thanks!

Quoted 2 lines

Funny thing is, someone else also sent the same patch, so there must be others wanting this change :)

I know SGI wants it at least.

Rafael