Some simple Checkpatch.pl cleanup
Subsystems (28)
Hi all,
here's some simple Checkpatch.pl cleanup.
They apply and compile on latest Linus' git tree¹ as well as on next-20100226.
Thanks a lot for your work,
Andrea
--------------------------
¹ 06a79b82b2a3e4bebb9a20638ca208c780e9e507
PATCH 1/66 arch/parisc/include/asm/percpu.h: Checkpatch cleanup
arch/parisc/include/asm/percpu.h:6: ERROR: trailing whitespace
--- arch/parisc/include/asm/percpu.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/parisc/include/asm/percpu.h +1 -2
@@ -3,5 +3,4 @@#include <asm-generic/percpu.h> -#endif - +#endif
Signature · 1 line
1.7.0.90.g251a4
PATCH 2/66 fs/befs/inode.h: Checkpatch cleanup
In reply to Andrea Gelminifs/befs/inode.h:3: ERROR: trailing whitespace
--- fs/befs/inode.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
fs/befs/inode.h +1 -2
@@ -1,8 +1,7 @@/* * inode.h -* +* */ int befs_check_inode (struct super_block *sb,befs_inode * raw_inode,befs_blocknr_t inode); -
Signature · 1 line
1.7.0.90.g251a4
PATCH 3/66 arch/um/include/asm/mmu.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/include/asm/mmu.h:1: ERROR: trailing whitespace
--- arch/um/include/asm/mmu.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/um/include/asm/mmu.h +1 -2
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2002 Jeff Dike ([email protected]) * Licensed under the GPL */
@@ -9,4 +9,3 @@#include "um_mmu.h" #endif -
Signature · 1 line
1.7.0.90.g251a4
PATCH 4/66 arch/um/include/asm/irq_vectors.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/include/asm/irq_vectors.h:1: ERROR: trailing whitespace
--- arch/um/include/asm/irq_vectors.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/um/include/asm/irq_vectors.h +1 -2
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2002 Jeff Dike ([email protected]) * Licensed under the GPL */
@@ -7,4 +7,3 @@#define __UM_IRQ_VECTORS_H#endif -
Signature · 1 line
1.7.0.90.g251a4
PATCH 5/66 arch/cris/include/asm/irq.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/cris/include/asm/irq.h:7: ERROR: trailing whitespace arch/cris/include/asm/irq.h:8: ERROR: trailing whitespace
--- arch/cris/include/asm/irq.h | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
arch/cris/include/asm/irq.h +2 -4
@@ -4,10 +4,8 @@#include <arch/irq.h> static inline int irq_canonicalize (int irq) -{ -return irq; +{ +return irq; }#endif /* _ASM_IRQ_H */ - -
Signature · 1 line
1.7.0.90.g251a4
PATCH 6/66 arch/um/sys-ia64/sysdep/syscalls.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/sys-ia64/sysdep/syscalls.h:1: ERROR: trailing whitespace
--- arch/um/sys-ia64/sysdep/syscalls.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/sys-ia64/sysdep/syscalls.h +1 -1
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2000 Jeff Dike ([email protected]) * Licensed under the GPL */
Signature · 1 line
1.7.0.90.g251a4
PATCH 7/66 arch/um/sys-ia64/sysdep/sigcontext.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/sys-ia64/sysdep/sigcontext.h:1: ERROR: trailing whitespace
--- arch/um/sys-ia64/sysdep/sigcontext.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/um/sys-ia64/sysdep/sigcontext.h +1 -2
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2000 Jeff Dike ([email protected]) * Licensed under the GPL */
@@ -7,4 +7,3 @@#define __SYSDEP_IA64_SIGCONTEXT_H#endif -
Signature · 1 line
1.7.0.90.g251a4
PATCH 8/66 arch/arm/mach-sa1100/include/mach/timex.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/arm/mach-sa1100/include/mach/timex.h:6: ERROR: trailing whitespace
--- arch/arm/mach-sa1100/include/mach/timex.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-sa1100/include/mach/timex.h +1 -1
@@ -3,7 +3,7 @@* * SA1100 architecture timex specifications * -* Copyright (C) 1998 +* Copyright (C) 1998 */ /*
Signature · 1 line
1.7.0.90.g251a4
PATCH 9/66 arch/um/drivers/xterm.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/drivers/xterm.h:1: ERROR: trailing whitespace
--- arch/um/drivers/xterm.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/drivers/xterm.h +1 -1
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2002 Jeff Dike ([email protected]) * Licensed under the GPL */
Signature · 1 line
1.7.0.90.g251a4
PATCH 10/66 arch/um/kernel/gprof_syms.c: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/kernel/gprof_syms.c:1: ERROR: trailing whitespace
--- arch/um/kernel/gprof_syms.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/kernel/gprof_syms.c +1 -1
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2001 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com) * Licensed under the GPL */
Signature · 1 line
1.7.0.90.g251a4
PATCH 11/66 arch/um/drivers/stdio_console.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/drivers/stdio_console.h:1: ERROR: trailing whitespace
--- arch/um/drivers/stdio_console.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/um/drivers/stdio_console.h +1 -2
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2000 Jeff Dike ([email protected]) * Licensed under the GPL */
@@ -8,4 +8,3 @@extern void save_console_flags (void );#endif -
Signature · 1 line
1.7.0.90.g251a4
PATCH 12/66 arch/cris/include/asm/kmap_types.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/cris/include/asm/kmap_types.h:5: ERROR: trailing whitespace
--- arch/cris/include/asm/kmap_types.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/cris/include/asm/kmap_types.h +1 -1
@@ -2,7 +2,7 @@#define _ASM_KMAP_TYPES_H/* Dummy header just to define km_type. None of this -* is actually used on cris. +* is actually used on cris. */ #include <asm-generic/kmap_types.h>
Signature · 1 line
1.7.0.90.g251a4
PATCH 13/66 arch/h8300/include/asm/md.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/h8300/include/asm/md.h:2: ERROR: trailing whitespace arch/h8300/include/asm/md.h:5: ERROR: trailing whitespace
--- arch/h8300/include/asm/md.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/h8300/include/asm/md.h +2 -2
@@ -1,8 +1,8 @@/* -* md.h: High speed xor_block operation for RAID4/5 +* md.h: High speed xor_block operation for RAID4/5 * */ - +#ifndef __ASM_MD_H#define __ASM_MD_H
Signature · 1 line
1.7.0.90.g251a4
PATCH 14/66 arch/um/sys-ia64/sysdep/ptrace.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/sys-ia64/sysdep/ptrace.h:1: ERROR: trailing whitespace
--- arch/um/sys-ia64/sysdep/ptrace.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/um/sys-ia64/sysdep/ptrace.h +1 -2
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2000 Jeff Dike ([email protected]) * Licensed under the GPL */
@@ -13,4 +13,3 @@ struct sys_pt_regs {#define EMPTY_REGS { 0 }#endif -
Signature · 1 line
1.7.0.90.g251a4
PATCH 15/66 arch/um/drivers/ssl.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/drivers/ssl.h:1: ERROR: trailing whitespace
--- arch/um/drivers/ssl.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/um/drivers/ssl.h +1 -2
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2000 Jeff Dike ([email protected]) * Licensed under the GPL */
@@ -10,4 +10,3 @@ extern int ssl_read(int fd, int line);extern void ssl_receive_char (int line,char ch);#endif -
Signature · 1 line
1.7.0.90.g251a4
PATCH 16/66 arch/sparc/include/asm/setup.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/sparc/include/asm/setup.h:2: ERROR: trailing whitespace
--- arch/sparc/include/asm/setup.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/sparc/include/asm/setup.h +1 -1
@@ -1,5 +1,5 @@/* -* Just a place holder. +* Just a place holder. */ #ifndef _SPARC_SETUP_H
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 16/66] arch/sparc/include/asm/setup.h: Checkpatch cleanup
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:50:57 +0100
Quoted 3 lines
arch/sparc/include/asm/setup.h:2: ERROR: trailing whitespaceSigned-off-by Andrea Gelmini <[email protected]>
PATCH 17/66 arch/um/sys-i386/asm/archparam.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/sys-i386/asm/archparam.h:1: ERROR: trailing whitespace
--- arch/um/sys-i386/asm/archparam.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/um/sys-i386/asm/archparam.h +1 -2
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2000 - 2003 Jeff Dike ([email protected]) * Licensed under the GPL */
@@ -13,4 +13,3 @@#endif #endif -
Signature · 1 line
1.7.0.90.g251a4
PATCH 18/66 arch/um/include/shared/skas_ptrace.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/include/shared/skas_ptrace.h:1: ERROR: trailing whitespace
--- arch/um/include/shared/skas_ptrace.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/include/shared/skas_ptrace.h +1 -1
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2000 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com) * Licensed under the GPL */
Signature · 1 line
1.7.0.90.g251a4
PATCH 19/66 arch/parisc/include/asm/current.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/parisc/include/asm/current.h:8: ERROR: "foo * bar" should be "foo *bar" arch/parisc/include/asm/current.h:12: ERROR: trailing whitespace
--- arch/parisc/include/asm/current.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/parisc/include/asm/current.h +2 -2
@@ -5,11 +5,11 @@struct task_struct ; -static inline struct task_struct *get_current (void ) +static inline struct task_struct *get_current (void ) {return current_thread_info ()->task; } - +#define current get_current()#endif /* !(_PARISC_CURRENT_H) */
Signature · 1 line
1.7.0.90.g251a4
PATCH 20/66 arch/cris/include/asm/current.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/cris/include/asm/current.h:8: ERROR: "foo * bar" should be "foo *bar" arch/cris/include/asm/current.h:10: ERROR: code indent should use tabs where possible arch/cris/include/asm/current.h:12: ERROR: trailing whitespace
--- arch/cris/include/asm/current.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
arch/cris/include/asm/current.h +3 -3
@@ -5,11 +5,11 @@struct task_struct ; -static inline struct task_struct *get_current (void ) +static inline struct task_struct *get_current (void ) { -return current_thread_info ()->task; +return current_thread_info ()->task; } - +#define current get_current()#endif /* !(_CRIS_CURRENT_H) */
Signature · 1 line
1.7.0.90.g251a4
PATCH 21/66 arch/um/include/shared/sigio.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/include/shared/sigio.h:1: ERROR: trailing whitespace
--- arch/um/include/shared/sigio.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/include/shared/sigio.h +1 -1
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2002 Jeff Dike ([email protected]) * Licensed under the GPL */
Signature · 1 line
1.7.0.90.g251a4
PATCH 22/66 sound/oss/v_midi.h: Checkpatch cleanup
In reply to Andrea Gelminisound/oss/v_midi.h:5: ERROR: code indent should use tabs where possible sound/oss/v_midi.h:7: ERROR: trailing whitespace
--- sound/oss/v_midi.h | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
sound/oss/v_midi.h +2 -3
@@ -2,9 +2,9 @@ typedef struct vmidi_devc {int dev;/* State variables */ -int opened; +int opened;spinlock_t lock; - +/* MIDI fields */ int my_mididev;int pair_mididev;
@@ -12,4 +12,3 @@ typedef struct vmidi_devc {int intr_active;void (*midi_input_intr) (int dev,unsigned char data); } vmidi_devc; -
Signature · 1 line
1.7.0.90.g251a4
Takashi Iwai
AppliedRe: [PATCH 22/66] sound/oss/v_midi.h: Checkpatch cleanup
At Sat, 27 Feb 2010 17:51:03 +0100,
Quoted 5 lines · Andrea Gelmini
sound/oss/v_midi.h:5: ERROR: code indent should use tabs where possiblesound/oss/v_midi.h:7: ERROR: trailing whitespaceSigned-off-by Andrea Gelmini <[email protected]>
Applied all three patches for sound/* now. Thanks.
Takashi
Re: [PATCH 22/66] sound/oss/v_midi.h: Checkpatch cleanup
2010/3/2 Takashi Iwai <[email protected]>:
Hi Takashi,
thanks a lot for you reply.
Quoted 1 line
Applied all three patches for
sound/*now. Thanks.
Thanks a lot.
If you care I can check all sound subtree.
Thanks again,
Andrea
PATCH 23/66 arch/cris/include/arch-v10/arch/pgtable.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/cris/include/arch-v10/arch/pgtable.h:5: ERROR: trailing whitespace
--- arch/cris/include/arch-v10/arch/pgtable.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/cris/include/arch-v10/arch/pgtable.h +1 -2
@@ -2,7 +2,7 @@#define _CRIS_ARCH_PGTABLE_H/* -* Kernels own virtual memory area. +* Kernels own virtual memory area. */ #ifdef CONFIG_CRIS_LOW_MAP
@@ -14,4 +14,3 @@#endif #endif -
Signature · 1 line
1.7.0.90.g251a4
PATCH 24/66 arch/h8300/include/asm/tlb.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/h8300/include/asm/tlb.h:1: ERROR: trailing whitespace arch/h8300/include/asm/tlb.h:2: ERROR: trailing whitespace arch/h8300/include/asm/tlb.h:10: ERROR: trailing whitespace arch/h8300/include/asm/tlb.h:11: ERROR: trailing whitespace
--- arch/h8300/include/asm/tlb.h | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
arch/h8300/include/asm/tlb.h +4 -4
@@ -1,5 +1,5 @@ -/* -include/asm-h8300/tlb.h +/* +include/asm-h8300/tlb.h */ #ifndef __H8300_TLB_H__
@@ -7,8 +7,8 @@#define tlb_flush (tlb) do { } while(0) -/* -include/asm-h8300/tlb.h +/* +include/asm-h8300/tlb.h */ #ifndef __H8300_TLB_H__
Signature · 1 line
1.7.0.90.g251a4
PATCH 25/66 arch/h8300/include/asm/target_time.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/h8300/include/asm/target_time.h:3: ERROR: trailing whitespace arch/h8300/include/asm/target_time.h:4: ERROR: code indent should use tabs where possible
--- arch/h8300/include/asm/target_time.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/h8300/include/asm/target_time.h +2 -2
@@ -1,4 +1,4 @@extern int platform_timer_setup (void (*timer_int)(int ,void *,struct pt_regs *));extern void platform_timer_eoi (void ); -extern void platform_gettod (unsigned int *year,unsigned int *mon,unsigned int *day, -unsigned int *hour,unsigned int *min,unsigned int *sec); +extern void platform_gettod (unsigned int *year,unsigned int *mon,unsigned int *day, +unsigned int *hour,unsigned int *min,unsigned int *sec);
Signature · 1 line
1.7.0.90.g251a4
PATCH 26/66 fs/befs/btree.h: Checkpatch cleanup
In reply to Andrea Gelminifs/befs/btree.h:3: ERROR: trailing whitespace fs/befs/btree.h:12: ERROR: "foo * bar" should be "foo *bar"
--- fs/befs/btree.h | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
fs/befs/btree.h +2 -3
@@ -1,6 +1,6 @@/* * btree.h -* +* */
@@ -9,5 +9,4 @@ int befs_btree_find(struct super_block *sb, befs_data_stream * ds,int befs_btree_read (struct super_block *sb,befs_data_stream * ds,loff_t key_no,size_t bufsize,char *keybuf, -size_t * keysize,befs_off_t * value); - +size_t *keysize,befs_off_t *value);
Signature · 1 line
1.7.0.90.g251a4
PATCH 27/66 include/linux/raw.h: Checkpatch cleanup
In reply to Andrea Gelminiinclude/linux/raw.h:6: ERROR: space prohibited after that open parenthesis '(' include/linux/raw.h:6: ERROR: space prohibited before that close parenthesis ')' include/linux/raw.h:7: ERROR: space prohibited after that open parenthesis '(' include/linux/raw.h:7: ERROR: space prohibited before that close parenthesis ')' include/linux/raw.h:9: ERROR: trailing whitespace include/linux/raw.h:10: ERROR: open brace '{' following struct go on the same line
--- include/linux/raw.h | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)
include/linux/raw.h +3 -4
@@ -3,11 +3,10 @@#include <linux/types.h> -#define RAW_SETBIND _IO( 0xac, 0 ) -#define RAW_GETBIND _IO( 0xac, 1 ) +#define RAW_SETBIND _IO(0xac, 0) +#define RAW_GETBIND _IO(0xac, 1) -struct raw_config_request -{ +struct raw_config_request {int raw_minor;__u64 block_major;__u64 block_minor;
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 27/66] include/linux/raw.h: Checkpatch cleanup
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:08 +0100
Quoted 8 lines
include/linux/raw.h:6: ERROR: space prohibited after that open parenthesis '('include/linux/raw.h:6: ERROR: space prohibited before that close parenthesis ')'include/linux/raw.h:7: ERROR: space prohibited after that open parenthesis '('include/linux/raw.h:7: ERROR: space prohibited before that close parenthesis ')'include/linux/raw.h:9: ERROR: trailing whitespaceinclude/linux/raw.h:10: ERROR: open brace '{' following struct go on the same lineSigned-off-by Andrea Gelmini <[email protected]>
PATCH 28/66 arch/cris/include/asm/unaligned.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/cris/include/asm/unaligned.h:5: ERROR: trailing whitespace
--- arch/cris/include/asm/unaligned.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/cris/include/asm/unaligned.h +1 -1
@@ -2,7 +2,7 @@#define _ASM_CRIS_UNALIGNED_H/* -* CRIS can do unaligned accesses itself. +* CRIS can do unaligned accesses itself. */ #include <linux/unaligned/access_ok.h> #include <linux/unaligned/generic.h>
Signature · 1 line
1.7.0.90.g251a4
PATCH 29/66 arch/s390/include/asm/unaligned.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/s390/include/asm/unaligned.h:5: ERROR: trailing whitespace
--- arch/s390/include/asm/unaligned.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/s390/include/asm/unaligned.h +1 -1
@@ -2,7 +2,7 @@#define _ASM_S390_UNALIGNED_H/* -* The S390 can do unaligned accesses itself. +* The S390 can do unaligned accesses itself. */ #include <linux/unaligned/access_ok.h> #include <linux/unaligned/generic.h>
Signature · 1 line
1.7.0.90.g251a4
PATCH 30/66 include/net/x25device.h: Checkpatch cleanup
In reply to Andrea Gelminiinclude/net/x25device.h:13: ERROR: trailing whitespace
--- include/net/x25device.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/net/x25device.h +1 -1
@@ -10,7 +10,7 @@ static inline __be16 x25_type_trans(struct sk_buff *skb, struct net_device *dev) skb->dev = dev;skb_reset_mac_header (skb); skb->pkt_type =PACKET_HOST ; - + return htons(ETH_P_X25); }#endif
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 30/66] include/net/x25device.h: Checkpatch cleanup
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:11 +0100
Quoted 3 lines
include/net/x25device.h:13: ERROR: trailing whitespaceSigned-off-by Andrea Gelmini <[email protected]>
andrew hendry
Acked-byRe: [PATCH 30/66] include/net/x25device.h: Checkpatch cleanup
Quoted 9 lines · David Miller
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:11 +0100Quoted 3 lines
include/net/x25device.h:13: ERROR: trailing whitespaceSigned-off-by Andrea Gelmini <[email protected]>Acked-by David S. Miller <[email protected]>
PATCH 31/66 include/linux/tc_act/tc_defact.h: Checkpatch cleanup
In reply to Andrea Gelminiinclude/linux/tc_act/tc_defact.h:9: ERROR: trailing whitespace include/linux/tc_act/tc_defact.h:9: ERROR: code indent should use tabs where possible
--- include/linux/tc_act/tc_defact.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/tc_act/tc_defact.h +1 -1
@@ -6,7 +6,7 @@struct tc_defact {tc_gen ; }; - +enum {TCA_DEF_UNSPEC ,TCA_DEF_TM ,
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 31/66] include/linux/tc_act/tc_defact.h: Checkpatch cleanup
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:12 +0100
Quoted 4 lines
include/linux/tc_act/tc_defact.h:9: ERROR: trailing whitespaceinclude/linux/tc_act/tc_defact.h:9: ERROR: code indent should use tabs where possibleSigned-off-by Andrea Gelmini <[email protected]>
PATCH 32/66 arch/parisc/include/asm/parport.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/parisc/include/asm/parport.h:1: ERROR: trailing whitespace arch/parisc/include/asm/parport.h:11: WARNING: space prohibited between function name and open parenthesis '('
--- arch/parisc/include/asm/parport.h | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
arch/parisc/include/asm/parport.h +2 -3
@@ -1,4 +1,4 @@ -/* +/* * * parport.h: ia32-compatible parport initialisation *
@@ -8,8 +8,7 @@#define _ASM_PARPORT_H 1 -static int __devinit parport_pc_find_nonpci_ports (int autoirq,int autodma) -{ +static int __devinit parport_pc_find_nonpci_ports (int autoirq,int autodma) {/* nothing ! */ return 0 ; }
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch cleanup
Quoted 2 lines · Andrea Gelmini
arch/parisc/include/asm/parport.h:1: ERROR: trailing whitespacearch/parisc/include/asm/parport.h:11: WARNING: space prohibited betwe=
en function name and open parenthesis '('
arch/parisc/include/=
Quoted 7 lines
Signed-off-by Andrea Gelmini <[email protected]>---
=C2=A0arch/parisc/include/asm/parport.h | =C2=A0 =C2=A05 ++--- =C2=A01 files changed, 2 insertions(+), 3 deletions(-)arch/parisc/include/= renamed from arch/parisc/include/asm/parport.h +0
-0
asm/parport.h
Quoted 9 lines
index 00d9cc3..5cbf98b 100644
arch/parisc/include/asm/parport.h +0
-0@@ -8,8 +8,7 @@=C2=A0#define
_ASM_PARPORT_H1-static int
__devinitparport_pc_find_nonpci_ports(int autoirq, int =
autodma)
arch/parisc/include/asm/parport.h
Quoted 2 lines
arch/parisc/include/asm/parport.h +1
-1-{ +static int __devinit parport_pc_find_nonpci_ports (int autoirq, int =
autodma) {
This looks very much in contradiction with CodingStyle, since parport_pc_find_nonpci_ports() is a function, and it's not a fix for the quoted "WARNING". I'm guessing this wasn't intended the way it is.
HTH
T-Bone
--=20
Thibaut VARENE
http://www.parisc-linux.org/~varenet/
Re: [PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch cleanup
2010/2/27 Thibaut VARENE <[email protected]>:
Hi Thubaut,
thanks a lot for you answer.
Quoted 3 lines
This looks very much in contradiction with CodingStyle, since
parport_pc_find_nonpci_ports()is a function, and it's not a fix for the quoted "WARNING". I'm guessing this wasn't intended the way it is.
My fault. I'll look at checkpatch.pl regexp to resolve false positive (I've found a few other regressions).
Thanks again,
Andrea
PATCH 33/66 include/linux/uts.h: Checkpatch cleanup
In reply to Andrea Gelminiinclude/linux/uts.h:5: ERROR: trailing whitespace
--- include/linux/uts.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/uts.h +1 -1
@@ -2,7 +2,7 @@#define _LINUX_UTS_H/* -* Defines for what uname() should return +* Defines for what uname() should return */ #ifndef UTS_SYSNAME #define UTS_SYSNAME "Linux"
Signature · 1 line
1.7.0.90.g251a4
PATCH 34/66 arch/um/os-Linux/drivers/etap.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/os-Linux/drivers/etap.h:1: ERROR: trailing whitespace
--- arch/um/os-Linux/drivers/etap.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/os-Linux/drivers/etap.h +1 -1
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2001 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com) * Licensed under the GPL */
Signature · 1 line
1.7.0.90.g251a4
PATCH 35/66 arch/cris/include/arch-v10/arch/tlb.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/cris/include/arch-v10/arch/tlb.h:6: ERROR: trailing whitespace
--- arch/cris/include/arch-v10/arch/tlb.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/cris/include/arch-v10/arch/tlb.h +1 -1
@@ -3,7 +3,7 @@/* The TLB can host up to 64 different mm contexts at the same time. * The last page_id is never running - it is used as an invalid page_id -* so we can make TLB entries that will never match. +* so we can make TLB entries that will never match. */ #define NUM_TLB_ENTRIES 64#define NUM_PAGEID 64
Signature · 1 line
1.7.0.90.g251a4
PATCH 36/66 arch/um/include/shared/ubd_user.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/include/shared/ubd_user.h:1: ERROR: trailing whitespace
--- arch/um/include/shared/ubd_user.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/um/include/shared/ubd_user.h +1 -2
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2000 Jeff Dike ([email protected]) * Copyright (C) 2001 RidgeRun, Inc ([email protected]) * Licensed under the GPL
@@ -13,4 +13,3 @@ extern int io_thread(void *arg);extern int kernel_fd;#endif -
Signature · 1 line
1.7.0.90.g251a4
PATCH 37/66 include/linux/tc_act/tc_ipt.h: Checkpatch cleanup
In reply to Andrea Gelminiinclude/linux/tc_act/tc_ipt.h:19: ERROR: trailing whitespace include/linux/tc_act/tc_ipt.h:19: ERROR: code indent should use tabs where possible
--- include/linux/tc_act/tc_ipt.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
include/linux/tc_act/tc_ipt.h +0 -1
@@ -16,5 +16,4 @@ enum {__TCA_IPT_MAX };#define TCA_IPT_MAX (__TCA_IPT_MAX - 1) -#endif
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 37/66] include/linux/tc_act/tc_ipt.h: Checkpatch cleanup
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:18 +0100
Quoted 4 lines
include/linux/tc_act/tc_ipt.h:19: ERROR: trailing whitespaceinclude/linux/tc_act/tc_ipt.h:19: ERROR: code indent should use tabs where possibleSigned-off-by Andrea Gelmini <[email protected]>
PATCH 38/66 sound/oss/coproc.h: Checkpatch cleanup
In reply to Andrea Gelminisound/oss/coproc.h:7: ERROR: trailing whitespace
--- sound/oss/coproc.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
sound/oss/coproc.h +1 -1
@@ -4,7 +4,7 @@*/ /* -* Coprocessor access types +* Coprocessor access types */ #define COPR_CUSTOM 0x0001/* Custom applications */ #define COPR_MIDI 0x0002/* MIDI (MPU-401) emulation */
Signature · 1 line
1.7.0.90.g251a4
PATCH 39/66 arch/um/drivers/pcap_user.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/drivers/pcap_user.h:1: ERROR: trailing whitespace
--- arch/um/drivers/pcap_user.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/um/drivers/pcap_user.h +1 -2
@@ -1,4 +1,4 @@ -/* +/* * Copyright (C) 2002 Jeff Dike ([email protected]) * Licensed under the GPL */
@@ -18,4 +18,3 @@ struct pcap_data {extern const struct net_user_info pcap_user_info;extern int pcap_user_read (int fd,void *buf,int len,struct pcap_data *pri); -
Signature · 1 line
1.7.0.90.g251a4
PATCH 40/66 include/linux/netfilter/nf_conntrack_tuple_common.h: Checkpatch cleanup
In reply to Andrea Gelminiinclude/linux/netfilter/nf_conntrack_tuple_common.h:5: ERROR: open brace '{' following enum go on the same line
--- .../linux/netfilter/nf_conntrack_tuple_common.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
include/linux/netfilter/nf_conntrack_tuple_common.h +1 -2
@@ -1,8 +1,7 @@#ifndef _NF_CONNTRACK_TUPLE_COMMON_H#define _NF_CONNTRACK_TUPLE_COMMON_H -enum ip_conntrack_dir -{ +enum ip_conntrack_dir {IP_CT_DIR_ORIGINAL ,IP_CT_DIR_REPLY , IP_CT_DIR_MAX
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 40/66] include/linux/netfilter/nf_conntrack_tuple_common.h: Checkpatch cleanup
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:21 +0100
Quoted 3 lines
include/linux/netfilter/nf_conntrack_tuple_common.h:5: ERROR: open brace '{' following enum go on the same lineSigned-off-by Andrea Gelmini <[email protected]>
Patrick McHardy
AppliedRe: [PATCH 40/66] include/linux/netfilter/nf_conntrack_tuple_common.h: Checkpatch cleanup
Quoted 9 lines · David Miller
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:21 +0100Quoted 3 lines
include/linux/netfilter/nf_conntrack_tuple_common.h:5: ERROR: open brace '{' following enum go on the same lineSigned-off-by Andrea Gelmini <[email protected]>Acked-by David S. Miller <[email protected]>
Applied, thanks.
PATCH 41/66 drivers/md/linear.h: Checkpatch cleanup
In reply to Andrea Gelminidrivers/md/linear.h:12: ERROR: open brace '{' following struct go on the same line
--- drivers/md/linear.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/md/linear.h +1 -2
@@ -8,8 +8,7 @@ struct dev_info {typedef struct dev_info dev_info_t ; -struct linear_private_data -{ +struct linear_private_data {sector_t array_sectors;dev_info_t disks[0 ];struct rcu_head rcu;
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 41/66] drivers/md/linear.h: Checkpatch cleanup
Quoted 1 line · On Sat, 27 Feb 2010 17:51:22 +0100 Andrea Gelmini <[email protected]>…
drivers/md/linear.h:12: ERROR: open brace '{' following struct go on the same line
Thanks, but no thanks.
This just doesn't need cleaning up.
NeilBrown
Quoted 20 lines
Signed-off-by Andrea Gelmini <[email protected]>--- drivers/md/linear.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)drivers/md/linear.h +1
-2@@ -8,8 +8,7 @@ struct dev_info {typedef struct dev_info dev_info_t ; -struct linear_private_data -{ +struct linear_private_data {sector_t array_sectors;dev_info_t disks[0 ];struct rcu_head rcu;
PATCH 42/66 arch/mips/lib/libgcc.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/mips/lib/libgcc.h:21: ERROR: open brace '{' following union go on the same line
--- arch/mips/lib/libgcc.h | 3 +-- arch/sh/lib/libgcc.h | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
arch/mips/lib/libgcc.h +1 -2
@@ -17,8 +17,7 @@ struct DWstruct {#error I feel sick.#endif -typedef union -{ +typedef union {struct DWstruct s;long long ll; }DWunion ;
arch/sh/lib/libgcc.h +1 -2
@@ -17,8 +17,7 @@ struct DWstruct {#error I feel sick.#endif -typedef union -{ +typedef union {struct DWstruct s;long long ll; }DWunion ;
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 42/66] arch/mips/lib/libgcc.h: Checkpatch cleanup
Quoted 8 lines · Andrea Gelmini
arch/mips/lib/libgcc.h:21: ERROR: open brace '{' following union go on the same lineSigned-off-by Andrea Gelmini <[email protected]>--- arch/mips/lib/libgcc.h | 3 +-- arch/sh/lib/libgcc.h | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
I'll apply the sh part by itself, and I suppose Ralf will do the same for MIPS. I'm a bit confused as to why these were lumped together when 65 out of 66 oneliner patches made no use of ad-hoc grouping.
Re: [PATCH 42/66] arch/mips/lib/libgcc.h: Checkpatch cleanup
2010/3/1 Paul Mundt <[email protected]>:
Hi Paul,
thanks for your reply.
Quoted 3 lines
I'll apply the sh part by itself, and I suppose Ralf will do the same for MIPS. I'm a bit confused as to why these were lumped together when 65 out of 66 oneliner patches made no use of ad-hoc grouping.
After the experience with GregKH, I was looking for others maintainer interested in code cleanup. So I sent some patches over random files. If you care, I can checkpatch.pl all mips subtree and send you patches (if any).
Thanks a lot for your work,
Andrea
Re: [PATCH 42/66] arch/mips/lib/libgcc.h: Checkpatch cleanup
Quoted 11 lines · Andrea Gelmini
2010/3/1 Paul Mundt <[email protected]>:
Hi Paul,
thanks for your reply.Quoted 3 lines
I'll apply the sh part by itself, and I suppose Ralf will do the same for MIPS. I'm a bit confused as to why these were lumped together when 65 out of 66 oneliner patches made no use of ad-hoc grouping.
After the experience with GregKH, I was looking for others maintainer interested in code cleanup. So I sent some patches over random files. If you care, I can checkpatch.pl all mips subtree and send you patches (if any).
Feel free to - but remember that the coding style document is a guideline not something to be followed unconditionally.
Ralf
Ralf Baechle
AppliedRe: [PATCH 42/66] arch/mips/lib/libgcc.h: Checkpatch cleanup
In reply to Andrea GelminiQuoted 9 lines · Andrea Gelmini
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:23 +0100
To: [email protected]
Cc: Andrea Gelmini <[email protected]>,
Ralf Baechle <[email protected]>,
Paul Mundt <[email protected]>, [email protected], [email protected]
Subject: [PATCH 42/66]arch/mips/lib/libgcc.h: Checkpatch cleanup
Quoted 7 lines
arch/mips/lib/libgcc.h:21: ERROR: open brace '{' following union go on the same lineSigned-off-by Andrea Gelmini <[email protected]>--- arch/mips/lib/libgcc.h | 3 +-- arch/sh/lib/libgcc.h | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
I've applied the MIPS portion of the patch, thanks.
Ralf
PATCH 43/66 arch/um/include/shared/sysrq.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/include/shared/sysrq.h:5: ERROR: "foo* bar" should be "foo *bar"
--- arch/um/include/shared/sysrq.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/include/shared/sysrq.h +1 -1
@@ -2,6 +2,6 @@#define __UM_SYSRQ_Hstruct task_struct ; -extern void show_trace (struct task_struct * task,unsigned long *stack); +extern void show_trace (struct task_struct *task,unsigned long *stack);#endif
Signature · 1 line
1.7.0.90.g251a4
PATCH 44/66 arch/powerpc/sysdev/cpm2_pic.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/powerpc/sysdev/cpm2_pic.h:6: ERROR: "(foo*)" should be "(foo *)"
--- arch/powerpc/sysdev/cpm2_pic.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/powerpc/sysdev/cpm2_pic.h +1 -1
@@ -3,6 +3,6 @@extern unsigned int cpm2_get_irq (void ); -extern void cpm2_pic_init (struct device_node *); +extern void cpm2_pic_init (struct device_node *);#endif /* _PPC_KERNEL_CPM2_H */
Signature · 1 line
1.7.0.90.g251a4
Kumar Gala
AppliedRe: [PATCH 44/66] arch/powerpc/sysdev/cpm2_pic.h: Checkpatch cleanup
Quoted 6 lines · Andrea Gelmini
arch/powerpc/sysdev/cpm2_pic.h:6: ERROR: "(foo*)" should be "(foo *)"Signed-off-by Andrea Gelmini <[email protected]>---
arch/powerpc/sysdev/cpm2_pic.h| 2 +-1 files changed, 1 insertions(+), 1 deletions(-)
applied to next
- k
PATCH 45/66 drivers/isdn/hardware/eicon/os_4bri.h: Checkpatch cleanup
In reply to Andrea Gelminidrivers/isdn/hardware/eicon/os_4bri.h:6: ERROR: "foo * bar" should be "foo *bar"
--- drivers/isdn/hardware/eicon/os_4bri.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/isdn/hardware/eicon/os_4bri.h +1 -1
@@ -3,6 +3,6 @@#ifndef __DIVA_OS_4_BRI_H__#define __DIVA_OS_4_BRI_H__ -int diva_4bri_init_card (diva_os_xdi_adapter_t * a); +int diva_4bri_init_card (diva_os_xdi_adapter_t *a);#endif
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 45/66] drivers/isdn/hardware/eicon/os_4bri.h: Checkpatch cleanup
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:26 +0100
Quoted 3 lines
drivers/isdn/hardware/eicon/os_4bri.h:6: ERROR: "foo * bar" should be "foo *bar"Signed-off-by Andrea Gelmini <[email protected]>
PATCH 46/66 drivers/isdn/hardware/eicon/os_bri.h: Checkpatch cleanup
In reply to Andrea Gelminidrivers/isdn/hardware/eicon/os_bri.h:6: ERROR: "foo * bar" should be "foo *bar"
--- drivers/isdn/hardware/eicon/os_bri.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/isdn/hardware/eicon/os_bri.h +1 -1
@@ -3,6 +3,6 @@#ifndef __DIVA_OS_BRI_REV_1_H__#define __DIVA_OS_BRI_REV_1_H__ -int diva_bri_init_card (diva_os_xdi_adapter_t * a); +int diva_bri_init_card (diva_os_xdi_adapter_t *a);#endif
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 46/66] drivers/isdn/hardware/eicon/os_bri.h: Checkpatch cleanup
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:27 +0100
Quoted 3 lines
drivers/isdn/hardware/eicon/os_bri.h:6: ERROR: "foo * bar" should be "foo *bar"Signed-off-by Andrea Gelmini <[email protected]>
PATCH 47/66 drivers/isdn/hardware/eicon/os_pri.h: Checkpatch cleanup
In reply to Andrea Gelminidrivers/isdn/hardware/eicon/os_pri.h:6: ERROR: "foo * bar" should be "foo *bar"
--- drivers/isdn/hardware/eicon/os_pri.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/isdn/hardware/eicon/os_pri.h +1 -1
@@ -3,6 +3,6 @@#ifndef __DIVA_OS_PRI_REV_1_H__#define __DIVA_OS_PRI_REV_1_H__ -int diva_pri_init_card (diva_os_xdi_adapter_t * a); +int diva_pri_init_card (diva_os_xdi_adapter_t *a);#endif
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 47/66] drivers/isdn/hardware/eicon/os_pri.h: Checkpatch cleanup
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:28 +0100
Quoted 3 lines
drivers/isdn/hardware/eicon/os_pri.h:6: ERROR: "foo * bar" should be "foo *bar"Signed-off-by Andrea Gelmini <[email protected]>
PATCH 48/66 sound/usb/caiaq/midi.h: Checkpatch cleanup
In reply to Andrea Gelminisound/usb/caiaq/midi.h:6: ERROR: "foo* bar" should be "foo *bar"
--- sound/usb/caiaq/midi.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
sound/usb/caiaq/midi.h +1 -1
@@ -3,6 +3,6 @@int snd_usb_caiaq_midi_init (struct snd_usb_caiaqdev *dev);void snd_usb_caiaq_midi_handle_input (struct snd_usb_caiaqdev *dev,int port,const char *buf,int len); -void snd_usb_caiaq_midi_output_done (struct urb * urb); +void snd_usb_caiaq_midi_output_done (struct urb *urb);#endif /* CAIAQ_MIDI_H */
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 48/66] sound/usb/caiaq/midi.h: Checkpatch cleanup
Quoted 3 lines · Andrea Gelmini
sound/usb/caiaq/midi.h:6: ERROR: "foo* bar" should be "foo *bar"Signed-off-by Andrea Gelmini <[email protected]>
Quoted 19 lines
--- sound/usb/caiaq/midi.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)sound/usb/caiaq/midi.h +1
-1@@ -3,6 +3,6 @@int snd_usb_caiaq_midi_init (struct snd_usb_caiaqdev *dev);void snd_usb_caiaq_midi_handle_input (struct snd_usb_caiaqdev *dev,int port,const char *buf,int len); -void snd_usb_caiaq_midi_output_done (struct urb * urb); +void snd_usb_caiaq_midi_output_done (struct urb *urb);#endif /* CAIAQ_MIDI_H */ Signature · 1 line
1.7.0.90.g251a4
PATCH 49/66 arch/cris/include/arch-v32/arch/intmem.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/cris/include/arch-v32/arch/intmem.h:4: ERROR: "foo* bar" should be "foo *bar" arch/cris/include/arch-v32/arch/intmem.h:5: ERROR: "foo* bar" should be "foo *bar" arch/cris/include/arch-v32/arch/intmem.h:6: ERROR: "foo* bar" should be "foo *bar"
--- arch/cris/include/arch-v32/arch/intmem.h | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
arch/cris/include/arch-v32/arch/intmem.h +3 -3
@@ -1,9 +1,9 @@#ifndef _ASM_CRIS_INTMEM_H#define _ASM_CRIS_INTMEM_H -void *crisv32_intmem_alloc (unsigned size,unsigned align); -void crisv32_intmem_free (void * addr); -void *crisv32_intmem_phys_to_virt (unsigned long addr); +void *crisv32_intmem_alloc (unsigned size,unsigned align); +void crisv32_intmem_free (void *addr); +void *crisv32_intmem_phys_to_virt (unsigned long addr);unsigned long crisv32_intmem_virt_to_phys (void *addr);#endif /* _ASM_CRIS_ARCH_INTMEM_H */
Signature · 1 line
1.7.0.90.g251a4
PATCH 50/66 arch/um/include/shared/irq_kern.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/include/shared/irq_kern.h:14: ERROR: "foo * bar" should be "foo *bar"
--- arch/um/include/shared/irq_kern.h | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
arch/um/include/shared/irq_kern.h +1 -2
@@ -11,8 +11,7 @@extern int um_request_irq (unsigned int irq,int fd,int type,irq_handler_t handler, -unsigned long irqflags,const char * devname, +unsigned long irqflags,const char *devname,void *dev_id);#endif -
Signature · 1 line
1.7.0.90.g251a4
PATCH 51/66 drivers/isdn/i4l/isdn_concap.h: Checkpatch cleanup
In reply to Andrea Gelminidrivers/isdn/i4l/isdn_concap.h:1: WARNING: CVS style keyword markers, these will _not_ be updated drivers/isdn/i4l/isdn_concap.h:11: ERROR: "foo * bar" should be "foo *bar" drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited after that open parenthesis '(' drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited before that close parenthesis ')'
--- drivers/isdn/i4l/isdn_concap.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/isdn/i4l/isdn_concap.h +1 -3
@@ -8,6 +8,4 @@*/ extern struct concap_device_ops isdn_concap_reliable_dl_dops; -extern struct concap_proto *isdn_concap_new (int ); - - +extern struct concap_proto *isdn_concap_new (int );
Signature · 1 line
1.7.0.90.g251a4
Re: [PATCH 51/66] drivers/isdn/i4l/isdn_concap.h: Checkpatch cleanup
From: Andrea Gelmini <[email protected]>
Date: Sat, 27 Feb 2010 17:51:32 +0100
Quoted 6 lines
drivers/isdn/i4l/isdn_concap.h:1: WARNING: CVS style keyword markers, these will _not_ be updateddrivers/isdn/i4l/isdn_concap.h:11: ERROR: "foo * bar" should be "foo *bar"drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited after that open parenthesis '('drivers/isdn/i4l/isdn_concap.h:11: ERROR: space prohibited before that close parenthesis ')'Signed-off-by Andrea Gelmini <[email protected]>
PATCH 52/66 arch/m68k/hp300/time.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/m68k/hp300/time.h:2: WARNING: space prohibited between function name and open parenthesis '('
--- arch/m68k/hp300/time.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
arch/m68k/hp300/time.h +1 -3
@@ -1,4 +1,2 @@extern void hp300_sched_init (irq_handler_t vector); -extern unsigned long hp300_gettimeoffset (void ); - - +extern unsigned long hp300_gettimeoffset (void );
Signature · 1 line
1.7.0.90.g251a4
PATCH 52/66 arch/m68k/hp300/time.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/m68k/hp300/time.h:2: WARNING: space prohibited between function name and open parenthesis '('
--- arch/m68k/hp300/time.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
arch/m68k/hp300/time.h +1 -3
@@ -1,4 +1,2 @@extern void hp300_sched_init (irq_handler_t vector); -extern unsigned long hp300_gettimeoffset (void ); - - +extern unsigned long hp300_gettimeoffset (void );
Signature · 1 line
1.7.0.90.g251a4
PATCH 53/66 drivers/s390/cio/blacklist.h: Checkpatch cleanup
In reply to Andrea Gelminidrivers/s390/cio/blacklist.h:4: WARNING: space prohibited between function name and open parenthesis '('
--- drivers/s390/cio/blacklist.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/s390/cio/blacklist.h +1 -1
@@ -1,6 +1,6 @@#ifndef S390_BLACKLIST_H #define S390_BLACKLIST_H -extern int is_blacklisted (int ssid,int devno); +extern int is_blacklisted (int ssid,int devno);#endif
Signature · 1 line
1.7.0.90.g251a4
PATCH 54/66 include/asm-generic/kdebug.h: Checkpatch cleanup
In reply to Andrea Gelminiinclude/asm-generic/kdebug.h:6: ERROR: spaces required around that '=' (ctx:VxV)
--- include/asm-generic/kdebug.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/asm-generic/kdebug.h +1 -1
@@ -3,7 +3,7 @@enum die_val {DIE_UNUSED , -DIE_OOPS =1 +DIE_OOPS =1 };#endif /* _ASM_GENERIC_KDEBUG_H */
Signature · 1 line
1.7.0.90.g251a4
PATCH 55/66 arch/sh/boot/compressed/cache.c: Checkpatch cleanup
In reply to Andrea Gelminiarch/sh/boot/compressed/cache.c:8: WARNING: space prohibited between function name and open parenthesis '('
--- arch/sh/boot/compressed/cache.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/sh/boot/compressed/cache.c +1 -1
@@ -5,7 +5,7 @@ int cache_control(unsigned int command)for (i =0 ; i < (32 *1024 ); i +=32 ) { (void )*p; - p += (32 /sizeof (int )); + p += (32 /sizeof (int )); }return 0 ;
Signature · 1 line
1.7.0.90.g251a4
Paul Mundt
AppliedRe: [PATCH 55/66] arch/sh/boot/compressed/cache.c: Checkpatch cleanup
Quoted 3 lines · Andrea Gelmini
arch/sh/boot/compressed/cache.c:8: WARNING: space prohibited between function name and open parenthesis '('Signed-off-by Andrea Gelmini <[email protected]>
Applied.
PATCH 56/66 include/linux/mtd/mtdram.h: Checkpatch cleanup
In reply to Andrea Gelminiinclude/linux/mtd/mtdram.h:6: ERROR: code indent should use tabs where possible
--- include/linux/mtd/mtdram.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/mtd/mtdram.h +1 -1
@@ -3,6 +3,6 @@#include <linux/mtd/mtd.h> int mtdram_init_device (struct mtd_info *mtd,void *mapped_address, -unsigned long size,char *name); +unsigned long size,char *name);#endif /* __MTD_MTDRAM_H__ */
Signature · 1 line
1.7.0.90.g251a4
Artem Bityutskiy
AppliedRe: [PATCH 56/66] include/linux/mtd/mtdram.h: Checkpatch cleanup
Quoted 3 lines · Andrea Gelmini
include/linux/mtd/mtdram.h:6: ERROR: code indent should use tabs where possibleSigned-off-by Andrea Gelmini <[email protected]>
Pushed to l2-mtd-2.6.git / master
Signature · 2 lines
Best Regards, Artem Bityutskiy (Артём Битюцкий)
PATCH 57/66 arch/arm/plat-omap/include/plat/blizzard.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/arm/plat-omap/include/plat/blizzard.h:9: ERROR: spaces prohibited around that ':' (ctx:WxW)
--- arch/arm/plat-omap/include/plat/blizzard.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-omap/include/plat/blizzard.h +1 -1
@@ -6,7 +6,7 @@ struct blizzard_platform_data {void (*power_down)(struct device *dev);unsigned long (*get_clock_rate)(struct device *dev); - unsigned te_connected : 1; + unsigned te_connected:1; };#endif
Signature · 1 line
1.7.0.90.g251a4
PATCH 57/66 arch/arm/plat-omap/include/plat/blizzard.h:
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Branch in linux-omap: omap-fixes
Initial commit ID (Likely to change): a694acf36251cf9f454422d9cf43ee3f2c859d66
PatchWorks
http://patchwork.kernel.org/patch/82674/
Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=a694acf36251cf9f454422d9cf43ee3f2c859d66
PATCH 58/66 arch/um/os-Linux/sys-x86_64/prctl.c: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/os-Linux/sys-x86_64/prctl.c:11: ERROR: code indent should use tabs where possible
--- arch/um/os-Linux/sys-x86_64/prctl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/os-Linux/sys-x86_64/prctl.c +1 -1
@@ -8,5 +8,5 @@int os_arch_prctl (int pid,int code,unsigned long *addr) { -return ptrace (PTRACE_ARCH_PRCTL , pid, (unsigned long ) addr, code); +return ptrace (PTRACE_ARCH_PRCTL , pid, (unsigned long ) addr, code); }
Signature · 1 line
1.7.0.90.g251a4
PATCH 59/66 arch/cris/include/arch-v10/arch/thread_info.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/cris/include/arch-v10/arch/thread_info.h:8: ERROR: code indent should use tabs where possible arch/cris/include/arch-v10/arch/thread_info.h:8: ERROR: spaces required around that ':' (ctx:VxV) arch/cris/include/arch-v10/arch/thread_info.h:9: ERROR: code indent should use tabs where possible
--- arch/cris/include/arch-v10/arch/thread_info.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
arch/cris/include/arch-v10/arch/thread_info.h +2 -2
@@ -5,8 +5,8 @@static inline struct thread_info *current_thread_info (void ) {struct thread_info *ti; - __asm__("and.d $sp,%0; " :"=r" (ti) :"0" (~8191UL )); -return ti; + __asm__("and.d $sp,%0; " :"=r" (ti) :"0" (~8191UL )); +return ti; }#endif
Signature · 1 line
1.7.0.90.g251a4
PATCH 1/1 fs/nls/nls_cp949.c: Checkpatch cleanup
In reply to Andrea Gelminifs/nls/nls_cp949.c:4437: ERROR: trailing whitespace
[snip]fs/nls/nls_cp949.c:13786: ERROR: trailing whitespace fs/nls/nls_cp949.c:13882: ERROR: spaces required around that '==' (ctx:VxV) fs/nls/nls_cp949.c:13886: ERROR: else should follow close brace '}'
--- fs/nls/nls_cp949.c | 131 ++++++++++++++++++++++++++-------------------------- 1 files changed, 65 insertions(+), 66 deletions(-)
fs/nls/nls_cp949.c +65 -66
@@ -4434,38 +4434,38 @@ static const wchar_t c2u_FD[256] = { };static const wchar_t *page_charset2uni[256 ] = { -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL , c2u_81, c2u_82, c2u_83, c2u_84, c2u_85, c2u_86, c2u_87, - c2u_88, c2u_89, c2u_8A, c2u_8B, c2u_8C, c2u_8D, c2u_8E, c2u_8F, - c2u_90, c2u_91, c2u_92, c2u_93, c2u_94, c2u_95, c2u_96, c2u_97, - c2u_98, c2u_99, c2u_9A, c2u_9B, c2u_9C, c2u_9D, c2u_9E, c2u_9F, - c2u_A0, c2u_A1, c2u_A2, c2u_A3, c2u_A4, c2u_A5, c2u_A6, c2u_A7, - c2u_A8, c2u_A9, c2u_AA, c2u_AB, c2u_AC, c2u_AD, c2u_AE, c2u_AF, - c2u_B0, c2u_B1, c2u_B2, c2u_B3, c2u_B4, c2u_B5, c2u_B6, c2u_B7, - c2u_B8, c2u_B9, c2u_BA, c2u_BB, c2u_BC, c2u_BD, c2u_BE, c2u_BF, - c2u_C0, c2u_C1, c2u_C2, c2u_C3, c2u_C4, c2u_C5, c2u_C6, c2u_C7, - c2u_C8,NULL , c2u_CA, c2u_CB, c2u_CC, c2u_CD, c2u_CE, c2u_CF, - c2u_D0, c2u_D1, c2u_D2, c2u_D3, c2u_D4, c2u_D5, c2u_D6, c2u_D7, - c2u_D8, c2u_D9, c2u_DA, c2u_DB, c2u_DC, c2u_DD, c2u_DE, c2u_DF, - c2u_E0, c2u_E1, c2u_E2, c2u_E3, c2u_E4, c2u_E5, c2u_E6, c2u_E7, - c2u_E8, c2u_E9, c2u_EA, c2u_EB, c2u_EC, c2u_ED, c2u_EE, c2u_EF, - c2u_F0, c2u_F1, c2u_F2, c2u_F3, c2u_F4, c2u_F5, c2u_F6, c2u_F7, - c2u_F8, c2u_F9, c2u_FA, c2u_FB, c2u_FC, c2u_FD,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL , c2u_81, c2u_82, c2u_83, c2u_84, c2u_85, c2u_86, c2u_87, + c2u_88, c2u_89, c2u_8A, c2u_8B, c2u_8C, c2u_8D, c2u_8E, c2u_8F, + c2u_90, c2u_91, c2u_92, c2u_93, c2u_94, c2u_95, c2u_96, c2u_97, + c2u_98, c2u_99, c2u_9A, c2u_9B, c2u_9C, c2u_9D, c2u_9E, c2u_9F, + c2u_A0, c2u_A1, c2u_A2, c2u_A3, c2u_A4, c2u_A5, c2u_A6, c2u_A7, + c2u_A8, c2u_A9, c2u_AA, c2u_AB, c2u_AC, c2u_AD, c2u_AE, c2u_AF, + c2u_B0, c2u_B1, c2u_B2, c2u_B3, c2u_B4, c2u_B5, c2u_B6, c2u_B7, + c2u_B8, c2u_B9, c2u_BA, c2u_BB, c2u_BC, c2u_BD, c2u_BE, c2u_BF, + c2u_C0, c2u_C1, c2u_C2, c2u_C3, c2u_C4, c2u_C5, c2u_C6, c2u_C7, + c2u_C8,NULL , c2u_CA, c2u_CB, c2u_CC, c2u_CD, c2u_CE, c2u_CF, + c2u_D0, c2u_D1, c2u_D2, c2u_D3, c2u_D4, c2u_D5, c2u_D6, c2u_D7, + c2u_D8, c2u_D9, c2u_DA, c2u_DB, c2u_DC, c2u_DD, c2u_DE, c2u_DF, + c2u_E0, c2u_E1, c2u_E2, c2u_E3, c2u_E4, c2u_E5, c2u_E6, c2u_E7, + c2u_E8, c2u_E9, c2u_EA, c2u_EB, c2u_EC, c2u_ED, c2u_EE, c2u_EF, + c2u_F0, c2u_F1, c2u_F2, c2u_F3, c2u_F4, c2u_F5, c2u_F6, c2u_F7, + c2u_F8, c2u_F9, c2u_FA, c2u_FB, c2u_FC, c2u_FD,NULL ,NULL , };static const unsigned char u2c_01[512 ] = {
@@ -13753,37 +13753,37 @@ static const unsigned char u2c_FF[512] = { };static const unsigned char *const page_uni2charset[256 ] = { -NULL , u2c_01, u2c_02, u2c_03, u2c_04,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL , u2c_11,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , - u2c_20, u2c_21, u2c_22, u2c_23, u2c_24, u2c_25, u2c_26,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , - u2c_30, u2c_31, u2c_32, u2c_33,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL , u2c_4E, u2c_4F, - u2c_50, u2c_51, u2c_52, u2c_53, u2c_54, u2c_55, u2c_56, u2c_57, - u2c_58, u2c_59, u2c_5A, u2c_5B, u2c_5C, u2c_5D, u2c_5E, u2c_5F, - u2c_60, u2c_61, u2c_62, u2c_63, u2c_64, u2c_65, u2c_66, u2c_67, - u2c_68, u2c_69, u2c_6A, u2c_6B, u2c_6C, u2c_6D, u2c_6E, u2c_6F, - u2c_70, u2c_71, u2c_72, u2c_73, u2c_74, u2c_75, u2c_76, u2c_77, - u2c_78, u2c_79, u2c_7A, u2c_7B, u2c_7C, u2c_7D, u2c_7E, u2c_7F, - u2c_80, u2c_81, u2c_82, u2c_83, u2c_84, u2c_85, u2c_86, u2c_87, - u2c_88, u2c_89, u2c_8A, u2c_8B, u2c_8C, u2c_8D, u2c_8E, u2c_8F, - u2c_90, u2c_91, u2c_92, u2c_93, u2c_94, u2c_95, u2c_96, u2c_97, - u2c_98, u2c_99, u2c_9A, u2c_9B, u2c_9C, u2c_9D, u2c_9E, u2c_9F, -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL , u2c_AC, u2c_AD, u2c_AE, u2c_AF, - u2c_B0, u2c_B1, u2c_B2, u2c_B3, u2c_B4, u2c_B5, u2c_B6, u2c_B7, - u2c_B8, u2c_B9, u2c_BA, u2c_BB, u2c_BC, u2c_BD, u2c_BE, u2c_BF, - u2c_C0, u2c_C1, u2c_C2, u2c_C3, u2c_C4, u2c_C5, u2c_C6, u2c_C7, - u2c_C8, u2c_C9, u2c_CA, u2c_CB, u2c_CC, u2c_CD, u2c_CE, u2c_CF, - u2c_D0, u2c_D1, u2c_D2, u2c_D3, u2c_D4, u2c_D5, u2c_D6, u2c_D7, -NULL ,NULL ,NULL ,NULL , u2c_DC,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , -NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL , u2c_01, u2c_02, u2c_03, u2c_04,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL , u2c_11,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , + u2c_20, u2c_21, u2c_22, u2c_23, u2c_24, u2c_25, u2c_26,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , + u2c_30, u2c_31, u2c_32, u2c_33,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL , u2c_4E, u2c_4F, + u2c_50, u2c_51, u2c_52, u2c_53, u2c_54, u2c_55, u2c_56, u2c_57, + u2c_58, u2c_59, u2c_5A, u2c_5B, u2c_5C, u2c_5D, u2c_5E, u2c_5F, + u2c_60, u2c_61, u2c_62, u2c_63, u2c_64, u2c_65, u2c_66, u2c_67, + u2c_68, u2c_69, u2c_6A, u2c_6B, u2c_6C, u2c_6D, u2c_6E, u2c_6F, + u2c_70, u2c_71, u2c_72, u2c_73, u2c_74, u2c_75, u2c_76, u2c_77, + u2c_78, u2c_79, u2c_7A, u2c_7B, u2c_7C, u2c_7D, u2c_7E, u2c_7F, + u2c_80, u2c_81, u2c_82, u2c_83, u2c_84, u2c_85, u2c_86, u2c_87, + u2c_88, u2c_89, u2c_8A, u2c_8B, u2c_8C, u2c_8D, u2c_8E, u2c_8F, + u2c_90, u2c_91, u2c_92, u2c_93, u2c_94, u2c_95, u2c_96, u2c_97, + u2c_98, u2c_99, u2c_9A, u2c_9B, u2c_9C, u2c_9D, u2c_9E, u2c_9F, +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL , u2c_AC, u2c_AD, u2c_AE, u2c_AF, + u2c_B0, u2c_B1, u2c_B2, u2c_B3, u2c_B4, u2c_B5, u2c_B6, u2c_B7, + u2c_B8, u2c_B9, u2c_BA, u2c_BB, u2c_BC, u2c_BD, u2c_BE, u2c_BF, + u2c_C0, u2c_C1, u2c_C2, u2c_C3, u2c_C4, u2c_C5, u2c_C6, u2c_C7, + u2c_C8, u2c_C9, u2c_CA, u2c_CB, u2c_CC, u2c_CD, u2c_CE, u2c_CF, + u2c_D0, u2c_D1, u2c_D2, u2c_D3, u2c_D4, u2c_D5, u2c_D6, u2c_D7, +NULL ,NULL ,NULL ,NULL , u2c_DC,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , +NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL ,NULL , u2c_F9, u2c_FA,NULL ,NULL ,NULL ,NULL , u2c_FF, };static const unsigned char charset2lower[256 ] = {
@@ -13879,11 +13879,10 @@ static int uni2char(const wchar_t uni,if (out[0 ] ==0x00 && out[1 ] ==0x00 )return -EINVAL ; n =2 ; - }else if (ch==0 && cl) { + }else if ((ch==0 ) && cl) { out[0 ] = cl; n =1 ; - } -else + }else return -EINVAL ;return n;
Signature · 1 line
1.7.0.90.g251a4
PATCH 60/66 arch/um/sys-i386/shared/sysdep/vm-flags.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/sys-i386/shared/sysdep/vm-flags.h:11: ERROR: space prohibited before that close parenthesis ')'
--- arch/um/sys-i386/shared/sysdep/vm-flags.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/um/sys-i386/shared/sysdep/vm-flags.h +1 -1
@@ -8,7 +8,7 @@#define VM_DATA_DEFAULT_FLAGS \ (VM_READ | VM_WRITE | \ - ((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0 ) | \ + ((current->personality & READ_IMPLIES_EXEC) ? VM_EXEC : 0) | \ VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)#endif
Signature · 1 line
1.7.0.90.g251a4
PATCH 61/66 drivers/acpi/sleep.h: Checkpatch cleanup
In reply to Andrea Gelminidrivers/acpi/sleep.h:3: WARNING: space prohibited between function name and open parenthesis '('
--- drivers/acpi/sleep.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/acpi/sleep.h +1 -1
@@ -1,6 +1,6 @@extern u8 sleep_states[]; -extern int acpi_suspend (u32 state); +extern int acpi_suspend (u32 state);extern void acpi_enable_wakeup_device_prep (u8 sleep_state);extern void acpi_enable_wakeup_device (u8 sleep_state);
Signature · 1 line
1.7.0.90.g251a4
PATCH 62/66 arch/x86/kvm/kvm_timer.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/x86/kvm/kvm_timer.h:13: ERROR: code indent should use tabs where possible
--- arch/x86/kvm/kvm_timer.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
arch/x86/kvm/kvm_timer.h +1 -3
@@ -10,9 +10,7 @@ struct kvm_timer { };struct kvm_timer_ops { -bool (*is_periodic)(struct kvm_timer *); +bool (*is_periodic)(struct kvm_timer *); }; -enum hrtimer_restart kvm_timer_fn (struct hrtimer *data); -
Signature · 1 line
1.7.0.90.g251a4
Marcelo Tosatti
AppliedRe: [PATCH 62/66] arch/x86/kvm/kvm_timer.h: Checkpatch cleanup
Quoted 6 lines · Andrea Gelmini
arch/x86/kvm/kvm_timer.h:13: ERROR: code indent should use tabs where possibleSigned-off-by Andrea Gelmini <[email protected]>--- arch/x86/kvm/kvm_timer.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
Applied, thanks.
Re: [PATCH 62/66] arch/x86/kvm/kvm_timer.h: Checkpatch cleanup
2010/3/2 Marcelo Tosatti <[email protected]>:
Hi Marcelo,
thanks a lot for your reply.
Quoted 1 line
Applied, thanks.
Thanks a lot.
If you care I can check all the KVM files.
Thanks again,
Andrea
PATCH 63/66 arch/um/sys-ppc/shared/sysdep/skas_ptrace.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/sys-ppc/shared/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possible arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible arch/um/sys-ppc/shared/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible
--- arch/um/sys-ppc/shared/sysdep/skas_ptrace.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
arch/um/sys-ppc/shared/sysdep/skas_ptrace.h +5 -5
@@ -7,14 +7,14 @@#define __SYSDEP_PPC_SKAS_PTRACE_Hstruct ptrace_faultinfo { -int is_write; -unsigned long addr; +int is_write; +unsigned long addr; };struct ptrace_ldt { -int func; -void *ptr; -unsigned long bytecount; +int func; +void *ptr; +unsigned long bytecount; };#define PTRACE_LDT 54
Signature · 1 line
1.7.0.90.g251a4
PATCH 64/66 arch/um/sys-i386/shared/sysdep/skas_ptrace.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/sys-i386/shared/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possible arch/um/sys-i386/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible arch/um/sys-i386/shared/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible arch/um/sys-i386/shared/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible arch/um/sys-i386/shared/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible
--- arch/um/sys-i386/shared/sysdep/skas_ptrace.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
arch/um/sys-i386/shared/sysdep/skas_ptrace.h +5 -5
@@ -7,14 +7,14 @@#define __SYSDEP_I386_SKAS_PTRACE_Hstruct ptrace_faultinfo { -int is_write; -unsigned long addr; +int is_write; +unsigned long addr; };struct ptrace_ldt { -int func; -void *ptr; -unsigned long bytecount; +int func; +void *ptr; +unsigned long bytecount; };#define PTRACE_LDT 54
Signature · 1 line
1.7.0.90.g251a4
PATCH 65/66 arch/um/sys-ia64/sysdep/skas_ptrace.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/sys-ia64/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possible arch/um/sys-ia64/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible arch/um/sys-ia64/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible arch/um/sys-ia64/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible arch/um/sys-ia64/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible
--- arch/um/sys-ia64/sysdep/skas_ptrace.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
arch/um/sys-ia64/sysdep/skas_ptrace.h +5 -5
@@ -7,14 +7,14 @@#define __SYSDEP_IA64_SKAS_PTRACE_Hstruct ptrace_faultinfo { -int is_write; -unsigned long addr; +int is_write; +unsigned long addr; };struct ptrace_ldt { -int func; -void *ptr; -unsigned long bytecount; +int func; +void *ptr; +unsigned long bytecount; };#define PTRACE_LDT 54
Signature · 1 line
1.7.0.90.g251a4
PATCH 66/66 arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup
In reply to Andrea Gelminiarch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possible arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:15: ERROR: code indent should use tabs where possible arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:16: ERROR: code indent should use tabs where possible arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:17: ERROR: code indent should use tabs where possible
--- arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h +5 -5
@@ -7,14 +7,14 @@#define __SYSDEP_X86_64_SKAS_PTRACE_Hstruct ptrace_faultinfo { -int is_write; -unsigned long addr; +int is_write; +unsigned long addr; };struct ptrace_ldt { -int func; -void *ptr; -unsigned long bytecount; +int func; +void *ptr; +unsigned long bytecount; };#define PTRACE_LDT 54
Signature · 1 line
1.7.0.90.g251a4
Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup
Quoted 2 lines · Andrea Gelmini
arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:10: ERROR: code indent should use tabs where possiblearch/um/sys-x86_64/shared/sysdep/skas_ptrace.h:11: ERROR: code indent should use tabs where possible
Don't you have anything better to do with your time?
Jeff
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup
2010/2/27 Jeff Dike <[email protected]>:
Hi Jeff,
and thanks for your reply.
Quoted 1 line
Don't you have anything better to do with your time?
It's a dirty job, but somebody has to do it...
Enlighted by Greg's talk at FOSDEM¹ I sent him some patches (nothing more than boring things for a real programmer, but a good solitaire alternative for a rookie like me).
These patches are just a try to see if there are other subtree maintainers interested in stuff like this.
Ciao,
Andrea
----------------------------
¹ http://bit.ly/9d3Ql3
Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup
Quoted 7 lines · Andrea Gelmini
2010/2/27 Jeff Dike <[email protected]>:
Hi Jeff,
and thanks for your reply.Quoted 1 line
Don't you have anything better to do with your time?
It's a dirty job, but somebody has to do it...
To be a bit more serious, the UML tree was once a seething mass of checkpatch violations. I cleaned up a lot of it while making other changes in the area. This sort of thing I think is reasonably worthwhile, but dumping in a whole lot of checkpatch changes doesn't help anything and it just pollutes the change history.
Jeff
Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup
2010/2/28 Jeff Dike <[email protected]>:
Hi Jeff,
and thanks for your reply.
Quoted 4 lines
checkpatch violations. I cleaned up a lot of it while making other changes in the area. This sort of thing I think is reasonably worthwhile, but dumping in a whole lot of checkpatch changes doesn't help anything and it just pollutes the change history.
Yep, I talked about side effects (i.e git-blame) with Alessandro (Rubini). If you think it could be useuful I can check all the subtree. Send
you patches (if any).
You can merge piece of them as soon as you modify files with real
patches, so you
don't have to do the boring business. I don't care to have credits
about 'em, and it's not
a problem if you will not use them.
Thanks a lot,
Andrea
Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup
In reply to Andrea GelminiQuoted 6 lines · Andrea Gelmini
2010/2/27 Jeff Dike <[email protected]>:
Hi Jeff,
and thanks for your reply.Quoted 1 line
Don't you have anything better to do with your time?
Quoted 7 lines
It's a dirty job, but somebody has to do it...
Enlighted by Greg's talk at FOSDEM?? I sent him some patches (nothing more than boring things for a real programmer, but a good solitaire alternative for a rookie like me).These patches are just a try to see if there are other subtree maintainers interested in stuff like this.
Note to gregkh: the next time you give a talk like that, consider including "spamming l-k with sixty-odd solitaire sessions^W^Wwhitespace-removal patches can lead to considerable annoyance"...
Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup
Quoted 12 lines · Al Viro
Quoted 11 lines · Andrea Gelmini
2010/2/27 Jeff Dike <[email protected]>:
Hi Jeff,
and thanks for your reply.Quoted 1 line
Don't you have anything better to do with your time?
It's a dirty job, but somebody has to do it...
Enlighted by Greg's talk at FOSDEM?? I sent him some patches (nothing more than boring things for a real programmer, but a good solitaire alternative for a rookie like me).
Quoted 6 lines
Quoted 2 lines
These patches are just a try to see if there are other subtree maintainers interested in stuff like this.
Note to gregkh: the next time you give a talk like that, consider including "spamming l-k with sixty-odd solitaire sessions^W^Wwhitespace-removal patches can lead to considerable annoyance"...
Heh, I did explicitly state that this should be done on the staging tree only. This developer took it apon themselves to try a different subsystem, which is fine, why would we want to turn away free help :)
thanks,
greg k-h
Re: [uml-devel] [PATCH 66/66] arch/um/sys-x86_64/shared/sysdep/skas_ptrace.h: Checkpatch cleanup
In reply to Al Viro2010/2/28 Al Viro <[email protected]>:
Hi Viro,
thanks a lot for your reply.
Quoted 3 lines
Note to gregkh: the next time you give a talk like that, consider including "spamming l-k with sixty-odd solitaire sessions^W^Wwhitespace-removal patches can lead to considerable annoyance"...
As you can see in the video, Greg talked about - just and only -
Staging Drivers.
It's all my fault if someone is bored with my patches.
Thanks a lot for your work,
Andrea