Skip to contentSkip to conversation

Add missing dependencies to INSTALL

PATCH In review Jordan Uggla 3 participants 3 messages Mar 2, 2010 – Mar 4, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add missing dependencies to INSTALL

Gettext and qemu ( for make-check ) are missing from INSTALL, attached patch fixes this.

--
Jordan Uggla (Jordan_U on irc.freenode.net)

=== modified file 'ChangeLog'

ChangeLog +5 -0
@@ -1,3 +1,8 @@
+2010-03-02  Jordan Uggla  <[email protected]>
+
+	* INSTALL: Add gettext as a dependency and add qemu to a new section,
+	"Prerequisites for make-check".
+
 2010-03-01  Vladimir Serbinenko  <[email protected]>
 
 	* fs/ext2.c (grub_ext2_read_block): Fix an integer overflow.

=== modified file 'INSTALL'

INSTALL +5 -0
@@ -14,6 +14,7 @@
 * GCC 4.1.3 or later
 * GNU Make
 * GNU Bison 2.3 or later
+* GNU gettext 0.17 or later
 * GNU binutils 2.9.1.0.23 or later
 * Other standard GNU/Unix tools
 
@@ -25,6 +26,10 @@
 * Autoconf 2.60 or later
 * Automake 1.10.1 or later
 
+Prerequisites for make-check:
+
+* qemu, specifically the binary 'qemu-system-i386'
+
 Configuring the GRUB
 ====================
 
#1 lore raw

Hi,

Quoted 1 line · Jordan Uggla

Gettext and qemu ( for make-check ) are missing from INSTALL,

AFAIK gettext is not a requirement, is it?

If it's a requirement it could be just optional, but I would leave as a requirement since I understand that gettext is mainly everywhere.

Signature · 2 lines
Carles Pina i Estany
	http://pinux.info
#2 lore raw
Quoted 10 lines · Carles Pina i Estany

Hi,

Quoted 2 lines · Jordan Uggla

Gettext and qemu ( for make-check ) are missing from INSTALL,

AFAIK gettext is not a requirement, is it?

Currently installing on gettext-less system creates various build bugs. So for 1.98 we don't support this configuration. In future it may change if someone fixes those problems

Quoted 5 lines

If it's a requirement it could be just optional, but I would leave as a requirement since I understand that gettext is mainly everywhere.

Signature · 2 lines
Regards
Vladimir 'φ-coder/phcoder' Serbinenko