Skip to contentSkip to conversation

svcrpc: treat uid's as unsigned

PATCH New J. Bruce Fields 1 participant 1 message Mar 2, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 svcrpc: treat uid's as unsigned

From: J. Bruce Fields <[email protected]>

We should consistently treat uid's as unsigned--it's confusing when the display of uid's in the cache contents isn't consistent with their representation in upcalls.

---
 net/sunrpc/svcauth_unix.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

We should check the gss upcalls (both kernel and nfs-utils sides) as well at some point.--b.

net/sunrpc/svcauth_unix.c +1 -1
index 97f0e9e..afdcb04 100644
@@ -624,7 +624,7 @@ static int unix_gid_show(struct seq_file *m,
 	else
 		glen = 0;
 
-	seq_printf(m, "%d %d:", ug->uid, glen);
+	seq_printf(m, "%u %d:", ug->uid, glen);
 	for (i = 0; i < glen; i++)
 		seq_printf(m, " %d", GROUP_AT(ug->gi, i));
 	seq_printf(m, "\n");
Signature · 1 line
1.6.3.3