Skip to contentSkip to conversation

cpufreq: add sysfs knob for toggling core performance boost

PATCH In review Mark Langsdorf 3 participants 3 messages Mar 3, 2010 – Mar 4, 2010 CPU frequency scaling framework

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 cpufreq: add sysfs knob for toggling core performance boost

Quoted 1 line

From 1ba7af20a37b72a4375d3e3ddd33a033f204ee21 Mon Sep 17 00:00:00 2001

From: Mark Langsdorf <[email protected]>
Date: Wed, 3 Mar 2010 14:34:47 -0600
Subject: [PATCH 2/2] cpufreq: add sysfs knob for toggling core performance boost

---
 drivers/cpufreq/cpufreq.c |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)
drivers/cpufreq/cpufreq.c +26 -0
index 67bc2ec..e0fe93f 100644
@@ -662,6 +662,30 @@ static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf)
 	return sprintf(buf, "%u\n", policy->cpuinfo.max_freq);
 }
 
+static ssize_t store_cpb(struct cpufreq_policy *policy, const char *buf,
+				 size_t count)
+{
+	int ret = -EINVAL;
+	unsigned long val = 0;
+
+	ret = strict_strtoul(buf, 10, &val);
+	if (!ret && (val == 0 || val == 1))
+		policy->flags.cpb = val;
+	else
+		return -EINVAL;
+
+	ret = __cpufreq_driver_target(policy, policy->cur, CPUFREQ_RELATION_H);
+	if (ret)
+		return -EINVAL;
+
+	return count;
+}
+
+static ssize_t show_cpb(struct cpufreq_policy *policy, char *buf)
+{
+	return sprintf(buf, "%u\n", policy->flags.cpb);
+}
+
 #define define_one_ro(_name) \
 static struct freq_attr _name = \
 __ATTR(_name, 0444, show_##_name, NULL)
@@ -688,6 +712,7 @@ define_one_rw(scaling_min_freq);
 define_one_rw(scaling_max_freq);
 define_one_rw(scaling_governor);
 define_one_rw(scaling_setspeed);
+define_one_rw(cpb);
 
 static struct attribute *default_attrs[] = {
 	&cpuinfo_min_freq.attr,
@@ -701,6 +726,7 @@ static struct attribute *default_attrs[] = {
 	&scaling_driver.attr,
 	&scaling_available_governors.attr,
 	&scaling_setspeed.attr,
+	&cpb.attr,
 	NULL
 };
 
Signature · 1 line
1.6.0.2
#1 lore raw
Quoted 7 lines · On Wed, 3 Mar 2010 14:59:27 -0600 Mark Langsdorf <[email protected]> wrote:
Quoted 1 line

From 1ba7af20a37b72a4375d3e3ddd33a033f204ee21 Mon Sep 17 00:00:00 2001

From: Mark Langsdorf <[email protected]>
Date: Wed, 3 Mar 2010 14:34:47 -0600
Subject: [PATCH 2/2] cpufreq: add sysfs knob for toggling core performance boost

The lack of any changelog in a patch is usually a good sign that the patch needs a changelog :(

Quoted 44 lines
drivers/cpufreq/cpufreq.c +25 -0
index 67bc2ec..e0fe93f 100644
@@ -662,6 +662,30 @@ static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf)
 	return sprintf(buf, "%u\n", policy->cpuinfo.max_freq);
 }
 
+static ssize_t store_cpb(struct cpufreq_policy *policy, const char *buf,
+				 size_t count)
+{
+	int ret = -EINVAL;
+	unsigned long val = 0;
+
+	ret = strict_strtoul(buf, 10, &val);
+	if (!ret && (val == 0 || val == 1))
+		policy->flags.cpb = val;
+	else
+		return -EINVAL;
+
+	ret = __cpufreq_driver_target(policy, policy->cur, CPUFREQ_RELATION_H);
+	if (ret)
+		return -EINVAL;
+
+	return count;
+}
+
+static ssize_t show_cpb(struct cpufreq_policy *policy, char *buf)
+{
+	return sprintf(buf, "%u\n", policy->flags.cpb);
+}
+
 #define define_one_ro(_name) \
 static struct freq_attr _name = \
 __ATTR(_name, 0444, show_##_name, NULL)
@@ -688,6 +712,7 @@ define_one_rw(scaling_min_freq);
 define_one_rw(scaling_max_freq);
 define_one_rw(scaling_governor);
 define_one_rw(scaling_setspeed);
+define_one_rw(cpb);
 
 static struct attribute *default_attrs[] = {
 	&cpuinfo_min_freq.attr,

drivers/cpufreq/cpufreq.c static struct attribute *default_attrs[] = { · line 731

Quoted 6 lines
drivers/cpufreq/cpufreq.c +1 -0
@@ -701,6 +726,7 @@ static struct attribute *default_attrs[] = {
 	&scaling_driver.attr,
 	&scaling_available_governors.attr,
 	&scaling_setspeed.attr,
+	&cpb.attr,
 	NULL
 };

Well I've read the code and I've read the code comments and I've read the changelogs and I still have no clue what this thing does. Apparently it allows me to toggle something called "APERF/MPERF". I guess if I were patient enough, teh goog might tell me what that is, and why I might want it. But this is all terribly inefficient.

I think you'd find that your feature is more useful and will be used by more people if you tell them (and us) what it does.

#2 lore raw

From: Andrew Morton <[email protected]>
Date: Thu, Mar 04, 2010 at 01:27:43PM -0800

Quoted 2 lines

The lack of any changelog in a patch is usually a good sign that the patch needs a changelog :(

See my earlier mail.

[..]

Quoted 8 lines

Well I've read the code and I've read the code comments and I've read the changelogs and I still have no clue what this thing does. Apparently it allows me to toggle something called "APERF/MPERF". I guess if I were patient enough, teh goog might tell me what that is, and why I might want it. But this is all terribly inefficient.

I think you'd find that your feature is more useful and will be used by more people if you tell them (and us) what it does.

Basically, this is a knob for toggling of a core boosting feature we have in Fam10h, rev.E CPUs. I'll have a proper changelog with a hopefully understandable explanation soon :).

Thanks.

Signature · 6 lines
Regards/Gruss,
Boris.

-
Advanced Micro Devices, Inc.
Operating Systems Research Center