Skip to contentSkip to conversation

init: Open /dev/console from rootfs

RFC PATCH In review Eric W. Biederman 3 participants 4 messages Mar 3, 2010 VFS

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 init: Open /dev/console from rootfs

To avoid potential problems with an empty /dev open /dev/console from rootfs instead of waiting to mount our root filesystem and
mounting it there. This effectively guarantees that there will
be a device node, and it won't be on a filesystem that we will ever unmount, so there are no issues with leaving /dev/console open and pinning the filesystem.

This is actually more effective than automatically mounting devtmpfs on /dev because it removes removes the occasionally problematic assumption that /dev/console exists from the boot code.

With this patch I was able to throw busybox on my /boot partition (which has no /dev directory) and boot into userspace without problems.

The only possible negative consequence I can think of is that someone out there deliberately used did not use a character device that is major 5 minor 2 for /dev/console. Does anyone know of a situation in which that could make sense?

---
 init/do_mounts_initrd.c |    4 ----
 init/main.c             |   11 ++++++-----
 2 files changed, 6 insertions(+), 9 deletions(-)
init/do_mounts_initrd.c +0 -4
index 614241b..2b10853 100644
@@ -30,11 +30,7 @@ static int __init do_linuxrc(void * shell)
 	extern char * envp_init[];
 
 	sys_close(old_fd);sys_close(root_fd);
-	sys_close(0);sys_close(1);sys_close(2);
 	sys_setsid();
-	(void) sys_open("/dev/console",O_RDWR,0);
-	(void) sys_dup(0);
-	(void) sys_dup(0);
 	return kernel_execve(shell, argv, envp_init);
 }
 
init/main.c +6 -5
index 67e40fc..9ba505f 100644
@@ -806,11 +806,6 @@ static noinline int init_post(void)
 	system_state = SYSTEM_RUNNING;
 	numa_default_policy();
 
-	if (sys_open((const char __user *) "/dev/console", O_RDWR, 0) < 0)
-		printk(KERN_WARNING "Warning: unable to open an initial console.\n");
-
-	(void) sys_dup(0);
-	(void) sys_dup(0);
 
 	current->signal->flags |= SIGNAL_UNKILLABLE;
 
@@ -864,6 +859,12 @@ static int __init kernel_init(void * unused)
 
 	do_basic_setup();
 
+	/* Open the /dev/console on the rootfs, this should never fail */
+	if (sys_open((const char __user *) "/dev/console", O_RDWR, 0) < 0)
+		printk(KERN_WARNING "Warning: unable to open an initial console.\n");
+
+	(void) sys_dup(0);
+	(void) sys_dup(0);
 	/*
 	 * check if there is an early userspace init.  If yes, let it do all
 	 * the work
Signature · 1 line
1.6.5.2.143.g8cc62
#1 lore raw
Quoted 13 lines · Eric W. Biederman

To avoid potential problems with an empty /dev open /dev/console from rootfs instead of waiting to mount our root filesystem and
mounting it there. This effectively guarantees that there will
be a device node, and it won't be on a filesystem that we will ever unmount, so there are no issues with leaving /dev/console open and pinning the filesystem.

This is actually more effective than automatically mounting devtmpfs on /dev because it removes removes the occasionally problematic assumption that /dev/console exists from the boot code.

Quoted 9 lines

With this patch I was able to throw busybox on my /boot partition (which has no /dev directory) and boot into userspace without problems.

The only possible negative consequence I can think of is that someone out there deliberately used did not use a character device that is major 5 minor 2 for /dev/console. Does anyone know of a situation in which that could make sense?

There probably are ... but if so, they can just re-open their new console of choice after creating it, and/or use an initramfs which overrides the default /dev/console.

As such, this makes a lot of sense to me.

-hpa

Signature · 2 lines
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.
maintainer
#2 lore raw
In reply to Eric W. Biederman
Quoted 8 lines · Eric W. Biederman

To avoid potential problems with an empty /dev open /dev/console from rootfs instead of waiting to mount our root filesystem and
mounting it there. This effectively guarantees that there will
be a device node, and it won't be on a filesystem that we will ever unmount, so there are no issues with leaving /dev/console open and pinning the filesystem.

Quoted 4 lines

This is actually more effective than automatically mounting devtmpfs on /dev because it removes removes the occasionally problematic assumption that /dev/console exists from the boot code.

Hell, yeah. Applied, with thanks.

#3 lore raw
Quoted 9 lines · Al Viro
Quoted 8 lines · Eric W. Biederman

To avoid potential problems with an empty /dev open /dev/console from rootfs instead of waiting to mount our root filesystem and
mounting it there. This effectively guarantees that there will
be a device node, and it won't be on a filesystem that we will ever unmount, so there are no issues with leaving /dev/console open and pinning the filesystem.

Quoted 6 lines
Quoted 4 lines

This is actually more effective than automatically mounting devtmpfs on /dev because it removes removes the occasionally problematic assumption that /dev/console exists from the boot code.

Hell, yeah. Applied, with thanks.

:) :)

-hpa