Skip to contentSkip to conversation

vhost - Fix error path in vhost_net_set_backend

PATCH Applied Jeff Dike 2 participants 2 messages Mar 4, 2010 – Mar 7, 2010 virtio host (vhost)

lore
Share & tools
lore

Jeff Dike

author
#0 lore raw

PATCH 1/2 vhost - Fix error path in vhost_net_set_backend

commit 7bee327f8020f81a52ecb362f1fec7a4494dc98b

Author: Jeff Dike <[email protected]>
Date:   Thu Mar 4 14:48:38 2010 -0500

Fix vhost_net_set_backend error path

An error could cause vhost_net_set_backend to exit without unlocking vq->mutex.

drivers/vhost/net.c +5 -3
index ad37da2..4ada4b4 100644
@@ -508,12 +508,12 @@ static long vhost_net_set_backend(struct vhost_net *n, unsigned index, int fd)
 	/* Verify that ring has been setup correctly. */
 	if (!vhost_vq_access_ok(vq)) {
 		r = -EFAULT;
-		goto err;
+		goto err_unlock_vq;
 	}
 	sock = get_socket(fd);
 	if (IS_ERR(sock)) {
 		r = PTR_ERR(sock);
-		goto err;
+		goto err_unlock_vq;
 	}
 
 	/* start polling new socket */
@@ -524,12 +524,14 @@ static long vhost_net_set_backend(struct vhost_net *n, unsigned index, int fd)
 	vhost_net_disable_vq(n, vq);
 	rcu_assign_pointer(vq->private_data, sock);
 	vhost_net_enable_vq(n, vq);
-	mutex_unlock(&vq->mutex);
 done:
 	if (oldsock) {
 		vhost_net_flush_vq(n, index);
 		fput(oldsock->file);
 	}
+
+err_unlock_vq:
+	mutex_unlock(&vq->mutex);
 err:
 	mutex_unlock(&n->dev.mutex);
 	return r;
maintainer Applied
#1 lore raw
Quoted 10 lines · Jeff Dike

commit 7bee327f8020f81a52ecb362f1fec7a4494dc98b

Author: Jeff Dike <[email protected]>
Date:   Thu Mar 4 14:48:38 2010 -0500

Fix vhost_net_set_backend error path

An error could cause vhost_net_set_backend to exit without unlocking vq->mutex.

Thanks, applied.

Quoted 35 lines
drivers/vhost/net.c +5 -3
index ad37da2..4ada4b4 100644
@@ -508,12 +508,12 @@ static long vhost_net_set_backend(struct vhost_net *n, unsigned index, int fd)
 	/* Verify that ring has been setup correctly. */
 	if (!vhost_vq_access_ok(vq)) {
 		r = -EFAULT;
-		goto err;
+		goto err_unlock_vq;
 	}
 	sock = get_socket(fd);
 	if (IS_ERR(sock)) {
 		r = PTR_ERR(sock);
-		goto err;
+		goto err_unlock_vq;
 	}
 
 	/* start polling new socket */
@@ -524,12 +524,14 @@ static long vhost_net_set_backend(struct vhost_net *n, unsigned index, int fd)
 	vhost_net_disable_vq(n, vq);
 	rcu_assign_pointer(vq->private_data, sock);
 	vhost_net_enable_vq(n, vq);
-	mutex_unlock(&vq->mutex);
 done:
 	if (oldsock) {
 		vhost_net_flush_vq(n, index);
 		fput(oldsock->file);
 	}
+
+err_unlock_vq:
+	mutex_unlock(&vq->mutex);
 err:
 	mutex_unlock(&n->dev.mutex);
 	return r;