Skip to contentSkip to conversation

s3c244x: Fix compilation issue due to moved cpufreq-related files

PATCH New Vasily Khoruzhick 2 participants 3 messages Mar 3, 2010 – Mar 5, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s3c244x: Fix compilation issue due to moved cpufreq-related files

cpufreq-related files were moved but Makefiles were not modified, and it breaks compilation when CONFIG_S3C2440_CPUFREQ=y.

---
 arch/arm/mach-s3c2440/Makefile |    4 ----
 arch/arm/plat-s3c24xx/Makefile |    4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/mach-s3c2440/Makefile +0 -4
index c85ba32..1825516 100644
@@ -19,10 +19,6 @@ obj-$(CONFIG_S3C2440_DMA)	+= dma.o
 obj-$(CONFIG_CPU_S3C244X)	+= s3c244x.o
 obj-$(CONFIG_CPU_S3C244X)	+= s3c244x-irq.o
 obj-$(CONFIG_CPU_S3C244X)	+= s3c244x-clock.o
-obj-$(CONFIG_S3C2440_CPUFREQ)	+= s3c2440-cpufreq.o
-
-obj-$(CONFIG_S3C2440_PLL_12000000) += s3c2440-pll-12000000.o
-obj-$(CONFIG_S3C2440_PLL_16934400) += s3c2440-pll-16934400.o
 
 # Machine support
 
arch/arm/plat-s3c24xx/Makefile +4 -0
index c2237c4..b3a7ac2 100644
@@ -22,6 +22,10 @@ obj-$(CONFIG_S3C24XX_DCLK)	+= clock-dclk.o
 
 obj-$(CONFIG_CPU_FREQ_S3C24XX)	+= cpu-freq.o
 obj-$(CONFIG_CPU_FREQ_S3C24XX_DEBUGFS) += cpu-freq-debugfs.o
+obj-$(CONFIG_S3C2440_CPUFREQ)	+= s3c2440-cpufreq.o
+
+obj-$(CONFIG_S3C2440_PLL_12000000) += s3c2440-pll-12000000.o
+obj-$(CONFIG_S3C2440_PLL_16934400) += s3c2440-pll-16934400.o
 
 # Architecture dependant builds
 
Signature · 1 line
1.7.0
#1 lore raw

PATCH 1/1 s3c244x: Fix compilation issue due to moved cpufreq-related files

Quoted 2 lines · Vasily Khoruzhick

cpufreq-related files were moved but Makefiles were not modified, and it breaks compilation when CONFIG_S3C2440_CPUFREQ=y.

I've fixed this by moving the files instead of hte makefile. Commit will be in next-samsung soon. Thanks for pointing this out.

Quoted 44 lines
---
 arch/arm/mach-s3c2440/Makefile |    4 ----
 arch/arm/plat-s3c24xx/Makefile |    4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/mach-s3c2440/Makefile +0 -4
index c85ba32..1825516 100644
@@ -19,10 +19,6 @@ obj-$(CONFIG_S3C2440_DMA)	+= dma.o
 obj-$(CONFIG_CPU_S3C244X)	+= s3c244x.o
 obj-$(CONFIG_CPU_S3C244X)	+= s3c244x-irq.o
 obj-$(CONFIG_CPU_S3C244X)	+= s3c244x-clock.o
-obj-$(CONFIG_S3C2440_CPUFREQ)	+= s3c2440-cpufreq.o
-
-obj-$(CONFIG_S3C2440_PLL_12000000) += s3c2440-pll-12000000.o
-obj-$(CONFIG_S3C2440_PLL_16934400) += s3c2440-pll-16934400.o
 
 # Machine support
 
arch/arm/plat-s3c24xx/Makefile +4 -0
index c2237c4..b3a7ac2 100644
@@ -22,6 +22,10 @@ obj-$(CONFIG_S3C24XX_DCLK)	+= clock-dclk.o
 
 obj-$(CONFIG_CPU_FREQ_S3C24XX)	+= cpu-freq.o
 obj-$(CONFIG_CPU_FREQ_S3C24XX_DEBUGFS) += cpu-freq-debugfs.o
+obj-$(CONFIG_S3C2440_CPUFREQ)	+= s3c2440-cpufreq.o
+
+obj-$(CONFIG_S3C2440_PLL_12000000) += s3c2440-pll-12000000.o
+obj-$(CONFIG_S3C2440_PLL_16934400) += s3c2440-pll-16934400.o
 
 # Architecture dependant builds
 
Signature · 7 lines
1.7.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 5 lines
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.
#2 lore raw

PATCH 1/1 s3c244x: Fix compilation issue due to moved cpufreq-related files

? ????????? ?? 5 ????? 2010 01:20:06 ????? Ben Dooks ???????:

Quoted 2 lines

I've fixed this by moving the files instead of hte makefile. Commit will be in next-samsung soon. Thanks for pointing this out.

Sorry, but it seems you forgot about s3c2440-cpufreq.c in commit 8997de30ad (look at my patch again :)). Please move it from plat-s3c244x to arch-s3c2440 too.

Regards,
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100305/79aa97f0/attachment.sig>