e1000e: fix packet corruption and tx hang during NFSv2
Subsystems (2)
PATCH 1/1 e1000e: fix packet corruption and tx hang during NFSv2
From: Jesse Brandeburg <[email protected]>
when receiving a particular type of NFS v2 UDP traffic, the hardware could DMA some bad data and then hang, possibly corrupting memory.
Disable the NFS parsing in this hardware, verified to fix the bug.
Originally reported and reproduced by RedHat's Neil Horman
---
drivers/net/e1000e/defines.h | 2 ++ drivers/net/e1000e/ich8lan.c | 10 ++++++++++ 2 files changed, 12 insertions(+), 0 deletions(-)
drivers/net/e1000e/defines.h +2 -0
@@ -320,6 +320,8 @@#define E1000_RXCSUM_IPPCSE 0x00001000/* IP payload checksum enable */ /* Header split receive */ +#define E1000_RFCTL_NFSW_DIS 0x00000040 +#define E1000_RFCTL_NFSR_DIS 0x00000080#define E1000_RFCTL_ACK_DIS 0x00001000#define E1000_RFCTL_EXTEN 0x00008000#define E1000_RFCTL_IPV6_EX_DIS 0x00010000
drivers/net/e1000e/ich8lan.c +10 -0
@@ -2740,6 +2740,16 @@ static void e1000_initialize_hw_bits_ich8lan(struct e1000_hw *hw) reg &= ~(1 <<31 );ew32 (STATUS , reg); } + +/* +* work-around descriptor data corruption issue during nfs v2 udp +* traffic, just disable the nfs filtering capability +*/ + reg =er32 (RFCTL ); + reg |= (E1000_RFCTL_NFSW_DIS |E1000_RFCTL_NFSR_DIS ); +ew32 (RFCTL , reg); + +return ; }/**
Quoted 5 lines · Jeff Kirsher
From: Jesse Brandeburg <[email protected]>
when receiving a particular type of NFS v2 UDP traffic, the hardware could DMA some bad data and then hang, possibly corrupting memory.
Quoted 8 lines
Disable the NFS parsing in this hardware, verified to fix the bug.
Originally reported and reproduced by RedHat's Neil Horman
Signed-off-by Jesse Brandeburg <[email protected]>Signed-off-by Jeff Kirsher <[email protected]>---
From: Jeff Kirsher <[email protected]>
Date: Fri, 05 Mar 2010 04:21:44 -0800
Quoted 11 lines
From: Jesse Brandeburg <[email protected]>
when receiving a particular type of NFS v2 UDP traffic, the hardware could DMA some bad data and then hang, possibly corrupting memory.
Disable the NFS parsing in this hardware, verified to fix the bug.
Originally reported and reproduced by RedHat's Neil Horman
Signed-off-by Jesse Brandeburg <[email protected]>Signed-off-by Jeff Kirsher <[email protected]>
Applied, thanks.