Skip to contentSkip to conversation

scsi: update comment on the standards revision

PATCH Applied Christoph Hellwig 2 participants 2 messages Mar 4, 2010 – Mar 6, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: update comment on the standards revision

hw/scsi-disk.c +6 -2
Index: qemu/hw/scsi-disk.c
===================================================================
@@ -462,8 +462,12 @@ static int scsi_disk_emulate_inquiry(SCS
     }
     memcpy(&outbuf[8], "QEMU    ", 8);
     memcpy(&outbuf[32], s->version ? s->version : QEMU_VERSION, 4);
-    /* Identify device as SCSI-3 rev 1.
-       Some later commands are also implemented. */
+    /*
+     * We claim conformance to SPC-3, which is required for guests
+     * to ask for modern features like READ CAPACITY(16) or the
+     * block characteristics VPD page by default.  Not all of SPC-3
+     * is actually implemented, but we're good enough.
+     */
     outbuf[2] = 5;
     outbuf[3] = 2; /* Format 2 */
 
#1 lore raw
Quoted 1 line · Christoph Hellwig

Thanks, applied.

Quoted 22 lines

Index: qemu/hw/scsi-disk.c
===================================================================

hw/scsi-disk.c +6 -2
@@ -462,8 +462,12 @@ static int scsi_disk_emulate_inquiry(SCS
     }
     memcpy(&outbuf[8], "QEMU    ", 8);
     memcpy(&outbuf[32], s->version ? s->version : QEMU_VERSION, 4);
-    /* Identify device as SCSI-3 rev 1.
-       Some later commands are also implemented. */
+    /*
+     * We claim conformance to SPC-3, which is required for guests
+     * to ask for modern features like READ CAPACITY(16) or the
+     * block characteristics VPD page by default.  Not all of SPC-3
+     * is actually implemented, but we're good enough.
+     */
     outbuf[2] = 5;
     outbuf[3] = 2; /* Format 2 */
 
Signature · 2 lines
Aurelien Jarno                          GPG: 1024D/F1BCDB73
[email protected]                 http://www.aurel32.net