Skip to contentSkip to conversation

virtio

GIT PULL Michael S. Tsirkin 2 participants 5 messages Mar 7, 2010 virtio core

lore
Share & tools
lore

Michael S. Tsirkin

author maintainer
#0 lore raw

Linus,
Please pull another virtio fix: this one fixes hotplug and was supposed to be applied by Rusty already
(http://lkml.org/lkml/2009/11/30/451), but apparently got lost, somehow.

Thanks!

The following changes since commit 3119815912a220bdac943dfbdfee640414c0c611:
Michael S. Tsirkin (1):
virtio: fix out of range array access

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git for-linus

Michael S. Tsirkin (1):
virtio: set pci bus master enable bit

 drivers/virtio/virtio_pci.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
#1 lore raw
Quoted 12 lines · Michael S. Tsirkin

Linus,
Please pull another virtio fix: this one fixes hotplug and was supposed to be applied by Rusty already
(http://lkml.org/lkml/2009/11/30/451), but apparently got lost, somehow.

Thanks!

The following changes since commit 3119815912a220bdac943dfbdfee640414c0c611:
Michael S. Tsirkin (1):
virtio: fix out of range array access

Quoted 6 lines

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git for-linus

Michael S. Tsirkin (1):
virtio: set pci bus master enable bit

This is still missing an identifier for the hypervisor. We need to know if the guest will ever set bus master enabled or not, so we can have a compat hack in qemu to not check for it.

Alex

author maintainer
#2 lore raw
Quoted 19 lines · Alexander Graf
Quoted 16 lines · Michael S. Tsirkin

Linus,
Please pull another virtio fix: this one fixes hotplug and was supposed to be applied by Rusty already
(http://lkml.org/lkml/2009/11/30/451), but apparently got lost, somehow.

Thanks!

The following changes since commit 3119815912a220bdac943dfbdfee640414c0c611:
Michael S. Tsirkin (1):
virtio: fix out of range array access

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git for-linus

Quoted 7 lines
Quoted 2 lines

Michael S. Tsirkin (1):
virtio: set pci bus master enable bit

This is still missing an identifier for the hypervisor. We need to know if the guest will ever set bus master enabled or not, so we can have a compat hack in qemu to not check for it.

Alex

This patch fixes hotplug with qemu 0.11-0.12 which can't make use of a new identifier without a time machine.

IMHO we can't add new identifiers in time for 2.6.34 anyway, so if you want to do that, please send a patch and have it queued up for the next release. But I don't think we need an identifier for compat hack. Hypervisor can detect buggy guests when they set status to OK without enabling bus master first.

Makes sense?

Signature · 1 line
MST
#3 lore raw
Quoted 23 lines · Michael S. Tsirkin
Quoted 22 lines · Alexander Graf
Quoted 18 lines · Michael S. Tsirkin

Linus,
Please pull another virtio fix: this one fixes hotplug and was supposed to be applied by Rusty already
(http://lkml.org/lkml/2009/11/30/451), but apparently got lost, somehow.

Thanks!

The following changes since commit 3119815912a220bdac943dfbdfee640414c0c611:
Michael S. Tsirkin (1):
virtio: fix out of range array access

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git for-linus

Michael S. Tsirkin (1):
virtio: set pci bus master enable bit

Quoted 7 lines
Quoted 4 lines

This is still missing an identifier for the hypervisor. We need to know if the guest will ever set bus master enabled or not, so we can have a compat hack in qemu to not check for it.

Alex

This patch fixes hotplug with qemu 0.11-0.12 which can't make use of a new identifier without a time machine.

For 0.12 there's -stable and I don't think the bad patch is in 0.11 yet?

Quoted 7 lines

IMHO we can't add new identifiers in time for 2.6.34 anyway, so if you want to do that, please send a patch and have it queued up for the next release. But I don't think we need an identifier for compat hack. Hypervisor can detect buggy guests when they set status to OK without enabling bus master first.

Makes sense?

Ah, so you'd do the compat hack purely in qemu? Sounds good to me.

Nevermind the noise - please take that patch :-).

Alex

#4 lore raw
In reply to Michael S. Tsirkin
Quoted 23 lines · Michael S. Tsirkin
Quoted 22 lines · Alexander Graf
Quoted 18 lines · Michael S. Tsirkin

Linus,
Please pull another virtio fix: this one fixes hotplug and was supposed to be applied by Rusty already
(http://lkml.org/lkml/2009/11/30/451), but apparently got lost, somehow.

Thanks!

The following changes since commit 3119815912a220bdac943dfbdfee640414c0c611:
Michael S. Tsirkin (1):
virtio: fix out of range array access

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git for-linus

Michael S. Tsirkin (1):
virtio: set pci bus master enable bit

Quoted 7 lines
Quoted 4 lines

This is still missing an identifier for the hypervisor. We need to know if the guest will ever set bus master enabled or not, so we can have a compat hack in qemu to not check for it.

Alex

This patch fixes hotplug with qemu 0.11-0.12 which can't make use of a new identifier without a time machine.

For 0.12 there's -stable and I don't think the bad patch is in 0.11 yet?

Quoted 7 lines

IMHO we can't add new identifiers in time for 2.6.34 anyway, so if you want to do that, please send a patch and have it queued up for the next release. But I don't think we need an identifier for compat hack. Hypervisor can detect buggy guests when they set status to OK without enabling bus master first.

Makes sense?

Ah, so you'd do the compat hack purely in qemu? Sounds good to me.

Nevermind the noise - please take that patch :-).

Alex