telephony: precendence issue

DISCUSSION Dan Carpenter 1 participant 1 message Mar 8, 2010 Kernel janitors

Share & tools

Dan Carpenter

author

2010-03-08 12:16 UTC #0 lore raw

drivers/telephony/ixj.c +6834 ixj_selfprobe(67)
6833 case QTI_PHONEJACK:
6834 if (!j->dsp.low != 0x20) {
6835 j->dsp.high = 0x80;
6836 j->dsp.low = 0x20;

"!" has precedence over "!=" and since both 1 and 0 are not equal to 0x20 the condition is always true.

I'm pretty sure the "!" is a stray and the test should be:

	if (j->dsp.low != 0x20) {

but I don't have the hardware to test this.

regards,
dan carpenter