container_test.sh: should to delete check_for_unshare's source in cvs/git ?

LTP Shi Weihua 3 participants 4 messages Mar 8, 2010 – Mar 9, 2010

Share & tools

Shi Weihua

author

2010-03-08 02:56 UTC #0 lore raw

Tested the latest cvs version (about Mar 1) on my x86_64 (2.6.33).
The following message occured:
--------------------------------
<<<test_start>>>
tag=Containers stime=1267527554
cmdline="container_test.sh"
contacts=""
analysis=exit
<<<test_output>>>
/opt/ltp/testcases/bin/container_test.sh: line 13: check_for_unshare: command not found Running utsns tests.
unshare tests
test 1 (unshare)
test 2 (unshare)
......
--------------------------------

I noticed that check_for_unshare had been deleted in LTP-20091031. In ./ChangeLog (from latest cvs version)
...
2905 LTP-20091031
...
3141 Removed Files:
3142 ltp/README.ltp-devel
3143 ltp/config.mk.in
3144 ltp/ltp-devel.spec
3145 ltp/testcases/kernel/containers/check_for_unshare.c
...
3997 LTP-20090930

Also, i noticed check_for_unshare commentted in container_test.sh in release version of FEBRUARY 2010. pls check the diff between cvs version and release version of Feb in attached file.

Now, my question: should to delete check_for_unshare's source in cvs/git ?

testcases/kernel/containers/container_test.sh +20 ~~-10~~

@@ -10,11 +10,11 @@
 # any later version.
 
 #check_utsns_enabled
-check_for_unshare
-if [ $? -eq 1 ]; then
-	echo "Unshare not supported.  Not running container tests"
-	exit 0
-fi
+#check_for_unshare
+#if [ $? -eq 1 ]; then
+#	echo "Unshare not supported.  Not running container tests"
+#	exit 0
+#fi
 check_utsns_enabled
 if [ $? -eq 0 ]; then
 	echo "Running utsns tests."

@@ -46,11 +46,22 @@ else
 	echo "ipc namespaces not enabled in kernel.  Not running ipcns tests."
 fi
 
-echo "Running pidns tests."
-runpidnstest.sh
+check_pidns_enabled
+if [ $? -eq 0 ]; then
+	echo "Running pidns tests."
+	runpidnstest.sh
+else
+	echo "Process id namespaces not enabled in kernel.  Not running pidns tests."
+fi
 
-echo "Running POSIX message queue tests."
-runmqnstest.sh
+check_mqns_enabled
+if [ $? -eq 0 ]; then
+    echo "Running POSIX message queue tests."
+    runmqnstest.sh
+else
+    echo "Posix message queues or ipc namespaces not enabled in kernel."
+    echo "Not running mqns tests."
+fi
 
 check_netns_enabled
 if [ $? -eq 0 ]; then

@@ -59,4 +70,3 @@ if [ $? -eq 0 ]; then
 else
 	echo "Network namespaces not enabled in kernel.  Not running netns tests."
 fi
-

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett Cooper

2010-03-08 15:53 UTC #1 lore raw

Quoted 30 lines · Shi Weihua

Tested the latest cvs version (about Mar 1) on my x86_64 (2.6.33).
The following message occured:
--------------------------------
<<<test_start>>>
tag=Containers stime=1267527554
cmdline="container_test.sh"
contacts=""
analysis=exit
<<<test_output>>>
/opt/ltp/testcases/bin/container_test.sh: line 13: check_for_unshare: command not found Running utsns tests.
unshare tests
test 1 (unshare)
test 2 (unshare)
......
--------------------------------
I noticed that check_for_unshare had been deleted in LTP-20091031. In ./ChangeLog (from latest cvs version)
...
2905 LTP-20091031
...
3141 Removed Files:
3142 ltp/README.ltp-devel
3143 ltp/config.mk.in
3144 ltp/ltp-devel.spec
3145 ltp/testcases/kernel/containers/check_for_unshare.c
...
3997 LTP-20090930

Quoted 5 lines

Also, i noticed check_for_unshare commentted in container_test.sh in release version of FEBRUARY 2010. pls check the diff between cvs version and release version of Feb in attached file.
Now, my question: should to delete check_for_unshare's source in cvs/git ?

There was some discussion and the check was reenabled post the February release. Thanks,
-Garrett

Rishikesh K Rajak

2010-03-08 17:17 UTC #2 lore raw

Quoted 31 lines · Garrett Cooper

Quoted 30 lines · Shi Weihua
Tested the latest cvs version (about Mar 1) on my x86_64 (2.6.33).
The following message occured:
--------------------------------
<<<test_start>>>
tag=Containers stime=1267527554
cmdline="container_test.sh"
contacts=""
analysis=exit
<<<test_output>>>
/opt/ltp/testcases/bin/container_test.sh: line 13: check_for_unshare: command not found Running utsns tests.
unshare tests
test 1 (unshare)
test 2 (unshare)
......
--------------------------------
I noticed that check_for_unshare had been deleted in LTP-20091031. In ./ChangeLog (from latest cvs version)
...
2905 LTP-20091031
...
3141 Removed Files:
3142 ltp/README.ltp-devel
3143 ltp/config.mk.in
3144 ltp/ltp-devel.spec
3145 ltp/testcases/kernel/containers/check_for_unshare.c
...
3997 LTP-20090930

Quoted 7 lines

Quoted 5 lines
Also, i noticed check_for_unshare commentted in container_test.sh in release version of FEBRUARY 2010. pls check the diff between cvs version and release version of Feb in attached file.
Now, my question: should to delete check_for_unshare's source in cvs/git ?
There was some discussion and the check was reenabled post the February release.

I looked at a glance in sleep mode and found there is something need to be fixed here as i am still not able to find check_for_unshare.c . Well i will look and fix tomorrow.

Thanks
Rishi

Quoted 2 lines

Thanks,
-Garrett

Signature · 16 lines

Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Rishikesh K Rajak

2010-03-09 08:39 UTC #3 lore raw

Quoted 10 lines · Rishikesh K Rajak

Quoted 5 lines · Garrett Cooper
Quoted 2 lines · Shi Weihua
Now, my question: should to delete check_for_unshare's source in cvs/git ?
There was some discussion and the check was reenabled post the February release.
I looked at a glance in sleep mode and found there is something need to be fixed here as i am still not able to find check_for_unshare.c . Well i will look and fix tomorrow.

Hi Shi,

Thanks for reporting this failure. Just now i committed to next branch.

commit bdfe0b2a9dd720c3013225cc4aa1628e77888b24

Author: Rishikesh K Rajak <[email protected]>
Date:   Tue Mar 9 14:05:46 2010 +0530

Adding check_for_unshare.c file and linking the porper lib.

Signed-off-by Rishikesh K Rajak <[email protected]>

Reported-By Shi Weihua <[email protected]>

Signature · 16 lines

Thanks & Regards
Rishi
LTP Maintainer
IBM, LTC, Bangalore
Please join IRC #ltp @ irc.freenode.net

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list