Skip to contentSkip to conversation

tsl2550: Move from i2c/chips to misc

PATCH In review Jean Delvare 3 participants 4 messages Mar 9, 2010 3 messages not in the archive

Subsystems (3)
Char and misc drivers I2C subsystem host drivers I2C
lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/2 tsl2550: Move from i2c/chips to misc

Move the last remaining driver from i2c/chips to misc. Good ridance!

Signed-off-by Jean Delvare <[email protected]>
Cc Jonathan Cameron <kernel-tko9wxEg+fIOOJlXag/[email protected]>
---
 drivers/i2c/Kconfig         |    1 
 drivers/i2c/Makefile        |    2 
 drivers/i2c/chips/Kconfig   |   19 -
 drivers/i2c/chips/Makefile  |   18 -
 drivers/i2c/chips/tsl2550.c |  473 -------------------------------------------
 drivers/misc/Kconfig        |   10 
 drivers/misc/Makefile       |    1 
 drivers/misc/tsl2550.c      |  473 +++++++++++++++++++++++++++++++++++++++++++
 8 files changed, 485 insertions(+), 512 deletions(-)
drivers/i2c/Kconfig +0 -1
@@ -73,7 +73,6 @@ config I2C_SMBUS
 
 source drivers/i2c/algos/Kconfig
 source drivers/i2c/busses/Kconfig
-source drivers/i2c/chips/Kconfig
 
 config I2C_DEBUG_CORE
 	bool "I2C Core debugging messages"
drivers/i2c/Makefile +1 -1
@@ -6,7 +6,7 @@ obj-$(CONFIG_I2C_BOARDINFO)	+= i2c-board
 obj-$(CONFIG_I2C)		+= i2c-core.o
 obj-$(CONFIG_I2C_SMBUS)		+= i2c-smbus.o
 obj-$(CONFIG_I2C_CHARDEV)	+= i2c-dev.o
-obj-y				+= busses/ chips/ algos/
+obj-y				+= algos/ busses/
 
 ifeq ($(CONFIG_I2C_DEBUG_CORE),y)
 EXTRA_CFLAGS += -DDEBUG
drivers/i2c/chips/Kconfig deleted +0 -19
@@ -1,19 +0,0 @@
-#
-# Miscellaneous I2C chip drivers configuration
-#
-# *** DEPRECATED! Do not add new entries! See Makefile ***
-#
-
-menu "Miscellaneous I2C Chip support"
-
-config SENSORS_TSL2550
-	tristate "Taos TSL2550 ambient light sensor"
-	depends on EXPERIMENTAL
-	help
-	  If you say yes here you get support for the Taos TSL2550
-	  ambient light sensor.
-
-	  This driver can also be built as a module.  If so, the module
-	  will be called tsl2550.
-
-endmenu
drivers/i2c/chips/Makefile deleted +0 -18
@@ -1,18 +0,0 @@
-#
-# Makefile for miscellaneous I2C chip drivers.
-#
-# Do not add new drivers to this directory! It is DEPRECATED.
-#
-# Device drivers are better grouped according to the functionality they
-# implement rather than to the bus they are connected to. In particular:
-# * Hardware monitoring chip drivers go to drivers/hwmon
-# * RTC chip drivers go to drivers/rtc
-# * I/O expander drivers go to drivers/gpio
-#
-
-obj-$(CONFIG_SENSORS_TSL2550)	+= tsl2550.o
-
-ifeq ($(CONFIG_I2C_DEBUG_CHIP),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
-
drivers/i2c/chips/tsl2550.c deleted +0 -473

473 lines not on this page · raw message

drivers/misc/Kconfig +10 -0
@@ -268,6 +268,16 @@ config ISL29003
 	  This driver can also be built as a module.  If so, the module
 	  will be called isl29003.
 
+config SENSORS_TSL2550
+	tristate "Taos TSL2550 ambient light sensor"
+	depends on I2C && SYSFS
+	help
+	  If you say yes here you get support for the Taos TSL2550
+	  ambient light sensor.
+
+	  This driver can also be built as a module.  If so, the module
+	  will be called tsl2550.
+
 config EP93XX_PWM
 	tristate "EP93xx PWM support"
 	depends on ARCH_EP93XX
drivers/misc/Makefile +1 -0
@@ -21,6 +21,7 @@ obj-$(CONFIG_SGI_GRU)		+= sgi-gru/
 obj-$(CONFIG_CS5535_MFGPT)	+= cs5535-mfgpt.o
 obj-$(CONFIG_HP_ILO)		+= hpilo.o
 obj-$(CONFIG_ISL29003)		+= isl29003.o
+obj-$(CONFIG_SENSORS_TSL2550)	+= tsl2550.o
 obj-$(CONFIG_EP93XX_PWM)	+= ep93xx_pwm.o
 obj-$(CONFIG_DS1682)		+= ds1682.o
 obj-$(CONFIG_TI_DAC7512)	+= ti_dac7512.o
drivers/misc/tsl2550.c new file +473 -0

473 lines not on this page · raw message

Signature · 1 line
Jean Delvare

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#4 lore raw
Quoted 8 lines · Wolfram Sang
Quoted 4 lines · Jean Delvare

Move the last remaining driver from i2c/chips to misc. Good ridance!

Signed-off-by Jean Delvare <[email protected]>
Cc Jonathan Cameron <kernel-tko9wxEg+fIOOJlXag/[email protected]>

Okay, so we move it twice then. Fine with me :)

I wanted to avoid it, but ALS (or whatever it will become) takes too long to settle, longer than I was wanting to wait for.

Quoted 1 line
Acked-by Wolfram Sang <[email protected]>

Thanks.

Signature · 1 line
Jean Delvare

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#6 lore raw
Quoted 5 lines · Jean Delvare
Quoted 4 lines · Wolfram Sang
Quoted 2 lines · Jean Delvare

Move the last remaining driver from i2c/chips to misc. Good ridance!

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Signed-off-by Jean Delvare <[email protected]>
Cc Jonathan Cameron <kernel-tko9wxEg+fIOOJlXag/[email protected]>

Okay, so we move it twice then. Fine with me :)

I wanted to avoid it, but ALS (or whatever it will become) takes too long to settle, longer than I was wanting to wait for.

Indeed...

Quoted 1 line
Quoted 1 line
Acked-by Wolfram Sang <[email protected]>
Acked-by Jonathan Cameron <jic23-KWPb1pKIrIJaa/[email protected]>