Skip to contentSkip to conversation

./drivers/pci/pci.c

PATCH New FUJITA Kazutoshi 3 participants 5 messages Mar 9, 2010 – Mar 21, 2010 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ./drivers/pci/pci.c

hi,

it might be a small bug.

regards,

drivers/pci/pci.c +1 -1
index d6d2d6e..cd64a87 100644
@@ -388,7 +388,7 @@ int pci_hose_config_device(struct pci_controller *hose,
 
 	pci_hose_write_config_dword (hose, dev, PCI_COMMAND, 0);
 
-	for (bar = PCI_BASE_ADDRESS_0; bar < PCI_BASE_ADDRESS_5; bar += 4) {
+	for (bar = PCI_BASE_ADDRESS_0; bar <= PCI_BASE_ADDRESS_5; bar += 4) {
 		pci_hose_write_config_dword (hose, dev, bar, 0xffffffff);
 		pci_hose_read_config_dword (hose, dev, bar, &bar_response);
 
#1 lore raw

PATCH 1/1 ./drivers/pci/pci.c

Dear FUJITA Kazutoshi,

Quoted 6 lines · In message <[email protected]> you wrote:

hi,

it might be a small bug.

regards,

Please provide a useful commit message, and add your Signed-off-by:
line.

Thanks.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The good Christian should beware of mathematicians and all those who
make empty prophecies. The danger already exists that  mathematicians
have  made a covenant with the devil to darken the spirit and confine
man in the bonds of Hell."                          - Saint Augustine
#2 lore raw

PATCH 1/1 ./drivers/pci/pci.c

From: Wolfgang Denk <[email protected]>
Subject: Re: [U-Boot] [Patch] ./drivers/pci/pci.c
Date: Tue, 09 Mar 2010 14:27:25 +0100

Quoted 2 lines

Please provide a useful commit message, and add your Signed-off-by:
line.

sorry, how about this?

regards,

this patch fixes to deal with PCI_BASE_ADDRESS_5 which was forgotten in pci_hose_config_device()

drivers/pci/pci.c +1 -1
index d6d2d6e..cd64a87 100644
@@ -388,7 +388,7 @@ int pci_hose_config_device(struct pci_controller *hose,
 
 	pci_hose_write_config_dword (hose, dev, PCI_COMMAND, 0);
 
-	for (bar = PCI_BASE_ADDRESS_0; bar < PCI_BASE_ADDRESS_5; bar += 4) {
+	for (bar = PCI_BASE_ADDRESS_0; bar <= PCI_BASE_ADDRESS_5; bar += 4) {
 		pci_hose_write_config_dword (hose, dev, bar, 0xffffffff);
 		pci_hose_read_config_dword (hose, dev, bar, &bar_response);
 
#3 lore raw

PATCH 1/1 ./drivers/pci/pci.c

Quoted 9 lines · On Tuesday 09 March 2010 15:28:41 FUJITA Kazutoshi wrote:

From: Wolfgang Denk <[email protected]>
Subject: Re: [U-Boot] [Patch] ./drivers/pci/pci.c
Date: Tue, 09 Mar 2010 14:27:25 +0100

Quoted 2 lines

Please provide a useful commit message, and add your Signed-off-by:
line.

sorry, how about this?

Quoted 7 lines

regards,

this patch fixes to deal with PCI_BASE_ADDRESS_5 which was forgotten in pci_hose_config_device()

Looks good, so:

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

#4 lore raw

PATCH 1/1 ./drivers/pci/pci.c

In reply to FUJITA Kazutoshi

Dear FUJITA Kazutoshi,

Quoted 10 lines · In message <[email protected]> you wrote:

Subject: Re: [U-Boot] [Patch] ./drivers/pci/pci.c
Date: Tue, 09 Mar 2010 14:27:25 +0100

Quoted 2 lines

Please provide a useful commit message, and add your Signed-off-by:
line.

sorry, how about this?

regards,

That's actually still nort usable.

First, the Subject line would result in a commit message tile of "./drivers/pci/pci.c" - do you think this is a meaningful description of what this patch is doing?

Second, all the above text would become part of the commit message - this makes no sense either.

Please use git-format-patch to format the patches, add commets _below_ the "---" line, and use git-send-email to submit the patches.

drivers/pci/pci.c int pci_hose_config_device(struct pci_controller *hose,

Quoted 11 lines

this patch fixes to deal with PCI_BASE_ADDRESS_5 which was forgotten in pci_hose_config_device()

drivers/pci/pci.c +0 -0
index d6d2d6e..cd64a87 100644
@@ -388,7 +388,7 @@ int pci_hose_config_device(struct pci_controller *hose,

I edited the commit message for you, and applied the patch now. Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You're just jealous." "What, of an overgrown puppy  with  a  single-
figure IQ?"                      - Terry Pratchett, _Moving Pictures_