Staging: comedi:fix missing KERN_facility level in ni_labpc.c
PATCH 1/1 Staging: comedi:fix missing KERN_facility level in ni_labpc.c
From: aseemsethi <[email protected]>
This is a patch to fix the "missing KERN_facility level" error found when running the checkpatch.pl script
--- drivers/staging/comedi/drivers/ni_labpc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/comedi/drivers/ni_labpc.c +1 -1
@@ -535,7 +535,7 @@ int labpc_common_attach(struct comedi_device *dev, unsigned long iobase,printk ("\n" );if (iobase ==0 ) { -printk ("io base address is zero!\n" ); +printk (KERN_ERR "io base address is zero!\n" );return -EINVAL ; }/* request io regions for isa boards */
Signature · 5 lines
1.6.4.2 __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
Quoted 13 lines · aseem sethi
From: aseemsethi <[email protected]>
This is a patch to fix the "missingKERN_facilitylevel" error found when running the checkpatch.pl scriptSigned-off-by Aseem Sethi <[email protected]>--- drivers/staging/comedi/drivers/ni_labpc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/staging/comedi/drivers/ni_labpc.c +0
-0
drivers/staging/comedi/drivers/ni_labpc.c int labpc_common_attach(struct comedi_device *dev, unsigned long iobase, · line 541
Quoted 8 lines
drivers/staging/comedi/drivers/ni_labpc.c +1
-1@@ -535,7 +535,7 @@ int labpc_common_attach(struct comedi_device *dev, unsigned long iobase,printk ("\n" );if (iobase ==0 ) { -printk ("io base address is zero!\n" ); +printk (KERN_ERR "io base address is zero!\n" );return -EINVAL ; }/* request io regions for isa boards */
Hi,
How does someone know that this message comes from this driver and not from some other driver or core part of the kernel?
I'd be much more interested in someone fixing comedi build errors (that have been around forever -- I reported these long ago) when CONFIG_PCI=n and CONFIG_COMEDI=m, CONFIG_COMEDI_PCMCIA=m, CONFIG_PCCARD=y, CONFIG_PCMCIA=y, but CONFIG_CARDBUS=n:
ERROR: "ni_tio_rinsn" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "ni_tio_winsn" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "ni_tio_insn_config" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "ni_tio_init_counter" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "ni_gpct_device_construct" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "ni_gpct_device_destroy" [drivers/staging/comedi/drivers/ni_mio_cs.ko] undefined!
ERROR: "labpc_1200_is_unipolar" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
ERROR: "labpc_1200_ai_gain_bits" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
ERROR: "range_labpc_1200_ai" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
ERROR: "labpc_common_detach" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
ERROR: "labpc_common_attach" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined!
ERROR: "das08_cs_boards" [drivers/staging/comedi/drivers/das08_cs.ko] undefined!
ERROR: "das08_common_detach" [drivers/staging/comedi/drivers/das08_cs.ko] undefined!
ERROR: "das08_common_attach" [drivers/staging/comedi/drivers/das08_cs.ko] undefined!
I.e., the "pcmcia" drivers are probably cardbus drivers (or at least some of them are), but there is no differentiation between PCMCIA and CARDBUS.
Signature · 1 line
~Randy